From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Yuti Amonkar <yamonkar@cadence.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
maxime@cerno.tech, airlied@linux.ie, daniel@ffwll.ch,
mark.rutland@arm.com, a.hajda@samsung.com,
narmstrong@baylibre.com, jonas@kwiboo.se,
jernej.skrabec@siol.net, praneeth@ti.com, jsarha@ti.com,
mparab@cadence.com, sjakhade@cadence.com
Subject: Re: [PATCH v5 1/3] dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings.
Date: Sun, 16 Feb 2020 17:28:40 +0200 [thread overview]
Message-ID: <20200216152840.GB28645@pendragon.ideasonboard.com> (raw)
In-Reply-To: <b97283b0-e4a5-4b96-e509-b9b5cdd78991@ti.com>
Hi Yuti,
Thank you for the patch.
On Thu, Feb 13, 2020 at 11:16:51AM +0200, Tomi Valkeinen wrote:
> On 12/02/2020 06:26, Yuti Amonkar wrote:
> > Document the bindings used for the Cadence MHDP DPI/DP bridge in
> > yaml format.
> >
> > Signed-off-by: Yuti Amonkar <yamonkar@cadence.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> > .../bindings/display/bridge/cdns,mhdp.yaml | 125 ++++++++++++++++++
> > 1 file changed, 125 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,mhdp.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp.yaml
> > new file mode 100644
> > index 000000000000..e7f84ed1d2da
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp.yaml
> > @@ -0,0 +1,125 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/display/bridge/cdns,mhdp.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Cadence MHDP bridge
> > +
> > +maintainers:
> > + - Swapnil Jakhade <sjakhade@cadence.com>
> > + - Yuti Amonkar <yamonkar@cadence.com>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - cdns,mhdp8546
> > + - ti,j721e-mhdp8546
> > +
> > + reg:
> > + minItems: 1
> > + maxItems: 2
> > + items:
> > + - description:
> > + Register block of mhdptx apb registers upto PHY mapped area(AUX_CONFIG_P).
>
> "up to". Add space before (.
>
> > + The AUX and PMA registers are mapped to associated phy driver.
I wouldn't mention driver here, as that's a software concept unrelated
to DT bindings. You could write "The AUX and PMA registers are not part
of this range, they are instead included in the associated PHY.".
> > + - description:
> > + Register block for DSS_EDP0_INTG_CFG_VP registers in case of TI J7 SoCs.
> > +
> > + reg-names:
> > + minItems: 1
> > + maxItems: 2
> > + items:
> > + - const: mhdptx
> > + - const: j721e-intg
> > +
> > + clocks:
> > + maxItems: 1
> > + description:
> > + DP bridge clock, it's used by the IP to know how to translate a number of
s/it's //
> > + clock cycles into a time (which is used to comply with DP standard timings
> > + and delays).
> > +
> > + phys:
> > + description: Phandle to the DisplyPort phy.
>
> "Display"
And s/Phandle/phandle/, and s/phy/PHY/.
Shouldn't this bridge also have port nodes ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-02-16 15:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 4:26 [PATCH v5 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper Yuti Amonkar
2020-02-12 4:26 ` [PATCH v5 1/3] dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings Yuti Amonkar
2020-02-13 9:16 ` Tomi Valkeinen
2020-02-16 15:28 ` Laurent Pinchart [this message]
2020-02-16 15:31 ` Laurent Pinchart
2020-02-16 15:33 ` Laurent Pinchart
2020-02-12 4:26 ` [PATCH v5 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge Yuti Amonkar
2020-02-13 9:19 ` Tomi Valkeinen
2020-02-12 4:26 ` [PATCH v5 3/3] drm: bridge: cdns-mhdp: add j721e wrapper Yuti Amonkar
2020-02-13 10:29 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200216152840.GB28645@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=jsarha@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime@cerno.tech \
--cc=mparab@cadence.com \
--cc=narmstrong@baylibre.com \
--cc=praneeth@ti.com \
--cc=robh+dt@kernel.org \
--cc=sjakhade@cadence.com \
--cc=tomi.valkeinen@ti.com \
--cc=yamonkar@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).