From: Greg KH <gregkh@linuxfoundation.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Ajay.Kathat@microchip.com, devel@driverdev.osuosl.org,
devicetree@vger.kernel.org, Venkateswara.Kaja@microchip.com,
linux-wireless@vger.kernel.org, Nicolas.Ferre@microchip.com,
Adham.Abozaeid@microchip.com, johannes@sipsolutions.net
Subject: Re: [PATCH v6 00/17] wilc1000: move out of staging
Date: Fri, 27 Mar 2020 12:25:11 +0100 [thread overview]
Message-ID: <20200327112511.GA1708276@kroah.com> (raw)
In-Reply-To: <87ftduoxou.fsf@tynnyri.adurom.net>
On Fri, Mar 27, 2020 at 01:16:01PM +0200, Kalle Valo wrote:
> <Ajay.Kathat@microchip.com> writes:
>
> > From: Ajay Singh <ajay.kathat@microchip.com>
> >
> > This patch series is to review and move wilc1000 driver out of staging.
> > Most of the review comments received in [1] & [2] are addressed in the
> > latest code. Please review and provide your inputs.
> >
> > [1]. https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kathat@microchip.com/
> > [2]. https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kathat@microchip.com/
> >
> > Changes since v5:
> > - handle DT binding review comments suggested in below link:
> > * https://lore.kernel.org/driverdev-devel/20200320175920.GA31641@bogus
> > - merged latest driver from staging which contains few cleanup patches
> > and changes to use crc7 from existing library instead of having
> > private implementation.
>
> This is already the third version this month, please avoid spamming the
> list unnecessarily. What you can do to speed up the acceptance is to get
> Reviewed-by tags from people, the more I see those the more confident I
> get about the driver. I will also review this again once I find some
> free time, but don't know when that will happen.
>
> But it would be good to document in the cover letter what commit id are
> you using as the baseline. That way it's easy to review rest of the
> changes Greg has applied separately and you don't need to resend the
> whole driver everytime.
Using the --base= flag in git format-patch is helpful in automating that
:)
thanks,
greg k-h
next prev parent reply other threads:[~2020-03-27 11:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 6:33 [PATCH v6 00/17] wilc1000: move out of staging Ajay.Kathat
2020-03-27 6:33 ` [PATCH v6 01/17] wilc1000: add hif.h Ajay.Kathat
2020-03-27 6:33 ` [PATCH v6 02/17] wilc1000: add hif.c Ajay.Kathat
2020-03-27 6:33 ` [PATCH v6 03/17] wilc1000: add wlan_if.h Ajay.Kathat
2020-03-27 6:33 ` [PATCH v6 04/17] wilc1000: add wlan_cfg.h Ajay.Kathat
2020-03-27 6:33 ` [PATCH v6 05/17] wilc1000: add wlan_cfg.c Ajay.Kathat
2020-03-27 6:33 ` [PATCH v6 06/17] wilc1000: add cfg80211.c Ajay.Kathat
2020-03-27 6:33 ` [PATCH v6 07/17] wilc1000: add cfg80211.h Ajay.Kathat
2020-03-27 6:33 ` [PATCH v6 08/17] wilc1000: add netdev.h Ajay.Kathat
2020-03-27 6:33 ` [PATCH v6 09/17] wilc1000: add netdev.c Ajay.Kathat
2020-03-27 6:33 ` [PATCH v6 10/17] wilc1000: add mon.c Ajay.Kathat
2020-03-27 6:33 ` [PATCH v6 11/17] wilc1000: add spi.c Ajay.Kathat
2020-03-27 6:33 ` [PATCH v6 12/17] wilc1000: add wlan.h Ajay.Kathat
2020-03-27 6:33 ` [PATCH v6 14/17] wilc1000: add sdio.c Ajay.Kathat
2020-03-27 6:33 ` [PATCH v6 13/17] wilc1000: add wlan.c Ajay.Kathat
2020-03-27 6:33 ` [PATCH v6 15/17] wilc1000: add fw.h Ajay.Kathat
2020-03-27 6:33 ` [PATCH v6 16/17] dt: bindings: net: add microchip,wilc1000.yaml Ajay.Kathat
2020-04-05 1:32 ` Rob Herring
2020-03-27 6:33 ` [PATCH v6 17/17] wilc1000: add Makefile and Kconfig files for wilc1000 compilation Ajay.Kathat
2020-03-27 11:16 ` [PATCH v6 00/17] wilc1000: move out of staging Kalle Valo
2020-03-27 11:25 ` Greg KH [this message]
2020-03-27 12:07 ` Ajay.Kathat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327112511.GA1708276@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Adham.Abozaeid@microchip.com \
--cc=Ajay.Kathat@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Venkateswara.Kaja@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).