From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: "Ezequiel Garcia" <ezequiel@collabora.com>,
kernel@collabora.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, geert+renesas@glider.be,
robh+dt@kernel.org, xuwei5@hisilicon.com,
"Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Subject: Re: [PATCH v2 3/6] ARM: dts: zynq: add port definitions to hdmi-tx@39
Date: Thu, 14 May 2020 04:36:22 +0300 [thread overview]
Message-ID: <20200514013622.GC7425@pendragon.ideasonboard.com> (raw)
In-Reply-To: <9d3a0eea-578d-3138-f386-a3f47fed4233@xilinx.com>
Hello,
On Mon, May 11, 2020 at 02:52:50PM +0200, Michal Simek wrote:
> On 11. 05. 20 14:24, Ezequiel Garcia wrote:
> > (Adding Michal)
> >
> > On Mon, 2020-05-11 at 13:06 +0200, Ricardo Cañuelo wrote:
> >> Define a 'ports' node for 'adv7511: hdmi-tx@39' to make it compliant with
> >> the adi,adv7511 DT binding.
> >>
> >> This fills the minimum requirements to meet the binding requirements,
> >> remote endpoints are not defined.
> >>
> >> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
> >> ---
> >> arch/arm/boot/dts/zynq-zc702.dts | 10 ++++++++++
> >> arch/arm/boot/dts/zynq-zc706.dts | 10 ++++++++++
> >> 2 files changed, 20 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
> >> index 27cd6cb52f1b..79fd236edded 100644
> >> --- a/arch/arm/boot/dts/zynq-zc702.dts
> >> +++ b/arch/arm/boot/dts/zynq-zc702.dts
> >> @@ -135,6 +135,16 @@
> >> adi,input-clock = "1x";
> >> adi,input-style = <3>;
> >> adi,input-justification = "right";
> >> + ports {
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> + port@0 {
> >> + reg = <0>;
> >> + };
> >> + port@1 {
> >> + reg = <1>;
> >> + };
> >> + };
> >> };
> >> };
> >>
> >> diff --git a/arch/arm/boot/dts/zynq-zc706.dts b/arch/arm/boot/dts/zynq-zc706.dts
> >> index 77943c16d33f..99fa51ba6e93 100644
> >> --- a/arch/arm/boot/dts/zynq-zc706.dts
> >> +++ b/arch/arm/boot/dts/zynq-zc706.dts
> >> @@ -93,6 +93,16 @@
> >> adi,input-clock = "1x";
> >> adi,input-style = <3>;
> >> adi,input-justification = "evenly";
> >> + ports {
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> + port@0 {
> >> + reg = <0>;
> >> + };
> >> + port@1 {
> >> + reg = <1>;
> >> + };
> >> + };
> >> };
> >> };
> >>
>
> Just c&p Laurent's reply to Ricardo about it.
>
> "Completing the board definition is best I believe. Sometimes the
> endpoint is related to an add-on board that isn't described as part of
> the base DTS. The ports are required as they describe hardware
> interfaces, but having no endpoint in a port shouldn't be a problem, it
> just means the port is not connected."
>
> I am ok with it too that's why
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-05-14 1:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 11:06 [PATCH v2 0/6] Convert adi,adv7511.txt DT bindings to yaml Ricardo Cañuelo
2020-05-11 11:06 ` [PATCH v2 1/6] arm64: dts: renesas: make hdmi encoder nodes compliant with DT bindings Ricardo Cañuelo
2020-05-11 11:51 ` Geert Uytterhoeven
2020-05-14 1:33 ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 2/6] ARM: " Ricardo Cañuelo
2020-05-11 11:51 ` Geert Uytterhoeven
2020-05-14 1:34 ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 3/6] ARM: dts: zynq: add port definitions to hdmi-tx@39 Ricardo Cañuelo
2020-05-11 12:24 ` Ezequiel Garcia
2020-05-11 12:52 ` Michal Simek
2020-05-14 1:36 ` Laurent Pinchart [this message]
2020-05-11 11:06 ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi,adv7533 DT binding Ricardo Cañuelo
2020-05-14 1:37 ` Laurent Pinchart
2020-08-04 20:57 ` [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 " John Stultz
2020-08-04 21:24 ` John Stultz
2020-05-11 11:06 ` [PATCH v2 5/6] ARM: dts: iwg20d-q7-dbcm-ca: remove unneeded properties in hdmi@39 Ricardo Cañuelo
2020-05-11 11:52 ` Geert Uytterhoeven
2020-05-14 1:37 ` Laurent Pinchart
2020-05-11 11:06 ` [PATCH v2 6/6] dt-bindings: drm: bridge: adi,adv7511.txt: convert to yaml Ricardo Cañuelo
2020-05-14 1:54 ` Laurent Pinchart
2020-05-14 9:36 ` Ricardo Cañuelo
2020-05-14 15:22 ` Laurent Pinchart
2020-05-18 21:27 ` Rob Herring
2020-05-25 7:43 ` Ricardo Cañuelo
2020-05-26 1:44 ` Laurent Pinchart
2020-05-26 7:03 ` Geert Uytterhoeven
2020-05-26 10:11 ` Laurent Pinchart
2020-05-26 10:39 ` Geert Uytterhoeven
2020-05-26 19:45 ` Ezequiel Garcia
2020-05-27 17:29 ` Rob Herring
2020-05-27 18:18 ` Geert Uytterhoeven
2020-05-28 6:36 ` Ricardo Cañuelo
2020-05-11 11:55 ` [PATCH v2 0/6] Convert adi,adv7511.txt DT bindings " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514013622.GC7425@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=geert+renesas@glider.be \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=michal.simek@xilinx.com \
--cc=ricardo.canuelo@collabora.com \
--cc=robh+dt@kernel.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).