* [RFC PATCH 14/14] dts: bindings: coresight: ETMv4.4 system register access only units [not found] <20200722172040.1299289-1-suzuki.poulose@arm.com> @ 2020-07-22 17:20 ` Suzuki K Poulose 2020-07-23 17:27 ` Rob Herring 2020-07-29 17:20 ` Mathieu Poirier 0 siblings, 2 replies; 5+ messages in thread From: Suzuki K Poulose @ 2020-07-22 17:20 UTC (permalink / raw) To: linux-arm-kernel Cc: linux-kernel, mike.leach, mathieu.poirier, coresight, Suzuki K Poulose, Rob Herring, devicetree Document the bindings for ETMv4.4 and later with only system register access. Cc: Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Mike Leach <mike.leach@linaro.org> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> --- Documentation/devicetree/bindings/arm/coresight.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt index d711676b4a51..cfe47bdda728 100644 --- a/Documentation/devicetree/bindings/arm/coresight.txt +++ b/Documentation/devicetree/bindings/arm/coresight.txt @@ -34,9 +34,13 @@ its hardware characteristcs. Program Flow Trace Macrocell: "arm,coresight-etm3x", "arm,primecell"; - - Embedded Trace Macrocell (version 4.x): + - Embedded Trace Macrocell (version 4.x), with memory mapped access. "arm,coresight-etm4x", "arm,primecell"; + - Embedded Trace Macrocell (version 4.4 and later) with system + register access only. + "arm,coresight-etm-v4.4"; + - Coresight programmable Replicator : "arm,coresight-dynamic-replicator", "arm,primecell"; -- 2.24.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RFC PATCH 14/14] dts: bindings: coresight: ETMv4.4 system register access only units 2020-07-22 17:20 ` [RFC PATCH 14/14] dts: bindings: coresight: ETMv4.4 system register access only units Suzuki K Poulose @ 2020-07-23 17:27 ` Rob Herring 2020-07-29 17:20 ` Mathieu Poirier 1 sibling, 0 replies; 5+ messages in thread From: Rob Herring @ 2020-07-23 17:27 UTC (permalink / raw) To: Suzuki K Poulose Cc: linux-arm-kernel, linux-kernel, coresight, Rob Herring, mathieu.poirier, mike.leach, devicetree On Wed, 22 Jul 2020 18:20:40 +0100, Suzuki K Poulose wrote: > Document the bindings for ETMv4.4 and later with only system register > access. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > Cc: Mike Leach <mike.leach@linaro.org> > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > --- > Documentation/devicetree/bindings/arm/coresight.txt | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC PATCH 14/14] dts: bindings: coresight: ETMv4.4 system register access only units 2020-07-22 17:20 ` [RFC PATCH 14/14] dts: bindings: coresight: ETMv4.4 system register access only units Suzuki K Poulose 2020-07-23 17:27 ` Rob Herring @ 2020-07-29 17:20 ` Mathieu Poirier 2020-07-30 16:38 ` Suzuki K Poulose 1 sibling, 1 reply; 5+ messages in thread From: Mathieu Poirier @ 2020-07-29 17:20 UTC (permalink / raw) To: Suzuki K Poulose Cc: linux-arm-kernel, linux-kernel, mike.leach, coresight, Rob Herring, devicetree On Wed, Jul 22, 2020 at 06:20:40PM +0100, Suzuki K Poulose wrote: > Document the bindings for ETMv4.4 and later with only system register > access. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > Cc: Mike Leach <mike.leach@linaro.org> > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > --- > Documentation/devicetree/bindings/arm/coresight.txt | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt > index d711676b4a51..cfe47bdda728 100644 > --- a/Documentation/devicetree/bindings/arm/coresight.txt > +++ b/Documentation/devicetree/bindings/arm/coresight.txt > @@ -34,9 +34,13 @@ its hardware characteristcs. > Program Flow Trace Macrocell: > "arm,coresight-etm3x", "arm,primecell"; > > - - Embedded Trace Macrocell (version 4.x): > + - Embedded Trace Macrocell (version 4.x), with memory mapped access. > "arm,coresight-etm4x", "arm,primecell"; > > + - Embedded Trace Macrocell (version 4.4 and later) with system > + register access only. > + "arm,coresight-etm-v4.4"; I would rather call this "arm,coresight-etm-v4.4+" so that the binding's semantic is still relevant when dealing with ETM v4.5 and onward. Thanks, Mathieu > + > - Coresight programmable Replicator : > "arm,coresight-dynamic-replicator", "arm,primecell"; > > -- > 2.24.1 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC PATCH 14/14] dts: bindings: coresight: ETMv4.4 system register access only units 2020-07-29 17:20 ` Mathieu Poirier @ 2020-07-30 16:38 ` Suzuki K Poulose 2020-08-10 20:14 ` Mathieu Poirier 0 siblings, 1 reply; 5+ messages in thread From: Suzuki K Poulose @ 2020-07-30 16:38 UTC (permalink / raw) To: mathieu.poirier Cc: linux-arm-kernel, linux-kernel, mike.leach, coresight, robh+dt, devicetree On 07/29/2020 06:20 PM, Mathieu Poirier wrote: > On Wed, Jul 22, 2020 at 06:20:40PM +0100, Suzuki K Poulose wrote: >> Document the bindings for ETMv4.4 and later with only system register >> access. >> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: devicetree@vger.kernel.org >> Cc: Mathieu Poirier <mathieu.poirier@linaro.org> >> Cc: Mike Leach <mike.leach@linaro.org> >> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> >> --- >> Documentation/devicetree/bindings/arm/coresight.txt | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt >> index d711676b4a51..cfe47bdda728 100644 >> --- a/Documentation/devicetree/bindings/arm/coresight.txt >> +++ b/Documentation/devicetree/bindings/arm/coresight.txt >> @@ -34,9 +34,13 @@ its hardware characteristcs. >> Program Flow Trace Macrocell: >> "arm,coresight-etm3x", "arm,primecell"; >> >> - - Embedded Trace Macrocell (version 4.x): >> + - Embedded Trace Macrocell (version 4.x), with memory mapped access. >> "arm,coresight-etm4x", "arm,primecell"; >> >> + - Embedded Trace Macrocell (version 4.4 and later) with system >> + register access only. >> + "arm,coresight-etm-v4.4"; > > I would rather call this "arm,coresight-etm-v4.4+" so that the binding's > semantic is still relevant when dealing with ETM v4.5 and onward. AFAIUC, "compatible" stands for something that is compatible with v4.4. All v4.4+ versions that are compatible with v4.4 are covered here. Having said that I am fine with "arm,coresight-etm-v4.4+" , if it is fine by the DT conventions. Cheers Suzuki ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC PATCH 14/14] dts: bindings: coresight: ETMv4.4 system register access only units 2020-07-30 16:38 ` Suzuki K Poulose @ 2020-08-10 20:14 ` Mathieu Poirier 0 siblings, 0 replies; 5+ messages in thread From: Mathieu Poirier @ 2020-08-10 20:14 UTC (permalink / raw) To: Suzuki K Poulose Cc: linux-arm-kernel, linux-kernel, mike.leach, coresight, robh+dt, devicetree On Thu, Jul 30, 2020 at 05:38:37PM +0100, Suzuki K Poulose wrote: > On 07/29/2020 06:20 PM, Mathieu Poirier wrote: > > On Wed, Jul 22, 2020 at 06:20:40PM +0100, Suzuki K Poulose wrote: > > > Document the bindings for ETMv4.4 and later with only system register > > > access. > > > > > > Cc: Rob Herring <robh+dt@kernel.org> > > > Cc: devicetree@vger.kernel.org > > > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > > > Cc: Mike Leach <mike.leach@linaro.org> > > > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > > > --- > > > Documentation/devicetree/bindings/arm/coresight.txt | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt > > > index d711676b4a51..cfe47bdda728 100644 > > > --- a/Documentation/devicetree/bindings/arm/coresight.txt > > > +++ b/Documentation/devicetree/bindings/arm/coresight.txt > > > @@ -34,9 +34,13 @@ its hardware characteristcs. > > > Program Flow Trace Macrocell: > > > "arm,coresight-etm3x", "arm,primecell"; > > > - - Embedded Trace Macrocell (version 4.x): > > > + - Embedded Trace Macrocell (version 4.x), with memory mapped access. > > > "arm,coresight-etm4x", "arm,primecell"; > > > + - Embedded Trace Macrocell (version 4.4 and later) with system > > > + register access only. > > > + "arm,coresight-etm-v4.4"; > > > > I would rather call this "arm,coresight-etm-v4.4+" so that the binding's > > semantic is still relevant when dealing with ETM v4.5 and onward. > > AFAIUC, "compatible" stands for something that is compatible with v4.4. > All v4.4+ versions that are compatible with v4.4 are covered here. Your position is valid - let's to with what you had. > Having said that I am fine with "arm,coresight-etm-v4.4+" , if it > is fine by the DT conventions. > > Cheers > Suzuki ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-10 20:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200722172040.1299289-1-suzuki.poulose@arm.com>
2020-07-22 17:20 ` [RFC PATCH 14/14] dts: bindings: coresight: ETMv4.4 system register access only units Suzuki K Poulose
2020-07-23 17:27 ` Rob Herring
2020-07-29 17:20 ` Mathieu Poirier
2020-07-30 16:38 ` Suzuki K Poulose
2020-08-10 20:14 ` Mathieu Poirier
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).