* [PATCH] ARM: dts: imx25-pinfunc: Fix gpio function name for pads GPIO_[A-F]
@ 2020-08-10 8:47 Uwe Kleine-König
2020-08-22 12:56 ` Shawn Guo
2021-05-11 1:39 ` Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2020-08-10 8:47 UTC (permalink / raw)
To: Shawn Guo
Cc: Rob Herring, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel
The pinfunc definitions used GPIO_A as function instead of GPIO_1_0 as
done for all the other pins with GPIO functionality. Fix for consistency.
There are no mainline users that needs adaption.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/imx25-pinfunc.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/imx25-pinfunc.h b/arch/arm/boot/dts/imx25-pinfunc.h
index e14140e62b9b..55948e668410 100644
--- a/arch/arm/boot/dts/imx25-pinfunc.h
+++ b/arch/arm/boot/dts/imx25-pinfunc.h
@@ -563,15 +563,15 @@
#define MX25_PAD_DE_B__DE_B 0x1f0 0x3ec 0x000 0x00 0x000
#define MX25_PAD_DE_B__GPIO_2_20 0x1f0 0x3ec 0x000 0x05 0x000
-#define MX25_PAD_GPIO_A__GPIO_A 0x1f4 0x3f0 0x000 0x00 0x000
+#define MX25_PAD_GPIO_A__GPIO_1_0 0x1f4 0x3f0 0x000 0x00 0x000
#define MX25_PAD_GPIO_A__CAN1_TX 0x1f4 0x3f0 0x000 0x06 0x000
#define MX25_PAD_GPIO_A__USBOTG_PWR 0x1f4 0x3f0 0x000 0x02 0x000
-#define MX25_PAD_GPIO_B__GPIO_B 0x1f8 0x3f4 0x000 0x00 0x000
+#define MX25_PAD_GPIO_B__GPIO_1_1 0x1f8 0x3f4 0x000 0x00 0x000
#define MX25_PAD_GPIO_B__USBOTG_OC 0x1f8 0x3f4 0x57c 0x02 0x001
#define MX25_PAD_GPIO_B__CAN1_RX 0x1f8 0x3f4 0x480 0x06 0x001
-#define MX25_PAD_GPIO_C__GPIO_C 0x1fc 0x3f8 0x000 0x00 0x000
+#define MX25_PAD_GPIO_C__GPIO_1_2 0x1fc 0x3f8 0x000 0x00 0x000
#define MX25_PAD_GPIO_C__PWM4_PWMO 0x1fc 0x3f8 0x000 0x01 0x000
#define MX25_PAD_GPIO_C__I2C2_SCL 0x1fc 0x3f8 0x51c 0x02 0x001
#define MX25_PAD_GPIO_C__KPP_COL4 0x1fc 0x3f8 0x52c 0x03 0x001
@@ -579,18 +579,18 @@
#define MX25_PAD_GPIO_C__CAN2_TX 0x1fc 0x3f8 0x000 0x06 0x000
#define MX25_PAD_GPIO_C__CSPI2_SS2 0x1fc 0x3f8 0x000 0x07 0x000
-#define MX25_PAD_GPIO_D__GPIO_D 0x200 0x3fc 0x000 0x00 0x000
+#define MX25_PAD_GPIO_D__GPIO_1_3 0x200 0x3fc 0x000 0x00 0x000
#define MX25_PAD_GPIO_D__I2C2_SDA 0x200 0x3fc 0x520 0x02 0x001
#define MX25_PAD_GPIO_D__CAN2_RX 0x200 0x3fc 0x484 0x06 0x001
#define MX25_PAD_GPIO_D__CSPI3_SS2 0x200 0x3fc 0x4c4 0x07 0x001
-#define MX25_PAD_GPIO_E__GPIO_E 0x204 0x400 0x000 0x00 0x000
+#define MX25_PAD_GPIO_E__GPIO_1_4 0x204 0x400 0x000 0x00 0x000
#define MX25_PAD_GPIO_E__I2C3_CLK 0x204 0x400 0x524 0x01 0x002
#define MX25_PAD_GPIO_E__LD16 0x204 0x400 0x000 0x02 0x000
#define MX25_PAD_GPIO_E__AUD7_TXD 0x204 0x400 0x000 0x04 0x000
#define MX25_PAD_GPIO_E__UART4_RXD 0x204 0x400 0x570 0x06 0x002
-#define MX25_PAD_GPIO_F__GPIO_F 0x208 0x404 0x000 0x00 0x000
+#define MX25_PAD_GPIO_F__GPIO_1_5 0x208 0x404 0x000 0x00 0x000
#define MX25_PAD_GPIO_F__LD17 0x208 0x404 0x000 0x02 0x000
#define MX25_PAD_GPIO_F__AUD7_TXC 0x208 0x404 0x000 0x04 0x000
#define MX25_PAD_GPIO_F__UART4_TXD 0x208 0x404 0x000 0x06 0x000
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx25-pinfunc: Fix gpio function name for pads GPIO_[A-F]
2020-08-10 8:47 [PATCH] ARM: dts: imx25-pinfunc: Fix gpio function name for pads GPIO_[A-F] Uwe Kleine-König
@ 2020-08-22 12:56 ` Shawn Guo
2021-05-07 9:49 ` Uwe Kleine-König
2021-05-11 1:39 ` Shawn Guo
1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2020-08-22 12:56 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Rob Herring, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel
On Mon, Aug 10, 2020 at 10:47:25AM +0200, Uwe Kleine-König wrote:
> The pinfunc definitions used GPIO_A as function instead of GPIO_1_0 as
Is this how i.MX25 RM names the function?
Shawn
> done for all the other pins with GPIO functionality. Fix for consistency.
>
> There are no mainline users that needs adaption.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> arch/arm/boot/dts/imx25-pinfunc.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx25-pinfunc.h b/arch/arm/boot/dts/imx25-pinfunc.h
> index e14140e62b9b..55948e668410 100644
> --- a/arch/arm/boot/dts/imx25-pinfunc.h
> +++ b/arch/arm/boot/dts/imx25-pinfunc.h
> @@ -563,15 +563,15 @@
> #define MX25_PAD_DE_B__DE_B 0x1f0 0x3ec 0x000 0x00 0x000
> #define MX25_PAD_DE_B__GPIO_2_20 0x1f0 0x3ec 0x000 0x05 0x000
>
> -#define MX25_PAD_GPIO_A__GPIO_A 0x1f4 0x3f0 0x000 0x00 0x000
> +#define MX25_PAD_GPIO_A__GPIO_1_0 0x1f4 0x3f0 0x000 0x00 0x000
> #define MX25_PAD_GPIO_A__CAN1_TX 0x1f4 0x3f0 0x000 0x06 0x000
> #define MX25_PAD_GPIO_A__USBOTG_PWR 0x1f4 0x3f0 0x000 0x02 0x000
>
> -#define MX25_PAD_GPIO_B__GPIO_B 0x1f8 0x3f4 0x000 0x00 0x000
> +#define MX25_PAD_GPIO_B__GPIO_1_1 0x1f8 0x3f4 0x000 0x00 0x000
> #define MX25_PAD_GPIO_B__USBOTG_OC 0x1f8 0x3f4 0x57c 0x02 0x001
> #define MX25_PAD_GPIO_B__CAN1_RX 0x1f8 0x3f4 0x480 0x06 0x001
>
> -#define MX25_PAD_GPIO_C__GPIO_C 0x1fc 0x3f8 0x000 0x00 0x000
> +#define MX25_PAD_GPIO_C__GPIO_1_2 0x1fc 0x3f8 0x000 0x00 0x000
> #define MX25_PAD_GPIO_C__PWM4_PWMO 0x1fc 0x3f8 0x000 0x01 0x000
> #define MX25_PAD_GPIO_C__I2C2_SCL 0x1fc 0x3f8 0x51c 0x02 0x001
> #define MX25_PAD_GPIO_C__KPP_COL4 0x1fc 0x3f8 0x52c 0x03 0x001
> @@ -579,18 +579,18 @@
> #define MX25_PAD_GPIO_C__CAN2_TX 0x1fc 0x3f8 0x000 0x06 0x000
> #define MX25_PAD_GPIO_C__CSPI2_SS2 0x1fc 0x3f8 0x000 0x07 0x000
>
> -#define MX25_PAD_GPIO_D__GPIO_D 0x200 0x3fc 0x000 0x00 0x000
> +#define MX25_PAD_GPIO_D__GPIO_1_3 0x200 0x3fc 0x000 0x00 0x000
> #define MX25_PAD_GPIO_D__I2C2_SDA 0x200 0x3fc 0x520 0x02 0x001
> #define MX25_PAD_GPIO_D__CAN2_RX 0x200 0x3fc 0x484 0x06 0x001
> #define MX25_PAD_GPIO_D__CSPI3_SS2 0x200 0x3fc 0x4c4 0x07 0x001
>
> -#define MX25_PAD_GPIO_E__GPIO_E 0x204 0x400 0x000 0x00 0x000
> +#define MX25_PAD_GPIO_E__GPIO_1_4 0x204 0x400 0x000 0x00 0x000
> #define MX25_PAD_GPIO_E__I2C3_CLK 0x204 0x400 0x524 0x01 0x002
> #define MX25_PAD_GPIO_E__LD16 0x204 0x400 0x000 0x02 0x000
> #define MX25_PAD_GPIO_E__AUD7_TXD 0x204 0x400 0x000 0x04 0x000
> #define MX25_PAD_GPIO_E__UART4_RXD 0x204 0x400 0x570 0x06 0x002
>
> -#define MX25_PAD_GPIO_F__GPIO_F 0x208 0x404 0x000 0x00 0x000
> +#define MX25_PAD_GPIO_F__GPIO_1_5 0x208 0x404 0x000 0x00 0x000
> #define MX25_PAD_GPIO_F__LD17 0x208 0x404 0x000 0x02 0x000
> #define MX25_PAD_GPIO_F__AUD7_TXC 0x208 0x404 0x000 0x04 0x000
> #define MX25_PAD_GPIO_F__UART4_TXD 0x208 0x404 0x000 0x06 0x000
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx25-pinfunc: Fix gpio function name for pads GPIO_[A-F]
2020-08-22 12:56 ` Shawn Guo
@ 2021-05-07 9:49 ` Uwe Kleine-König
0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2021-05-07 9:49 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree, Rob Herring, NXP Linux Team, Pengutronix Kernel Team,
Fabio Estevam, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1907 bytes --]
Hello Shawn,
digging through my mailbox of unarchived mails I found this patch.
On Sat, Aug 22, 2020 at 08:56:12PM +0800, Shawn Guo wrote:
> On Mon, Aug 10, 2020 at 10:47:25AM +0200, Uwe Kleine-König wrote:
> > The pinfunc definitions used GPIO_A as function instead of GPIO_1_0 as
>
> Is this how i.MX25 RM names the function?
The reference manual (Rev. 2; 01/2011) doesn't give a name. The relevant
description for the GPIO_A pad reads:
MUX Mode Select Field. Select 1 of 7 iomux modes to be used for pad: GPIO_A.
000: Select mux mode: ALT0 mux port: GPIO[0] of instance: gpio1.
...
So I'd say: GPIO_A is the pad name (only) and the function is better
named GPIO_1_0.
Best regards
Uwe
> > done for all the other pins with GPIO functionality. Fix for consistency.
> >
> > There are no mainline users that needs adaption.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > arch/arm/boot/dts/imx25-pinfunc.h | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx25-pinfunc.h b/arch/arm/boot/dts/imx25-pinfunc.h
> > index e14140e62b9b..55948e668410 100644
> > --- a/arch/arm/boot/dts/imx25-pinfunc.h
> > +++ b/arch/arm/boot/dts/imx25-pinfunc.h
> > @@ -563,15 +563,15 @@
> > #define MX25_PAD_DE_B__DE_B 0x1f0 0x3ec 0x000 0x00 0x000
> > #define MX25_PAD_DE_B__GPIO_2_20 0x1f0 0x3ec 0x000 0x05 0x000
> >
> > -#define MX25_PAD_GPIO_A__GPIO_A 0x1f4 0x3f0 0x000 0x00 0x000
> > +#define MX25_PAD_GPIO_A__GPIO_1_0 0x1f4 0x3f0 0x000 0x00 0x000
> > #define MX25_PAD_GPIO_A__CAN1_TX 0x1f4 0x3f0 0x000 0x06 0x000
> > #define MX25_PAD_GPIO_A__USBOTG_PWR 0x1f4 0x3f0 0x000 0x02 0x000
> > [...]
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx25-pinfunc: Fix gpio function name for pads GPIO_[A-F]
2020-08-10 8:47 [PATCH] ARM: dts: imx25-pinfunc: Fix gpio function name for pads GPIO_[A-F] Uwe Kleine-König
2020-08-22 12:56 ` Shawn Guo
@ 2021-05-11 1:39 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2021-05-11 1:39 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Rob Herring, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel
On Mon, Aug 10, 2020 at 10:47:25AM +0200, Uwe Kleine-König wrote:
> The pinfunc definitions used GPIO_A as function instead of GPIO_1_0 as
> done for all the other pins with GPIO functionality. Fix for consistency.
>
> There are no mainline users that needs adaption.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-11 1:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-10 8:47 [PATCH] ARM: dts: imx25-pinfunc: Fix gpio function name for pads GPIO_[A-F] Uwe Kleine-König
2020-08-22 12:56 ` Shawn Guo
2021-05-07 9:49 ` Uwe Kleine-König
2021-05-11 1:39 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).