From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sylwester Nawrocki <snawrocki@kernel.org>
Subject: [PATCH 07/13] ARM: dts: exynos: Override thermal by label in Exynos5250
Date: Tue, 1 Sep 2020 09:54:11 +0200 [thread overview]
Message-ID: <20200901075417.22481-8-krzk@kernel.org> (raw)
In-Reply-To: <20200901075417.22481-1-krzk@kernel.org>
Using full paths to extend or override a device tree node is error prone
since if there was a typo error, a new node will be created instead of
extending the node as it was desired. This will lead to run-time errors
that could be hard to detect.
A mistyped label on the other hand, will cause a dtc compile error
(during build time).
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm/boot/dts/exynos5250.dtsi | 38 +++++++++++++++----------------
1 file changed, 18 insertions(+), 20 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 0249d16e187f..488d3f9fab59 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -1085,26 +1085,6 @@
};
};
- thermal-zones {
- cpu_thermal: cpu-thermal {
- polling-delay-passive = <0>;
- polling-delay = <0>;
- thermal-sensors = <&tmu 0>;
-
- cooling-maps {
- map0 {
- /* Corresponds to 800MHz at freq_table */
- cooling-device = <&cpu0 9 9>, <&cpu1 9 9>;
- };
- map1 {
- /* Corresponds to 200MHz at freq_table */
- cooling-device = <&cpu0 15 15>,
- <&cpu1 15 15>;
- };
- };
- };
- };
-
timer {
compatible = "arm,armv7-timer";
interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
@@ -1120,6 +1100,24 @@
};
};
+&cpu_thermal {
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
+ thermal-sensors = <&tmu 0>;
+
+ cooling-maps {
+ map0 {
+ /* Corresponds to 800MHz at freq_table */
+ cooling-device = <&cpu0 9 9>, <&cpu1 9 9>;
+ };
+ map1 {
+ /* Corresponds to 200MHz at freq_table */
+ cooling-device = <&cpu0 15 15>,
+ <&cpu1 15 15>;
+ };
+ };
+};
+
&dp {
power-domains = <&pd_disp1>;
clocks = <&clock CLK_DP>;
--
2.17.1
next prev parent reply other threads:[~2020-09-01 7:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 7:54 [PATCH 00/13] ARM: dts: exynos: dtschema cleanups for Exynos5 Krzysztof Kozlowski
2020-09-01 7:54 ` [PATCH 01/13] ARM: dts: exynos: Correct compatible for Exynos5 GIC Krzysztof Kozlowski
2020-09-03 20:48 ` Krzysztof Kozlowski
2020-09-01 7:54 ` [PATCH 02/13] ARM: dts: exynos: Correct compatible for Exynos5260 GIC Krzysztof Kozlowski
2020-09-01 7:54 ` [PATCH 03/13] ARM: dts: exynos: Remove unneeded address/size cells in " Krzysztof Kozlowski
2020-09-01 7:54 ` [PATCH 04/13] ARM: dts: exynos: Correct S3C RTC bindings in SMDK5410 Krzysztof Kozlowski
2020-09-01 7:54 ` [PATCH 05/13] ARM: dts: exynos: Silence i2c-gpio dtschema warning in Exynos5250 Arndale Krzysztof Kozlowski
2020-09-01 7:54 ` [PATCH 06/13] ARM: dts: exynos: Correct whitespace and indentation issues in Exynos5 Krzysztof Kozlowski
2020-09-01 7:54 ` Krzysztof Kozlowski [this message]
2020-09-01 7:54 ` [PATCH 08/13] ARM: dts: exynos: Add max77686 clocks for S3C RTC in SMDK5250 Krzysztof Kozlowski
2020-09-01 7:54 ` [PATCH 09/13] ARM: dts: exynos: Use S5M8767 clock in S3C RTC in Exynos5250 Spring Krzysztof Kozlowski
2020-09-01 7:54 ` [PATCH 10/13] ARM: dts: exynos: Silence DP HPD pinctrl dtschema warning " Krzysztof Kozlowski
2020-09-01 7:54 ` [PATCH 11/13] ARM: dts: exynos: Silence SATA PHY warning in Exynos5250 Arndale Krzysztof Kozlowski
2020-09-01 8:13 ` Marek Szyprowski
2020-09-01 8:17 ` Krzysztof Kozlowski
2020-09-01 8:19 ` Krzysztof Kozlowski
2020-09-01 8:36 ` Marek Szyprowski
2020-09-01 8:42 ` Krzysztof Kozlowski
2020-09-01 7:54 ` [PATCH 12/13] ARM: dts: exynos: Silence SATA PHY warning in SMDK5250 Krzysztof Kozlowski
2020-09-01 7:54 ` [PATCH 13/13] ARM: dts: exynos: Use S2MPS11 clock in S3C RTC in SMDK5420 Krzysztof Kozlowski
2020-09-04 8:59 ` Krzysztof Kozlowski
2020-09-01 8:02 ` [PATCH 00/13] ARM: dts: exynos: dtschema cleanups for Exynos5 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901075417.22481-8-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=snawrocki@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).