From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
David Jander <david@protonic.nl>,
"Robin van der Gracht" <robin@protonic.nl>,
<linux-iio@vger.kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH v6 1/3] dt-bindings:iio:adc: add generic settling-time-us and oversampling-ratio channel properties
Date: Wed, 28 Apr 2021 17:59:31 +0100 [thread overview]
Message-ID: <20210428175931.00002a7e@Huawei.com> (raw)
In-Reply-To: <20210428073208.19570-2-o.rempel@pengutronix.de>
On Wed, 28 Apr 2021 09:32:06 +0200
Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> Settling time and over sampling is a typical challenge for different IIO ADC
> devices. So, introduce channel specific settling-time-us and oversampling-ratio
> properties to cover this use case.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
This and patch 2 both look good to me. Given Rob gave a minor comment on the
previous version I don't feel I need him to look at this again.
Will pick up in a few days if no other reviews come in to require a v7.
Thanks,
Jonathan
> ---
> Documentation/devicetree/bindings/iio/adc/adc.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> index 912a7635edc4..db348fcbb52c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> @@ -39,4 +39,16 @@ properties:
> The first value specifies the positive input pin, the second
> specifies the negative input pin.
>
> + settling-time-us:
> + description:
> + Time between enabling the channel and first stable readings.
> +
> + oversampling-ratio:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Oversampling is used as replacement of or addition to the low-pass filter.
> + In some cases, the desired filtering characteristics are a function the
> + device design and can interact with other characteristics such as
> + settling time.
> +
> additionalProperties: true
next prev parent reply other threads:[~2021-04-28 17:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 7:32 [PATCH v6 0/3] mainline ti tsc2046 adc driver Oleksij Rempel
2021-04-28 7:32 ` [PATCH v6 1/3] dt-bindings:iio:adc: add generic settling-time-us and oversampling-ratio channel properties Oleksij Rempel
2021-04-28 16:59 ` Jonathan Cameron [this message]
2021-04-29 4:26 ` Oleksij Rempel
2021-04-30 20:11 ` Rob Herring
2021-04-28 7:32 ` [PATCH v6 2/3] dt-bindings:iio:adc: add documentation for TI TSC2046 controller Oleksij Rempel
2021-04-28 7:32 ` [PATCH v6 3/3] iio: adc: add ADC driver for the " Oleksij Rempel
2021-04-28 16:56 ` Jonathan Cameron
2021-05-03 11:28 ` [PATCH v6 0/3] mainline ti tsc2046 adc driver Jonathan Cameron
2021-05-14 7:57 ` Oleksij Rempel
2021-05-14 8:15 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428175931.00002a7e@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).