* [PATCH v7 0/4] Add LTE SKU for sc7280-evoker family
@ 2022-10-06 10:58 Sheng-Liang Pan
2022-10-06 10:58 ` [PATCH v7 1/4] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker Sheng-Liang Pan
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Sheng-Liang Pan @ 2022-10-06 10:58 UTC (permalink / raw)
To: LKML
Cc: dianders, Sheng-Liang Pan, Andy Gross, Bjorn Andersson,
Dmitry Torokhov, Rob Herring, Stephen Boyd, devicetree,
linux-arm-msm, linux-input
This patch add common dtsi and WIFI/LTE dts for evoker
Changes in v7:
- goodix gt7986 dt bindings added in v7
- add compiatable for gt7986
Changes in v6:
- add removed pinctrl and align touchscreen label with herobrine board
Changes in v5:
- recover whitespace change
- new patch for Touchscreen/trackpad in v5
Changes in v4:
- fix typo in tittle and commit
- recover change for trackpad and touchscreen
Changes in v3:
- none
Changes in v2:
- none
Sheng-Liang Pan (4):
dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker
arm64: dts: qcom: Add LTE SKU for sc7280-evoker family
dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip
arm64: dts: qcom: Add touchscreen and touchpad support for evoker
.../devicetree/bindings/arm/qcom.yaml | 5 +++++
.../bindings/input/goodix,gt7375p.yaml | 5 ++++-
arch/arm64/boot/dts/qcom/Makefile | 3 ++-
.../dts/qcom/sc7280-herobrine-evoker-lte.dts | 14 ++++++++++++
.../boot/dts/qcom/sc7280-herobrine-evoker.dts | 15 +++++++++++++
...er-r0.dts => sc7280-herobrine-evoker.dtsi} | 22 ++++++-------------
6 files changed, 47 insertions(+), 17 deletions(-)
create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts
rename arch/arm64/boot/dts/qcom/{sc7280-herobrine-evoker-r0.dts => sc7280-herobrine-evoker.dtsi} (95%)
--
2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v7 1/4] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker
2022-10-06 10:58 [PATCH v7 0/4] Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
@ 2022-10-06 10:58 ` Sheng-Liang Pan
2022-10-06 10:58 ` [PATCH v7 2/4] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Sheng-Liang Pan @ 2022-10-06 10:58 UTC (permalink / raw)
To: LKML
Cc: dianders, Sheng-Liang Pan, Krzysztof Kozlowski, Andy Gross,
Bjorn Andersson, Rob Herring, Stephen Boyd, devicetree,
linux-arm-msm
evoker will have WIFI/LTE SKU, separate it for each different setting.
Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
(no changes since v4)
Changes in v4:
- fix typo in tittle and commit
Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 8060c35d003b4..c15a729a6852e 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -513,6 +513,11 @@ properties:
- const: google,evoker
- const: qcom,sc7280
+ - description: Google Evoker with LTE (newest rev)
+ items:
+ - const: google,evoker-sku512
+ - const: qcom,sc7280
+
- description: Google Herobrine (newest rev)
items:
- const: google,herobrine
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v7 2/4] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family
2022-10-06 10:58 [PATCH v7 0/4] Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
2022-10-06 10:58 ` [PATCH v7 1/4] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker Sheng-Liang Pan
@ 2022-10-06 10:58 ` Sheng-Liang Pan
2022-10-06 10:58 ` [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip Sheng-Liang Pan
2022-10-06 10:58 ` [PATCH v7 4/4] arm64: dts: qcom: Add touchscreen and touchpad support for evoker Sheng-Liang Pan
3 siblings, 0 replies; 8+ messages in thread
From: Sheng-Liang Pan @ 2022-10-06 10:58 UTC (permalink / raw)
To: LKML
Cc: dianders, Sheng-Liang Pan, Andy Gross, Bjorn Andersson,
Rob Herring, devicetree, linux-arm-msm
evoker have wifi/lte sku, add different dts for each sku.
Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
(no changes since v5)
Changes in v5:
- recover whitespace change
Changes in v4:
- recover change for trackpad and touchscreen
arch/arm64/boot/dts/qcom/Makefile | 3 ++-
.../boot/dts/qcom/sc7280-herobrine-evoker-lte.dts | 14 ++++++++++++++
.../boot/dts/qcom/sc7280-herobrine-evoker.dts | 15 +++++++++++++++
...evoker-r0.dts => sc7280-herobrine-evoker.dtsi} | 7 -------
4 files changed, 31 insertions(+), 8 deletions(-)
create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts
rename arch/arm64/boot/dts/qcom/{sc7280-herobrine-evoker-r0.dts => sc7280-herobrine-evoker.dtsi} (98%)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 65cb0f714ed6b..91153baeeffae 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -95,7 +95,8 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-crd.dtb
-dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker-r0.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker-lte.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-herobrine-r1.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r0.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r1.dtb
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts
new file mode 100644
index 0000000000000..3af9224a7492e
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Evoker board device tree source
+ *
+ * Copyright 2022 Google LLC.
+ */
+
+#include "sc7280-herobrine-evoker.dts"
+#include "sc7280-herobrine-lte-sku.dtsi"
+
+/ {
+ model = "Google Evoker with LTE";
+ compatible = "google,evoker-sku512", "qcom,sc7280";
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts
new file mode 100644
index 0000000000000..dcdd4eecfe670
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Evoker board device tree source
+ *
+ * Copyright 2022 Google LLC.
+ */
+
+/dts-v1/;
+
+#include "sc7280-herobrine-evoker.dtsi"
+
+/ {
+ model = "Google Evoker";
+ compatible = "google,evoker", "qcom,sc7280";
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
similarity index 98%
rename from arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts
rename to arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
index ccbe50b6249ab..e78072159d54b 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
@@ -5,15 +5,8 @@
* Copyright 2022 Google LLC.
*/
-/dts-v1/;
-
#include "sc7280-herobrine.dtsi"
-/ {
- model = "Google Evoker";
- compatible = "google,evoker", "qcom,sc7280";
-};
-
/*
* ADDITIONS TO FIXED REGULATORS DEFINED IN PARENT DEVICE TREE FILES
*
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip
2022-10-06 10:58 [PATCH v7 0/4] Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
2022-10-06 10:58 ` [PATCH v7 1/4] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker Sheng-Liang Pan
2022-10-06 10:58 ` [PATCH v7 2/4] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
@ 2022-10-06 10:58 ` Sheng-Liang Pan
2022-10-06 19:53 ` Doug Anderson
2022-10-06 20:08 ` Rob Herring
2022-10-06 10:58 ` [PATCH v7 4/4] arm64: dts: qcom: Add touchscreen and touchpad support for evoker Sheng-Liang Pan
3 siblings, 2 replies; 8+ messages in thread
From: Sheng-Liang Pan @ 2022-10-06 10:58 UTC (permalink / raw)
To: LKML
Cc: dianders, Sheng-Liang Pan, Dmitry Torokhov, Rob Herring,
devicetree, linux-input
Add an goodix touch screen chip GT7986U.
Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
---
Changes in v7:
- goodix gt7986 dt bindings added in v7
Documentation/devicetree/bindings/input/goodix,gt7375p.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
index fe1c5016f7f31..1c191bc5a1782 100644
--- a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
+++ b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
@@ -16,8 +16,11 @@ description:
properties:
compatible:
- items:
+ oneOf:
- const: goodix,gt7375p
+ - items:
+ - const: goodix,gt7986u
+ - const: goodix,gt7375p
reg:
enum:
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v7 4/4] arm64: dts: qcom: Add touchscreen and touchpad support for evoker
2022-10-06 10:58 [PATCH v7 0/4] Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
` (2 preceding siblings ...)
2022-10-06 10:58 ` [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip Sheng-Liang Pan
@ 2022-10-06 10:58 ` Sheng-Liang Pan
2022-10-06 19:54 ` Doug Anderson
3 siblings, 1 reply; 8+ messages in thread
From: Sheng-Liang Pan @ 2022-10-06 10:58 UTC (permalink / raw)
To: LKML
Cc: dianders, Sheng-Liang Pan, Andy Gross, Bjorn Andersson,
Rob Herring, devicetree, linux-arm-msm
Change touchpad and touchscreen node for evoker
Touchpad: SA461D-1011
Touchscreen: GT7986U
Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
---
Changes in v7:
- add compiatable for gt7986
Changes in v6:
- add removed pinctrl and align touchscreen label with herobrine board
Changes in v5:
- new patch for Touchscreen/trackpad in v5
.../boot/dts/qcom/sc7280-herobrine-evoker.dtsi | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
index e78072159d54b..d713750f81019 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
@@ -23,16 +23,15 @@ ap_tp_i2c: &i2c0 {
status = "okay";
clock-frequency = <400000>;
- trackpad: trackpad@2c {
- compatible = "hid-over-i2c";
- reg = <0x2c>;
+ trackpad: trackpad@15 {
+ compatible = "elan,ekth3000";
+ reg = <0x15>;
pinctrl-names = "default";
pinctrl-0 = <&tp_int_odl>;
interrupt-parent = <&tlmm>;
interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
- hid-descr-addr = <0x20>;
vcc-supply = <&pp3300_z1>;
wakeup-source;
@@ -43,9 +42,9 @@ ts_i2c: &i2c13 {
status = "okay";
clock-frequency = <400000>;
- ap_ts: touchscreen@10 {
- compatible = "elan,ekth6915";
- reg = <0x10>;
+ ap_ts: touchscreen@5d {
+ compatible = "goodix,gt7986u", "goodix,gt7375p";
+ reg = <0x5d>;
pinctrl-names = "default";
pinctrl-0 = <&ts_int_conn>, <&ts_rst_conn>;
@@ -54,7 +53,7 @@ ap_ts: touchscreen@10 {
reset-gpios = <&tlmm 54 GPIO_ACTIVE_LOW>;
- vcc33-supply = <&ts_avdd>;
+ vdd-supply = <&ts_avdd>;
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip
2022-10-06 10:58 ` [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip Sheng-Liang Pan
@ 2022-10-06 19:53 ` Doug Anderson
2022-10-06 20:08 ` Rob Herring
1 sibling, 0 replies; 8+ messages in thread
From: Doug Anderson @ 2022-10-06 19:53 UTC (permalink / raw)
To: Sheng-Liang Pan
Cc: LKML, Dmitry Torokhov, Rob Herring, devicetree, linux-input
Hi,
On Thu, Oct 6, 2022 at 3:58 AM Sheng-Liang Pan
<sheng-liang.pan@quanta.corp-partner.google.com> wrote:
>
> Add an goodix touch screen chip GT7986U.
In theory you could beef up the commit message explaining that GT7986U
is expected to be fully compatible with a driver written for GT7375P,
but I wouldn't spin just for that.
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> ---
>
> Changes in v7:
> - goodix gt7986 dt bindings added in v7
>
> Documentation/devicetree/bindings/input/goodix,gt7375p.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> index fe1c5016f7f31..1c191bc5a1782 100644
> --- a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> +++ b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> @@ -16,8 +16,11 @@ description:
>
> properties:
> compatible:
> - items:
> + oneOf:
> - const: goodix,gt7375p
> + - items:
> + - const: goodix,gt7986u
> + - const: goodix,gt7375p
I haven't run this through schema validation, but from a visual
inspection it looks good to me.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 4/4] arm64: dts: qcom: Add touchscreen and touchpad support for evoker
2022-10-06 10:58 ` [PATCH v7 4/4] arm64: dts: qcom: Add touchscreen and touchpad support for evoker Sheng-Liang Pan
@ 2022-10-06 19:54 ` Doug Anderson
0 siblings, 0 replies; 8+ messages in thread
From: Doug Anderson @ 2022-10-06 19:54 UTC (permalink / raw)
To: Sheng-Liang Pan
Cc: LKML, Andy Gross, Bjorn Andersson, Rob Herring, devicetree,
linux-arm-msm
Hi,
On Thu, Oct 6, 2022 at 3:58 AM Sheng-Liang Pan
<sheng-liang.pan@quanta.corp-partner.google.com> wrote:
>
> Change touchpad and touchscreen node for evoker
> Touchpad: SA461D-1011
> Touchscreen: GT7986U
>
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> ---
>
> Changes in v7:
> - add compiatable for gt7986
>
> Changes in v6:
> - add removed pinctrl and align touchscreen label with herobrine board
>
> Changes in v5:
> - new patch for Touchscreen/trackpad in v5
>
> .../boot/dts/qcom/sc7280-herobrine-evoker.dtsi | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip
2022-10-06 10:58 ` [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip Sheng-Liang Pan
2022-10-06 19:53 ` Doug Anderson
@ 2022-10-06 20:08 ` Rob Herring
1 sibling, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-10-06 20:08 UTC (permalink / raw)
To: Sheng-Liang Pan
Cc: Dmitry Torokhov, dianders, linux-input, devicetree, LKML, Rob Herring
On Thu, 06 Oct 2022 18:58:22 +0800, Sheng-Liang Pan wrote:
> Add an goodix touch screen chip GT7986U.
>
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> ---
>
> Changes in v7:
> - goodix gt7986 dt bindings added in v7
>
> Documentation/devicetree/bindings/input/goodix,gt7375p.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-10-06 20:08 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-06 10:58 [PATCH v7 0/4] Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
2022-10-06 10:58 ` [PATCH v7 1/4] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker Sheng-Liang Pan
2022-10-06 10:58 ` [PATCH v7 2/4] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
2022-10-06 10:58 ` [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip Sheng-Liang Pan
2022-10-06 19:53 ` Doug Anderson
2022-10-06 20:08 ` Rob Herring
2022-10-06 10:58 ` [PATCH v7 4/4] arm64: dts: qcom: Add touchscreen and touchpad support for evoker Sheng-Liang Pan
2022-10-06 19:54 ` Doug Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).