From: Sricharan R <sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Abhishek Sahu <absahu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org,
robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
catalin.marinas-5wv7dgnIgG8@public.gmane.org,
will.deacon-5wv7dgnIgG8@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-arm-msm-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 07/15] ARM: dts: ipq4019: Add ipq4019-ap.dk04.1-c1 board file
Date: Tue, 6 Feb 2018 11:48:49 +0530 [thread overview]
Message-ID: <4df81f9e-a018-822c-066b-e9735ed9908b@codeaurora.org> (raw)
In-Reply-To: <6821d93c282c8337b2a58c5c9337a008-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Hi Abhishek,
On 2/3/2018 5:00 PM, Abhishek Sahu wrote:
> On 2018-01-29 10:41, Sricharan R wrote:
>> Signed-off-by: Sricharan R <sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
>> ---
>> arch/arm/boot/dts/Makefile | 1 +
>> arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts | 8 ++++++++
>> 2 files changed, 9 insertions(+)
>> create mode 100644 arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 21ed56d..1a8ab050 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -725,6 +725,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>> qcom-apq8084-mtp.dtb \
>> qcom-ipq4019-ap.dk01.1-c1.dtb \
>> qcom-ipq4019-ap.dk01.1-c2.dtb \
>> + qcom-ipq4019-ap.dk04.1-c1.dtb \
>> qcom-ipq8064-ap148.dtb \
>> qcom-msm8660-surf.dtb \
>> qcom-msm8960-cdp.dtb \
>> diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts
>> b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts
>> new file mode 100644
>> index 0000000..41123be
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts
>> @@ -0,0 +1,8 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +// Copyright (c) 2017, The Linux Foundation. All rights reserved.
>> +
>> +#include "qcom-ipq4019-ap.dk04.1.dtsi"
>> +
>> +/ {
>> + model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK04.1-C1";
>> +};
>
> It seems major diff between DK01 C1 and other variants is
> qpic nand. qpic nand is only available in C1 so do we need
> to disable the nand is base dk04 dtsi and enable it in this
> C1 dts only. same for qpic bam.
C1 - Has QPIC NAND, spi 78b5000-> cs0 -> spi_nor
C5 - Has QPIC NAND, spi 78b5000-> cs0 -> spi_nor, cs1 -> spi_nand
C2 - Has QPIC NAND, spi 78b5000-> cs0 -> spi_nor ( Audio board, yet to be posted for pending audio drivers)
C3 - spi 78b5000-> cs0 -> spi_nor
So C3 is the board where it is disabled and enabled in the rest. But from a
readability point, feels better to touch this only in each board specific file.
So will remove this from the common 04.dtsi and move it to each board file.
Regards,
Sricharan
--
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-06 6:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 5:11 [PATCH 00/15] ARM: dts: ipq: updates to enable a few peripherals Sricharan R
2018-01-29 5:11 ` [PATCH 01/15] firmware: qcom: scm: Add ipq4019 soc compatible Sricharan R
2018-02-05 6:07 ` Rob Herring
2018-02-06 4:46 ` Sricharan R
2018-01-29 5:11 ` [PATCH 02/15] ARM: dts: ipq4019: Add a few peripheral nodes Sricharan R
2018-01-29 5:11 ` [PATCH 03/15] ARM: dts: ipq4019: Change the max opp frequency Sricharan R
2018-01-29 5:11 ` [PATCH 04/15] ARM: dts: ipq4019: Update ipq4019-dk01.1 board data Sricharan R
2018-01-29 5:11 ` [PATCH 05/15] ARM: dts: ipq4019: Add ipq4019-ap-dk01-c2 board file Sricharan R
[not found] ` <1517202689-14212-6-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-03 10:55 ` Abhishek Sahu
2018-02-06 5:55 ` Sricharan R
2018-01-29 5:11 ` [PATCH 06/15] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi Sricharan R
[not found] ` <1517202689-14212-7-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-03 11:17 ` Abhishek Sahu
2018-02-06 6:01 ` Sricharan R
2018-01-29 5:11 ` [PATCH 07/15] ARM: dts: ipq4019: Add ipq4019-ap.dk04.1-c1 board file Sricharan R
[not found] ` <1517202689-14212-8-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-03 11:30 ` Abhishek Sahu
[not found] ` <6821d93c282c8337b2a58c5c9337a008-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-06 6:18 ` Sricharan R [this message]
[not found] ` <1517202689-14212-1-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-01-29 5:11 ` [PATCH 08/15] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk04.1-c5 " Sricharan R
[not found] ` <1517202689-14212-9-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-03 11:33 ` Abhishek Sahu
2018-01-29 5:11 ` [PATCH 09/15] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk04.1-c3 " Sricharan R
2018-02-03 11:37 ` Abhishek Sahu
[not found] ` <4a173ff2a74ed7d1555d52674cf64ddd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-06 6:27 ` Sricharan R
2018-01-29 5:11 ` [PATCH 10/15] ARM: dts: ipq4019: Add ipq4019-ap.dk07.1 common data Sricharan R
2018-01-29 5:11 ` [PATCH 11/15] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk07.1-c1 board file Sricharan R
2018-01-29 5:11 ` [PATCH 12/15] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk07.1-c2 " Sricharan R
2018-02-03 12:13 ` Abhishek Sahu
[not found] ` <033a420e14f090258e4c8f14b7ba89a7-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-07 4:00 ` Sricharan R
2018-01-29 5:11 ` [PATCH 13/15] ARM: dts: ipq8074: Add peripheral nodes Sricharan R
2018-01-29 5:11 ` [PATCH 14/15] ARM: dts: ipq8074: Add pcie nodes Sricharan R
2018-02-01 0:51 ` kbuild test robot
2018-01-29 5:11 ` [PATCH 15/15] ARM: dts: ipq8074: Enable few peripherals for hk01 board Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4df81f9e-a018-822c-066b-e9735ed9908b@codeaurora.org \
--to=sricharan-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=absahu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-msm-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).