* Re: [PATCH V2 1/2] dt-bindings: power: add Amlogic s4 power domains bindings [not found] ` <20211230094434.3053195-2-shunzhou.jiang@amlogic.com> @ 2021-12-30 22:11 ` Martin Blumenstingl 0 siblings, 0 replies; 4+ messages in thread From: Martin Blumenstingl @ 2021-12-30 22:11 UTC (permalink / raw) To: Shunzhou.Jiang Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel, Neil Armstrong, khilman, jbrunet On Thu, Dec 30, 2021 at 10:44 AM Shunzhou.Jiang <shunzhou.jiang@amlogic.com> wrote: > > From: Shunzhou Jiang <shunzhou.jiang@amlogic.com> > > Add the bindings for the Amlogic Secure power domains, controlling the > secure power domains. > > The bindings targets the Amlogic s4, in which the power domains registers > are in secure world. > > Signed-off-by: Shunzhou Jiang <shunzhou.jiang@amlogic.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20211230094434.3053195-3-shunzhou.jiang@amlogic.com>]
* Re: [PATCH V2 2/2] soc: s4: Add support for power domains controller [not found] ` <20211230094434.3053195-3-shunzhou.jiang@amlogic.com> @ 2021-12-30 22:15 ` Martin Blumenstingl 2022-01-12 8:36 ` Neil Armstrong 0 siblings, 1 reply; 4+ messages in thread From: Martin Blumenstingl @ 2021-12-30 22:15 UTC (permalink / raw) To: Shunzhou.Jiang Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel, Neil Armstrong, khilman, jbrunet On Thu, Dec 30, 2021 at 10:44 AM Shunzhou.Jiang <shunzhou.jiang@amlogic.com> wrote: > > From: Shunzhou Jiang <shunzhou.jiang@amlogic.com> > > Add support s4 Power controller. In s4, power control > registers are in secure domain, and should be accessed by smc. > > Signed-off-by: Shunzhou Jiang <shunzhou.jiang@amlogic.com> Also here I don't have any datasheet to compare this with, so this gets my: Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> [...] > + SEC_PD(S4_VPU_HDMI, GENPD_FLAG_ALWAYS_ON), > + SEC_PD(S4_USB_COMB, GENPD_FLAG_ALWAYS_ON), > + SEC_PD(S4_GE2D, 0), > + SEC_PD(S4_ETH, GENPD_FLAG_ALWAYS_ON), For the A1 SoC's UART entry we have the following comment which explains why we want to to be "always on": UART should keep working in ATF after suspend and before resume If for some reason you need to re-send this series then it would be great if you could add a comment above each entry with GENPD_FLAG_ALWAYS_ON. It will help others (like me) understand these SoCs better. Best regards, Martin ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2 2/2] soc: s4: Add support for power domains controller 2021-12-30 22:15 ` [PATCH V2 2/2] soc: s4: Add support for power domains controller Martin Blumenstingl @ 2022-01-12 8:36 ` Neil Armstrong [not found] ` <2022011810264745683311@amlogic.com> 0 siblings, 1 reply; 4+ messages in thread From: Neil Armstrong @ 2022-01-12 8:36 UTC (permalink / raw) To: Martin Blumenstingl, Shunzhou.Jiang Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel, khilman, jbrunet Hi Shunzhou, On 30/12/2021 23:15, Martin Blumenstingl wrote: > On Thu, Dec 30, 2021 at 10:44 AM Shunzhou.Jiang > <shunzhou.jiang@amlogic.com> wrote: >> >> From: Shunzhou Jiang <shunzhou.jiang@amlogic.com> >> >> Add support s4 Power controller. In s4, power control >> registers are in secure domain, and should be accessed by smc. >> >> Signed-off-by: Shunzhou Jiang <shunzhou.jiang@amlogic.com> > Also here I don't have any datasheet to compare this with, so this gets my: > Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > [...] >> + SEC_PD(S4_VPU_HDMI, GENPD_FLAG_ALWAYS_ON), >> + SEC_PD(S4_USB_COMB, GENPD_FLAG_ALWAYS_ON), >> + SEC_PD(S4_GE2D, 0), >> + SEC_PD(S4_ETH, GENPD_FLAG_ALWAYS_ON), > For the A1 SoC's UART entry we have the following comment which > explains why we want to to be "always on": > UART should keep working in ATF after suspend and before resume > > If for some reason you need to re-send this series then it would be > great if you could add a comment above each entry with > GENPD_FLAG_ALWAYS_ON. > It will help others (like me) understand these SoCs better. Can you resend with those comments added so I can apply the patches ? Thanks, Neil > > > Best regards, > Martin > ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <2022011810264745683311@amlogic.com>]
* Re: [PATCH V2 2/2] soc: s4: Add support for power domains controller [not found] ` <2022011810264745683311@amlogic.com> @ 2022-01-20 8:59 ` Neil Armstrong 0 siblings, 0 replies; 4+ messages in thread From: Neil Armstrong @ 2022-01-20 8:59 UTC (permalink / raw) To: shunzhou.jiang, Martin Blumenstingl Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel, khilman, jbrunet Hi Shunzhou, On 18/01/2022 03:26, shunzhou.jiang@amlogic.com wrote: > Dears Neil & Martin: > Sorry for my late reply > S4_VPU_HDMI: for vpu domain, this domain provide power to many moudles(osd, vpp, hdr, dv, di), if close, will cause system crash > S4_USB_COMB domain: for usb, if not always on, all usb status will clear to 0, that's not right status for usb > S4_ETH: for ethernet online wakeup, and if power down, status also not right >>> + SEC_PD(S4_VPU_HDMI, GENPD_FLAG_ALWAYS_ON), >>> + SEC_PD(S4_USB_COMB, GENPD_FLAG_ALWAYS_ON), >>> + SEC_PD(S4_GE2D, 0), >>> + SEC_PD(S4_ETH, GENPD_FLAG_ALWAYS_ON), Thanks for clarifications, can you resend the patchset with those infos in comments like it was done for A1 ? Thanks, Neil > > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ > Shunzhou Jiang > SW Department > > > *From:* Neil Armstrong <mailto:narmstrong@baylibre.com> > *Date:* 2022-01-12 16:36 > *To:* Martin Blumenstingl <mailto:martin.blumenstingl@googlemail.com>; Shunzhou.Jiang <mailto:shunzhou.jiang@amlogic.com> > *CC:* devicetree <mailto:devicetree@vger.kernel.org>; linux-arm-kernel <mailto:linux-arm-kernel@lists.infradead.org>; linux-amlogic <mailto:linux-amlogic@lists.infradead.org>; linux-kernel <mailto:linux-kernel@vger.kernel.org>; khilman <mailto:khilman@baylibre.com>; jbrunet <mailto:jbrunet@baylibre.com> > *Subject:* Re: [PATCH V2 2/2] soc: s4: Add support for power domains controller > [ EXTERNAL EMAIL ] > > Hi Shunzhou, > > On 30/12/2021 23:15, Martin Blumenstingl wrote: > > On Thu, Dec 30, 2021 at 10:44 AM Shunzhou.Jiang > > <shunzhou.jiang@amlogic.com> wrote: > >> > >> From: Shunzhou Jiang <shunzhou.jiang@amlogic.com> > >> > >> Add support s4 Power controller. In s4, power control > >> registers are in secure domain, and should be accessed by smc. > >> > >> Signed-off-by: Shunzhou Jiang <shunzhou.jiang@amlogic.com> > > Also here I don't have any datasheet to compare this with, so this gets my: > > Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > > > [...] > >> + SEC_PD(S4_VPU_HDMI, GENPD_FLAG_ALWAYS_ON), > >> + SEC_PD(S4_USB_COMB, GENPD_FLAG_ALWAYS_ON), > >> + SEC_PD(S4_GE2D, 0), > >> + SEC_PD(S4_ETH, GENPD_FLAG_ALWAYS_ON), > > For the A1 SoC's UART entry we have the following comment which > > explains why we want to to be "always on": > > UART should keep working in ATF after suspend and before resume > > > > If for some reason you need to re-send this series then it would be > > great if you could add a comment above each entry with > > GENPD_FLAG_ALWAYS_ON. > > It will help others (like me) understand these SoCs better. > > Can you resend with those comments added so I can apply the patches ? > > Thanks, > Neil > > > > > > > Best regards, > > Martin > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-20 8:59 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20211230094434.3053195-1-shunzhou.jiang@amlogic.com> [not found] ` <20211230094434.3053195-2-shunzhou.jiang@amlogic.com> 2021-12-30 22:11 ` [PATCH V2 1/2] dt-bindings: power: add Amlogic s4 power domains bindings Martin Blumenstingl [not found] ` <20211230094434.3053195-3-shunzhou.jiang@amlogic.com> 2021-12-30 22:15 ` [PATCH V2 2/2] soc: s4: Add support for power domains controller Martin Blumenstingl 2022-01-12 8:36 ` Neil Armstrong [not found] ` <2022011810264745683311@amlogic.com> 2022-01-20 8:59 ` Neil Armstrong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).