* [PATCH v6 1/5] dt-bindings:drm/bridge:anx7625:add vendor define flags
[not found] <cover.1616135353.git.xji@analogixsemi.com>
@ 2021-03-19 6:32 ` Xin Ji
2021-03-21 12:00 ` Laurent Pinchart
0 siblings, 1 reply; 5+ messages in thread
From: Xin Ji @ 2021-03-19 6:32 UTC (permalink / raw)
To: Rob Herring, David Airlie, Nicolas Boichat, Hsin-Yi Wang
Cc: Daniel Vetter, Sam Ravnborg, Laurent Pinchart, Maxime Ripard,
Mark Brown, Ricardo Cañuelo, dri-devel, devicetree,
Bernie Liang, Sheng Pan, Zhen Li, linux-kernel
Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0,
lane1 swing register array define, and audio enable flag.
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
.../display/bridge/analogix,anx7625.yaml | 58 ++++++++++++++++++-
1 file changed, 57 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
index c789784efe30..3f54d5876982 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
@@ -34,6 +34,26 @@ properties:
description: used for reset chip control, RESET_N pin B7.
maxItems: 1
+ analogix,lane0-swing:
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ minItems: 1
+ maxItems: 20
+ description:
+ an array of swing register setting for DP tx lane0 PHY, please don't
+ add this property, or contact vendor.
+
+ analogix,lane1-swing:
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ minItems: 1
+ maxItems: 20
+ description:
+ an array of swing register setting for DP tx lane1 PHY, please don't
+ add this property, or contact vendor.
+
+ analogix,audio-enable:
+ type: boolean
+ description: let the driver enable audio HDMI codec function or not.
+
ports:
$ref: /schemas/graph.yaml#/properties/ports
@@ -41,13 +61,43 @@ properties:
port@0:
$ref: /schemas/graph.yaml#/properties/port
description:
- Video port for MIPI DSI input.
+ MIPI DSI/DPI input.
+
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ type: object
+ additionalProperties: false
+
+ properties:
+ remote-endpoint: true
+ bus-type: true
+ data-lanes: true
+
+ required:
+ - remote-endpoint
+
+ required:
+ - endpoint
+
port@1:
$ref: /schemas/graph.yaml#/properties/port
description:
Video port for panel or connector.
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ type: object
+ additionalProperties: false
+
+ properties:
+ remote-endpoint: true
+
+ required:
+ - remote-endpoint
+
required:
- port@0
- port@1
@@ -73,6 +123,10 @@ examples:
enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
+ analogix,audio-enable;
+ analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>;
+ analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>;
+
ports {
#address-cells = <1>;
#size-cells = <0>;
@@ -81,6 +135,8 @@ examples:
reg = <0>;
anx7625_in: endpoint {
remote-endpoint = <&mipi_dsi>;
+ bus-type = <5>;
+ data-lanes = <0 1 2 3>;
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v6 1/5] dt-bindings:drm/bridge:anx7625:add vendor define flags
2021-03-19 6:32 ` [PATCH v6 1/5] dt-bindings:drm/bridge:anx7625:add vendor define flags Xin Ji
@ 2021-03-21 12:00 ` Laurent Pinchart
2021-03-24 7:51 ` Xin Ji
0 siblings, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2021-03-21 12:00 UTC (permalink / raw)
To: Xin Ji
Cc: Rob Herring, David Airlie, Nicolas Boichat, Hsin-Yi Wang,
Daniel Vetter, Sam Ravnborg, Maxime Ripard, Mark Brown,
Ricardo Cañuelo, dri-devel, devicetree, Bernie Liang,
Sheng Pan, Zhen Li, linux-kernel
Hi Xin,
Thank you for the patch.
On Fri, Mar 19, 2021 at 02:32:39PM +0800, Xin Ji wrote:
> Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0,
> lane1 swing register array define, and audio enable flag.
>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> .../display/bridge/analogix,anx7625.yaml | 58 ++++++++++++++++++-
> 1 file changed, 57 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index c789784efe30..3f54d5876982 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -34,6 +34,26 @@ properties:
> description: used for reset chip control, RESET_N pin B7.
> maxItems: 1
>
> + analogix,lane0-swing:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 1
> + maxItems: 20
> + description:
> + an array of swing register setting for DP tx lane0 PHY, please don't
> + add this property, or contact vendor.
DT properties need to be documented. Contacting the vendor doesn't count
as documentation I'm afraid.
> +
> + analogix,lane1-swing:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 1
> + maxItems: 20
> + description:
> + an array of swing register setting for DP tx lane1 PHY, please don't
> + add this property, or contact vendor.
> +
> + analogix,audio-enable:
> + type: boolean
> + description: let the driver enable audio HDMI codec function or not.
> +
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
>
> @@ -41,13 +61,43 @@ properties:
> port@0:
> $ref: /schemas/graph.yaml#/properties/port
> description:
> - Video port for MIPI DSI input.
> + MIPI DSI/DPI input.
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + type: object
> + additionalProperties: false
> +
> + properties:
> + remote-endpoint: true
> + bus-type: true
> + data-lanes: true
> +
> + required:
> + - remote-endpoint
> +
> + required:
> + - endpoint
> +
>
> port@1:
> $ref: /schemas/graph.yaml#/properties/port
> description:
> Video port for panel or connector.
>
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + type: object
> + additionalProperties: false
> +
> + properties:
> + remote-endpoint: true
> +
> + required:
> + - remote-endpoint
> +
> required:
> - port@0
> - port@1
> @@ -73,6 +123,10 @@ examples:
> enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
>
> + analogix,audio-enable;
> + analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>;
> + analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>;
> +
> ports {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -81,6 +135,8 @@ examples:
> reg = <0>;
> anx7625_in: endpoint {
> remote-endpoint = <&mipi_dsi>;
> + bus-type = <5>;
> + data-lanes = <0 1 2 3>;
> };
> };
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v6 1/5] dt-bindings:drm/bridge:anx7625:add vendor define flags
2021-03-21 12:00 ` Laurent Pinchart
@ 2021-03-24 7:51 ` Xin Ji
2021-04-01 12:33 ` Robert Foss
0 siblings, 1 reply; 5+ messages in thread
From: Xin Ji @ 2021-03-24 7:51 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Rob Herring, David Airlie, Nicolas Boichat, Hsin-Yi Wang,
Daniel Vetter, Sam Ravnborg, Laurent Pinchart, Maxime Ripard,
Mark Brown, Ricardo Cañuelo, dri-devel, devicetree,
Bernie Liang, Sheng Pan, Zhen Li, linux-kernel
On Sun, Mar 21, 2021 at 02:00:38PM +0200, Laurent Pinchart wrote:
> Hi Xin,
>
> Thank you for the patch.
>
> On Fri, Mar 19, 2021 at 02:32:39PM +0800, Xin Ji wrote:
> > Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0,
> > lane1 swing register array define, and audio enable flag.
> >
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> > .../display/bridge/analogix,anx7625.yaml | 58 ++++++++++++++++++-
> > 1 file changed, 57 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > index c789784efe30..3f54d5876982 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > @@ -34,6 +34,26 @@ properties:
> > description: used for reset chip control, RESET_N pin B7.
> > maxItems: 1
> >
> > + analogix,lane0-swing:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + minItems: 1
> > + maxItems: 20
> > + description:
> > + an array of swing register setting for DP tx lane0 PHY, please don't
> > + add this property, or contact vendor.
>
> DT properties need to be documented. Contacting the vendor doesn't count
> as documentation I'm afraid.
Hi Laurent Pinchart, thanks for your comment. For the DP phy swing
setting, it is hard to describe in here, needs to refer the anx7625
datasheet and programming guide. Basically, no need to change the DP phy
swing setting.
Thanks,
Xin
>
> > +
> > + analogix,lane1-swing:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + minItems: 1
> > + maxItems: 20
> > + description:
> > + an array of swing register setting for DP tx lane1 PHY, please don't
> > + add this property, or contact vendor.
> > +
> > + analogix,audio-enable:
> > + type: boolean
> > + description: let the driver enable audio HDMI codec function or not.
> > +
> > ports:
> > $ref: /schemas/graph.yaml#/properties/ports
> >
> > @@ -41,13 +61,43 @@ properties:
> > port@0:
> > $ref: /schemas/graph.yaml#/properties/port
> > description:
> > - Video port for MIPI DSI input.
> > + MIPI DSI/DPI input.
> > +
> > + properties:
> > + endpoint:
> > + $ref: /schemas/media/video-interfaces.yaml#
> > + type: object
> > + additionalProperties: false
> > +
> > + properties:
> > + remote-endpoint: true
> > + bus-type: true
> > + data-lanes: true
> > +
> > + required:
> > + - remote-endpoint
> > +
> > + required:
> > + - endpoint
> > +
> >
> > port@1:
> > $ref: /schemas/graph.yaml#/properties/port
> > description:
> > Video port for panel or connector.
> >
> > + properties:
> > + endpoint:
> > + $ref: /schemas/media/video-interfaces.yaml#
> > + type: object
> > + additionalProperties: false
> > +
> > + properties:
> > + remote-endpoint: true
> > +
> > + required:
> > + - remote-endpoint
> > +
> > required:
> > - port@0
> > - port@1
> > @@ -73,6 +123,10 @@ examples:
> > enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> > reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
> >
> > + analogix,audio-enable;
> > + analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>;
> > + analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>;
> > +
> > ports {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > @@ -81,6 +135,8 @@ examples:
> > reg = <0>;
> > anx7625_in: endpoint {
> > remote-endpoint = <&mipi_dsi>;
> > + bus-type = <5>;
> > + data-lanes = <0 1 2 3>;
> > };
> > };
> >
>
> --
> Regards,
>
> Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v6 1/5] dt-bindings:drm/bridge:anx7625:add vendor define flags
2021-03-24 7:51 ` Xin Ji
@ 2021-04-01 12:33 ` Robert Foss
2021-04-02 2:29 ` Xin Ji
0 siblings, 1 reply; 5+ messages in thread
From: Robert Foss @ 2021-04-01 12:33 UTC (permalink / raw)
To: Xin Ji
Cc: Laurent Pinchart, Rob Herring, David Airlie, Nicolas Boichat,
Hsin-Yi Wang, Daniel Vetter, Sam Ravnborg, Laurent Pinchart,
Maxime Ripard, Mark Brown, Ricardo Cañuelo, dri-devel,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Bernie Liang, Sheng Pan, Zhen Li, linux-kernel
Hey Xin,
This series no longer applies to drm-misc/drm-misc-next, please rebase it.
On Wed, 24 Mar 2021 at 08:52, Xin Ji <xji@analogixsemi.com> wrote:
>
> On Sun, Mar 21, 2021 at 02:00:38PM +0200, Laurent Pinchart wrote:
> > Hi Xin,
> >
> > Thank you for the patch.
> >
> > On Fri, Mar 19, 2021 at 02:32:39PM +0800, Xin Ji wrote:
> > > Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0,
> > > lane1 swing register array define, and audio enable flag.
> > >
> > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > ---
> > > .../display/bridge/analogix,anx7625.yaml | 58 ++++++++++++++++++-
> > > 1 file changed, 57 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > index c789784efe30..3f54d5876982 100644
> > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > @@ -34,6 +34,26 @@ properties:
> > > description: used for reset chip control, RESET_N pin B7.
> > > maxItems: 1
> > >
> > > + analogix,lane0-swing:
> > > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > > + minItems: 1
> > > + maxItems: 20
> > > + description:
> > > + an array of swing register setting for DP tx lane0 PHY, please don't
> > > + add this property, or contact vendor.
> >
> > DT properties need to be documented. Contacting the vendor doesn't count
> > as documentation I'm afraid.
>
> Hi Laurent Pinchart, thanks for your comment. For the DP phy swing
> setting, it is hard to describe in here, needs to refer the anx7625
> datasheet and programming guide. Basically, no need to change the DP phy
> swing setting.
>
Laurent is right. But if the value practically is a constant, you can
move the swing register into the driver. It should still be documented
as well as possible, but we can be a little bit more flexible.
> > > @@ -73,6 +123,10 @@ examples:
> > > enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> > > reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
> > >
> > > + analogix,audio-enable;
> > > + analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>;
> > > + analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>;
> > > +
> > > ports {
> > > #address-cells = <1>;
> > > #size-cells = <0>;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v6 1/5] dt-bindings:drm/bridge:anx7625:add vendor define flags
2021-04-01 12:33 ` Robert Foss
@ 2021-04-02 2:29 ` Xin Ji
0 siblings, 0 replies; 5+ messages in thread
From: Xin Ji @ 2021-04-02 2:29 UTC (permalink / raw)
To: Robert Foss
Cc: Laurent Pinchart, Rob Herring, David Airlie, Nicolas Boichat,
Hsin-Yi Wang, Daniel Vetter, Sam Ravnborg, Laurent Pinchart,
Maxime Ripard, Mark Brown, Ricardo Cañuelo, dri-devel,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Bernie Liang, Sheng Pan, Zhen Li, linux-kernel
On Thu, Apr 01, 2021 at 02:33:47PM +0200, Robert Foss wrote:
> Hey Xin,
>
> This series no longer applies to drm-misc/drm-misc-next, please rebase it.
Hi Robert Foss, OK, I'll rebase it on the drm-misc-next after confirmed
HDCP patch with Sean Paul.
Thanks,
Xin
>
> On Wed, 24 Mar 2021 at 08:52, Xin Ji <xji@analogixsemi.com> wrote:
> >
> > On Sun, Mar 21, 2021 at 02:00:38PM +0200, Laurent Pinchart wrote:
> > > Hi Xin,
> > >
> > > Thank you for the patch.
> > >
> > > On Fri, Mar 19, 2021 at 02:32:39PM +0800, Xin Ji wrote:
> > > > Add 'bus-type' and 'data-lanes' define for port0. Define DP tx lane0,
> > > > lane1 swing register array define, and audio enable flag.
> > > >
> > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > ---
> > > > .../display/bridge/analogix,anx7625.yaml | 58 ++++++++++++++++++-
> > > > 1 file changed, 57 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > > index c789784efe30..3f54d5876982 100644
> > > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > > @@ -34,6 +34,26 @@ properties:
> > > > description: used for reset chip control, RESET_N pin B7.
> > > > maxItems: 1
> > > >
> > > > + analogix,lane0-swing:
> > > > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > > > + minItems: 1
> > > > + maxItems: 20
> > > > + description:
> > > > + an array of swing register setting for DP tx lane0 PHY, please don't
> > > > + add this property, or contact vendor.
> > >
> > > DT properties need to be documented. Contacting the vendor doesn't count
> > > as documentation I'm afraid.
> >
> > Hi Laurent Pinchart, thanks for your comment. For the DP phy swing
> > setting, it is hard to describe in here, needs to refer the anx7625
> > datasheet and programming guide. Basically, no need to change the DP phy
> > swing setting.
> >
>
> Laurent is right. But if the value practically is a constant, you can
> move the swing register into the driver. It should still be documented
> as well as possible, but we can be a little bit more flexible.
>
> > > > @@ -73,6 +123,10 @@ examples:
> > > > enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> > > > reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
> > > >
> > > > + analogix,audio-enable;
> > > > + analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>;
> > > > + analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>;
> > > > +
> > > > ports {
> > > > #address-cells = <1>;
> > > > #size-cells = <0>;
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-02 2:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1616135353.git.xji@analogixsemi.com>
2021-03-19 6:32 ` [PATCH v6 1/5] dt-bindings:drm/bridge:anx7625:add vendor define flags Xin Ji
2021-03-21 12:00 ` Laurent Pinchart
2021-03-24 7:51 ` Xin Ji
2021-04-01 12:33 ` Robert Foss
2021-04-02 2:29 ` Xin Ji
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).