From: Joakim Zhang <qiangqing.zhang@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: "mturquette@baylibre.com" <mturquette@baylibre.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/7] clk: imx8: Add SCU and LPCG clocks for I2C in CM40 SS
Date: Wed, 26 Feb 2020 02:56:44 +0000 [thread overview]
Message-ID: <DB7PR04MB46183E18F10C5B1B1F214DCCE6EA0@DB7PR04MB4618.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200225175735.GA5232@bogus>
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 2020年2月26日 1:58
> To: Joakim Zhang <qiangqing.zhang@nxp.com>
> Cc: mturquette@baylibre.com; sboyd@kernel.org; mark.rutland@arm.com;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; Anson Huang
> <anson.huang@nxp.com>; Leonard Crestez <leonard.crestez@nxp.com>;
> Daniel Baluta <daniel.baluta@nxp.com>; Aisheng Dong
> <aisheng.dong@nxp.com>; Peng Fan <peng.fan@nxp.com>; Andy Duan
> <fugang.duan@nxp.com>; linux-clk@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 2/7] clk: imx8: Add SCU and LPCG clocks for I2C in CM40 SS
>
> On Mon, Feb 17, 2020 at 11:19:16AM +0800, Joakim Zhang wrote:
> > Add SCU and LPCG clocks for I2C in CM40 SS.
> >
> > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
> > ---
> > include/dt-bindings/clock/imx8-clock.h | 13 ++++++++++++-
> > 1 file changed, 12 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/dt-bindings/clock/imx8-clock.h
> b/include/dt-bindings/clock/imx8-clock.h
> > index 673a8c662340..84a442be700f 100644
> > --- a/include/dt-bindings/clock/imx8-clock.h
> > +++ b/include/dt-bindings/clock/imx8-clock.h
> > @@ -131,7 +131,12 @@
> > #define IMX_ADMA_PWM_CLK 188
> > #define IMX_ADMA_LCD_CLK 189
> >
> > -#define IMX_SCU_CLK_END 190
> > +/* CM40 SS */
> > +#define IMX_CM40_IPG_CLK 200
> > +#define IMX_CM40_I2C_CLK 205
> > +
> > +#define IMX_SCU_CLK_END 220
>
> Why are you skipping numbers?
Hi Rob,
I found that there is a gap in SCU clock between subsystem, some numbers could be reserved for devices which may be added into this subsystem in the future.
Best Regards,
Joakim Zhang
> > +
> >
> > /* LPCG clocks */
> >
> > @@ -290,4 +295,10 @@
> >
> > #define IMX_ADMA_LPCG_CLK_END 45
> >
> > +/* CM40 SS LPCG */
> > +#define IMX_CM40_LPCG_I2C_IPG_CLK 0
> > +#define IMX_CM40_LPCG_I2C_CLK 1
> > +
> > +#define IMX_CM40_LPCG_CLK_END 2
> > +
> > #endif /* __DT_BINDINGS_CLOCK_IMX_H */
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2020-02-26 2:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 3:19 [PATCH 0/7] Add FlexCAN support on i.MX8QXP Joakim Zhang
2020-02-17 3:19 ` [PATCH 1/7] firmware: imx: scu-pd: add power domain for I2C and INTMUX in CM40 SS Joakim Zhang
2020-03-10 3:32 ` Shawn Guo
2020-02-17 3:19 ` [PATCH 2/7] clk: imx8: Add SCU and LPCG clocks for I2C " Joakim Zhang
2020-02-25 17:57 ` Rob Herring
2020-02-26 2:56 ` Joakim Zhang [this message]
2020-03-10 3:42 ` Shawn Guo
2020-02-17 3:19 ` [PATCH 3/7] bindings: clock: imx8qxp: add "fsl,imx8qxp-lpcg-cm40" compatible string Joakim Zhang
2020-02-25 17:58 ` Rob Herring
2020-02-17 3:19 ` [PATCH 4/7] clk: imx: imx8qxp: Enable SCU and LPCG clocks for I2C in CM40 SS Joakim Zhang
2020-03-10 3:45 ` Shawn Guo
2020-03-10 6:01 ` Joakim Zhang
2020-02-17 3:19 ` [PATCH 5/7] arch: arm64: dts: imx8qxp: add device node for I2C and INTMUX " Joakim Zhang
2020-03-10 3:49 ` Shawn Guo
2020-02-17 3:19 ` [PATCH 6/7] clk: imx: imx8qxp: add LPCG clock for FlexCAN in ADMA SS Joakim Zhang
2020-02-17 3:19 ` [PATCH 7/7] arch: arm64: dts: imx8qxp: add device node for CAN " Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR04MB46183E18F10C5B1B1F214DCCE6EA0@DB7PR04MB4618.eurprd04.prod.outlook.com \
--to=qiangqing.zhang@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).