From: Joakim Zhang <qiangqing.zhang@nxp.com>
To: Peng Fan <peng.fan@nxp.com>, Andrew Lunn <andrew@lunn.ch>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
Aisheng Dong <aisheng.dong@nxp.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
Date: Mon, 22 Nov 2021 02:08:28 +0000 [thread overview]
Message-ID: <DB8PR04MB6795270E9F852F33300C0D24E69F9@DB8PR04MB6795.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <DU0PR04MB941710123952E0D448A1B38E889F9@DU0PR04MB9417.eurprd04.prod.outlook.com>
Hi Peng,
> -----Original Message-----
> From: Peng Fan <peng.fan@nxp.com>
> Sent: 2021年11月22日 9:04
> To: Andrew Lunn <andrew@lunn.ch>; Peng Fan (OSS)
> <peng.fan@oss.nxp.com>
> Cc: robh+dt@kernel.org; Aisheng Dong <aisheng.dong@nxp.com>; Joakim
> Zhang <qiangqing.zhang@nxp.com>; davem@davemloft.net;
> kuba@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> <linux-imx@nxp.com>; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org
> Subject: RE: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
>
> > Subject: Re: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
> >
> > > +&fec {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_enet>;
> > > + phy-mode = "rmii";
> >
> > Is this really a Fast Ethernet? Not 1G?
>
> Not 1G. it only support 10M/100M ethernet.
>
> >
> > > + phy-handle = <ðphy>;
> > > + status = "okay";
> > > +
> > > + mdio {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > +
> > > + ethphy: ethernet-phy {
> > > + reg = <1>;
> >
> > I'm surprised this does not give warnings from the DTS tools. There is
> > a reg value, so it should be ethernet-phy@1
>
> I not see warning per my build:
> "
> *** Default configuration is based on 'defconfig'
> #
> # No change to .config
> #
> CALL scripts/atomic/check-atomics.sh
> CALL scripts/checksyscalls.sh
> CHK include/generated/compile.h
> DTC arch/arm64/boot/dts/freescale/imx8ulp-evk.dtb
> "
> Anyway I will check and fix if the node needs a fix.
According to PHY guide, Documentation/devicetree/bindings/net/ethernet-phy.yaml, yes, we need write to ' ethernet-phy@1'.
DTS tool may not complain it, I guess 'make dtbs_check' could give a warning...
Best Regards,
Joakim Zhang
> Thanks,
> Peng
>
> >
> > Andrew
prev parent reply other threads:[~2021-11-22 2:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 11:58 [PATCH 0/4] dt-bindings/dts: add i.MX8ULP FEC Peng Fan (OSS)
2021-11-20 11:58 ` [PATCH 1/4] dt-bindings: net: fec: simplify yaml Peng Fan (OSS)
2021-11-22 2:07 ` Joakim Zhang
2021-11-23 9:29 ` Peng Fan
2021-11-23 10:39 ` Joakim Zhang
2021-11-30 2:03 ` Rob Herring
2021-11-20 11:58 ` [PATCH 2/4] dt-bindings: net: fec: Add imx8ulp compatible string Peng Fan (OSS)
2021-11-30 2:04 ` Rob Herring
2021-11-20 11:58 ` [PATCH 3/4] arm64: dts: imx8ulp: add fec node Peng Fan (OSS)
2021-11-22 2:07 ` Joakim Zhang
2021-11-20 11:58 ` [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec Peng Fan (OSS)
2021-11-20 15:26 ` Andrew Lunn
2021-11-22 1:04 ` Peng Fan
2021-11-22 2:08 ` Joakim Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8PR04MB6795270E9F852F33300C0D24E69F9@DB8PR04MB6795.eurprd04.prod.outlook.com \
--to=qiangqing.zhang@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).