From: Andrew Lunn <andrew@lunn.ch>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: robh+dt@kernel.org, aisheng.dong@nxp.com,
qiangqing.zhang@nxp.com, davem@davemloft.net, kuba@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
Date: Sat, 20 Nov 2021 16:26:09 +0100 [thread overview]
Message-ID: <YZkTkagrQ/zafYEQ@lunn.ch> (raw)
In-Reply-To: <20211120115825.851798-5-peng.fan@oss.nxp.com>
> +&fec {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_enet>;
> + phy-mode = "rmii";
Is this really a Fast Ethernet? Not 1G?
> + phy-handle = <ðphy>;
> + status = "okay";
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ethphy: ethernet-phy {
> + reg = <1>;
I'm surprised this does not give warnings from the DTS tools. There is
a reg value, so it should be ethernet-phy@1
Andrew
next prev parent reply other threads:[~2021-11-20 15:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 11:58 [PATCH 0/4] dt-bindings/dts: add i.MX8ULP FEC Peng Fan (OSS)
2021-11-20 11:58 ` [PATCH 1/4] dt-bindings: net: fec: simplify yaml Peng Fan (OSS)
2021-11-22 2:07 ` Joakim Zhang
2021-11-23 9:29 ` Peng Fan
2021-11-23 10:39 ` Joakim Zhang
2021-11-30 2:03 ` Rob Herring
2021-11-20 11:58 ` [PATCH 2/4] dt-bindings: net: fec: Add imx8ulp compatible string Peng Fan (OSS)
2021-11-30 2:04 ` Rob Herring
2021-11-20 11:58 ` [PATCH 3/4] arm64: dts: imx8ulp: add fec node Peng Fan (OSS)
2021-11-22 2:07 ` Joakim Zhang
2021-11-20 11:58 ` [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec Peng Fan (OSS)
2021-11-20 15:26 ` Andrew Lunn [this message]
2021-11-22 1:04 ` Peng Fan
2021-11-22 2:08 ` Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZkTkagrQ/zafYEQ@lunn.ch \
--to=andrew@lunn.ch \
--cc=aisheng.dong@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=qiangqing.zhang@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).