devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@nxp.com>
To: Joakim Zhang <qiangqing.zhang@nxp.com>,
	"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
Date: Tue, 23 Nov 2021 09:29:26 +0000	[thread overview]
Message-ID: <DU0PR04MB9417842B67DE3FC3C28B120788609@DU0PR04MB9417.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <DB8PR04MB6795E60F4D2CED35569CBFA7E69F9@DB8PR04MB6795.eurprd04.prod.outlook.com>

> Subject: RE: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
> 
> 
> Hi Peng,
> 
> Thanks a lot for helping upstream this patch set.
> 
> For this change, have you run 'make dtbs_check'? I remember that split them
> to pass dtbs_check when convert it into yaml.

" arch/arm/boot/dts/imx6dl-nitrogen6x.dt.yaml: 
ethernet@2188000: More than one condition true in oneOf schema: "

But this is not introduced by my patch, it already there even drop my
patch.

I not see other issues.

Thanks,
Peng.

> 
> Best Regards,
> Joakim Zhang
> > -----Original Message-----
> > From: Peng Fan (OSS) <peng.fan@oss.nxp.com>
> > Sent: 2021年11月20日 19:58
> > To: robh+dt@kernel.org; Aisheng Dong <aisheng.dong@nxp.com>; Joakim
> > Zhang <qiangqing.zhang@nxp.com>; davem@davemloft.net;
> kuba@kernel.org;
> > shawnguo@kernel.org; s.hauer@pengutronix.de
> > Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> > <linux-imx@nxp.com>; netdev@vger.kernel.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > linux-arm-kernel@lists.infradead.org; Peng Fan <peng.fan@nxp.com>
> > Subject: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > i.MX7D, i.MX8MQ and i.MX8QM are compatible with i.MX6SX, so no need
> to
> > split them into three items.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/net/fsl,fec.yaml | 8 ++------
> >  1 file changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > index eca41443fcce..dbf63a9c2a46 100644
> > --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > @@ -39,9 +39,8 @@ properties:
> >        - items:
> >            - enum:
> >                - fsl,imx7d-fec
> > -          - const: fsl,imx6sx-fec
> > -      - items:
> > -          - const: fsl,imx8mq-fec
> > +              - fsl,imx8mq-fec
> > +              - fsl,imx8qm-fec
> >            - const: fsl,imx6sx-fec
> >        - items:
> >            - enum:
> > @@ -50,9 +49,6 @@ properties:
> >                - fsl,imx8mp-fec
> >            - const: fsl,imx8mq-fec
> >            - const: fsl,imx6sx-fec
> > -      - items:
> > -          - const: fsl,imx8qm-fec
> > -          - const: fsl,imx6sx-fec
> >        - items:
> >            - enum:
> >                - fsl,imx8qxp-fec
> > --
> > 2.25.1


  reply	other threads:[~2021-11-23  9:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-20 11:58 [PATCH 0/4] dt-bindings/dts: add i.MX8ULP FEC Peng Fan (OSS)
2021-11-20 11:58 ` [PATCH 1/4] dt-bindings: net: fec: simplify yaml Peng Fan (OSS)
2021-11-22  2:07   ` Joakim Zhang
2021-11-23  9:29     ` Peng Fan [this message]
2021-11-23 10:39       ` Joakim Zhang
2021-11-30  2:03   ` Rob Herring
2021-11-20 11:58 ` [PATCH 2/4] dt-bindings: net: fec: Add imx8ulp compatible string Peng Fan (OSS)
2021-11-30  2:04   ` Rob Herring
2021-11-20 11:58 ` [PATCH 3/4] arm64: dts: imx8ulp: add fec node Peng Fan (OSS)
2021-11-22  2:07   ` Joakim Zhang
2021-11-20 11:58 ` [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec Peng Fan (OSS)
2021-11-20 15:26   ` Andrew Lunn
2021-11-22  1:04     ` Peng Fan
2021-11-22  2:08       ` Joakim Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DU0PR04MB9417842B67DE3FC3C28B120788609@DU0PR04MB9417.eurprd04.prod.outlook.com \
    --to=peng.fan@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peng.fan@oss.nxp.com \
    --cc=qiangqing.zhang@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).