* [PATCH] arm64: dts: imx8mp: remove fallback compatible string for FlexCAN
@ 2021-07-15 11:49 Joakim Zhang
2021-07-15 12:03 ` Fabio Estevam
0 siblings, 1 reply; 7+ messages in thread
From: Joakim Zhang @ 2021-07-15 11:49 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, mkl
Cc: kernel, festevam, linux-imx, devicetree, aisheng.dong
FlexCAN on i.MX8MP is not derived from i.MX6Q, instead resues from
i.MX8QM with extra ECC added. With "fsl,imx6q-flexcan" compatible string,
i.MX8MP FlexCAN would not work, so remove this fallback compatible string.
Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 9f7c7f587d38..1bfb359dba4a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -579,7 +579,7 @@
};
flexcan1: can@308c0000 {
- compatible = "fsl,imx8mp-flexcan", "fsl,imx6q-flexcan";
+ compatible = "fsl,imx8mp-flexcan";
reg = <0x308c0000 0x10000>;
interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
@@ -594,7 +594,7 @@
};
flexcan2: can@308d0000 {
- compatible = "fsl,imx8mp-flexcan", "fsl,imx6q-flexcan";
+ compatible = "fsl,imx8mp-flexcan";
reg = <0x308d0000 0x10000>;
interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: imx8mp: remove fallback compatible string for FlexCAN
2021-07-15 11:49 [PATCH] arm64: dts: imx8mp: remove fallback compatible string for FlexCAN Joakim Zhang
@ 2021-07-15 12:03 ` Fabio Estevam
2021-07-15 12:15 ` Marc Kleine-Budde
0 siblings, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2021-07-15 12:03 UTC (permalink / raw)
To: Joakim Zhang
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Marc Kleine-Budde,
Sascha Hauer, NXP Linux Team,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Dong Aisheng
Hi Joakim,
On Thu, Jul 15, 2021 at 8:49 AM Joakim Zhang <qiangqing.zhang@nxp.com> wrote:
>
> FlexCAN on i.MX8MP is not derived from i.MX6Q, instead resues from
> i.MX8QM with extra ECC added. With "fsl,imx6q-flexcan" compatible string,
> i.MX8MP FlexCAN would not work, so remove this fallback compatible string.
I agree with the removal of "fsl,imx6q-flexcan", but I don't
understand your comment
saying that:
"With "fsl,imx6q-flexcan" compatible string, i.MX8MP FlexCAN would not work"
Why?
"fsl,imx8mp-flexcan" is passed as the more specific compatible string
and it should
match against it first.
Please clarify.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp: remove fallback compatible string for FlexCAN
2021-07-15 12:03 ` Fabio Estevam
@ 2021-07-15 12:15 ` Marc Kleine-Budde
2021-07-15 12:40 ` Fabio Estevam
2021-07-16 2:03 ` Joakim Zhang
0 siblings, 2 replies; 7+ messages in thread
From: Marc Kleine-Budde @ 2021-07-15 12:15 UTC (permalink / raw)
To: Fabio Estevam
Cc: Joakim Zhang, Rob Herring, Shawn Guo, Sascha Hauer, Sascha Hauer,
NXP Linux Team,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Dong Aisheng
[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]
On 15.07.2021 09:03:55, Fabio Estevam wrote:
> Hi Joakim,
>
> On Thu, Jul 15, 2021 at 8:49 AM Joakim Zhang <qiangqing.zhang@nxp.com> wrote:
> >
> > FlexCAN on i.MX8MP is not derived from i.MX6Q, instead resues from
> > i.MX8QM with extra ECC added. With "fsl,imx6q-flexcan" compatible string,
> > i.MX8MP FlexCAN would not work, so remove this fallback compatible string.
>
> I agree with the removal of "fsl,imx6q-flexcan", but I don't
> understand your comment
> saying that:
>
> "With "fsl,imx6q-flexcan" compatible string, i.MX8MP FlexCAN would not work"
>
> Why?
Don't remember exactly why It doesn't work. I think it was a missing
quirk that the imx6 doesn't need.
> "fsl,imx8mp-flexcan" is passed as the more specific compatible string
> and it should match against it first.
ACK - but why specify the imx6 in the compatible list if the flexcan IP
core isn't compatible with the one of the imx6?
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp: remove fallback compatible string for FlexCAN
2021-07-15 12:15 ` Marc Kleine-Budde
@ 2021-07-15 12:40 ` Fabio Estevam
2021-07-16 2:05 ` Joakim Zhang
2021-07-16 2:03 ` Joakim Zhang
1 sibling, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2021-07-15 12:40 UTC (permalink / raw)
To: Marc Kleine-Budde
Cc: Joakim Zhang, Rob Herring, Shawn Guo, Sascha Hauer, Sascha Hauer,
NXP Linux Team,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Dong Aisheng
Hi Marc,
On Thu, Jul 15, 2021 at 9:33 AM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> > Why?
>
> Don't remember exactly why It doesn't work. I think it was a missing
> quirk that the imx6 doesn't need.
>
> > "fsl,imx8mp-flexcan" is passed as the more specific compatible string
> > and it should match against it first.
>
> ACK - but why specify the imx6 in the compatible list if the flexcan IP
> core isn't compatible with the one of the imx6?
Correct. The change in this patch looks good.
The commit log needs improvement though.
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] arm64: dts: imx8mp: remove fallback compatible string for FlexCAN
2021-07-15 12:40 ` Fabio Estevam
@ 2021-07-16 2:05 ` Joakim Zhang
0 siblings, 0 replies; 7+ messages in thread
From: Joakim Zhang @ 2021-07-16 2:05 UTC (permalink / raw)
To: Fabio Estevam, Marc Kleine-Budde
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Sascha Hauer, dl-linux-imx,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Aisheng Dong
> -----Original Message-----
> From: Fabio Estevam <festevam@gmail.com>
> Sent: 2021年7月15日 20:40
> To: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: Joakim Zhang <qiangqing.zhang@nxp.com>; Rob Herring
> <robh+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer
> <s.hauer@pengutronix.de>; Sascha Hauer <kernel@pengutronix.de>;
> dl-linux-imx <linux-imx@nxp.com>; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; Aisheng Dong
> <aisheng.dong@nxp.com>
> Subject: Re: [PATCH] arm64: dts: imx8mp: remove fallback compatible string
> for FlexCAN
>
> Hi Marc,
>
> On Thu, Jul 15, 2021 at 9:33 AM Marc Kleine-Budde <mkl@pengutronix.de>
> wrote:
>
> > > Why?
> >
> > Don't remember exactly why It doesn't work. I think it was a missing
> > quirk that the imx6 doesn't need.
> >
> > > "fsl,imx8mp-flexcan" is passed as the more specific compatible
> > > string and it should match against it first.
> >
> > ACK - but why specify the imx6 in the compatible list if the flexcan
> > IP core isn't compatible with the one of the imx6?
>
> Correct. The change in this patch looks good.
>
> The commit log needs improvement though.
Ok, I will improve the commit message and then resend the patch.
Best Regards,
Joakim Zhang
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] arm64: dts: imx8mp: remove fallback compatible string for FlexCAN
2021-07-15 12:15 ` Marc Kleine-Budde
2021-07-15 12:40 ` Fabio Estevam
@ 2021-07-16 2:03 ` Joakim Zhang
2021-07-16 7:03 ` Marc Kleine-Budde
1 sibling, 1 reply; 7+ messages in thread
From: Joakim Zhang @ 2021-07-16 2:03 UTC (permalink / raw)
To: Marc Kleine-Budde, Fabio Estevam
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Sascha Hauer, dl-linux-imx,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Aisheng Dong
Hi Mac, Fabio,
> -----Original Message-----
> From: Marc Kleine-Budde <mkl@pengutronix.de>
> Sent: 2021年7月15日 20:15
> To: Fabio Estevam <festevam@gmail.com>
> Cc: Joakim Zhang <qiangqing.zhang@nxp.com>; Rob Herring
> <robh+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer
> <s.hauer@pengutronix.de>; Sascha Hauer <kernel@pengutronix.de>;
> dl-linux-imx <linux-imx@nxp.com>; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; Aisheng Dong
> <aisheng.dong@nxp.com>
> Subject: Re: [PATCH] arm64: dts: imx8mp: remove fallback compatible string
> for FlexCAN
>
> On 15.07.2021 09:03:55, Fabio Estevam wrote:
> > Hi Joakim,
> >
> > On Thu, Jul 15, 2021 at 8:49 AM Joakim Zhang <qiangqing.zhang@nxp.com>
> wrote:
> > >
> > > FlexCAN on i.MX8MP is not derived from i.MX6Q, instead resues from
> > > i.MX8QM with extra ECC added. With "fsl,imx6q-flexcan" compatible
> > > string, i.MX8MP FlexCAN would not work, so remove this fallback
> compatible string.
> >
> > I agree with the removal of "fsl,imx6q-flexcan", but I don't
> > understand your comment saying that:
> >
> > "With "fsl,imx6q-flexcan" compatible string, i.MX8MP FlexCAN would not
> work"
> >
> > Why?
>
> Don't remember exactly why It doesn't work. I think it was a missing quirk that
> the imx6 doesn't need.
I could explain more if I remember correctly, i.MX8MP with ECC added and default is enabled, without FLEXCAN_QUIRK_DISABLE_MECR quirk,
FlexCAN doesn't work, it will put device in freeze mode. However, as Mac described, i.MX6Q doesn't need it.
> > "fsl,imx8mp-flexcan" is passed as the more specific compatible string
> > and it should match against it first.
>
> ACK - but why specify the imx6 in the compatible list if the flexcan IP core isn't
> compatible with the one of the imx6?
Best Regards,
Joakim Zhang
> regards,
> Marc
>
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Embedded Linux | https://www.pengutronix.de |
> Vertretung West/Dortmund | Phone: +49-231-2826-924 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp: remove fallback compatible string for FlexCAN
2021-07-16 2:03 ` Joakim Zhang
@ 2021-07-16 7:03 ` Marc Kleine-Budde
0 siblings, 0 replies; 7+ messages in thread
From: Marc Kleine-Budde @ 2021-07-16 7:03 UTC (permalink / raw)
To: Joakim Zhang
Cc: Fabio Estevam, Rob Herring, Shawn Guo, Sascha Hauer,
Sascha Hauer, dl-linux-imx,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Aisheng Dong
[-- Attachment #1: Type: text/plain, Size: 796 bytes --]
On 16.07.2021 02:03:44, Joakim Zhang wrote:
>>> "With "fsl,imx6q-flexcan" compatible string, i.MX8MP FlexCAN would
>>> not work"
>>
>> Why?
> I could explain more if I remember correctly, i.MX8MP with ECC added
> and default is enabled, without FLEXCAN_QUIRK_DISABLE_MECR quirk,
> FlexCAN doesn't work, it will put device in freeze mode. However, as
> Mac described, i.MX6Q doesn't need it.
The bits that are used in the FLEXCAN_QUIRK_DISABLE_MECR are marked as
reserved on the imx6's flexcan IP core.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-07-16 7:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-15 11:49 [PATCH] arm64: dts: imx8mp: remove fallback compatible string for FlexCAN Joakim Zhang
2021-07-15 12:03 ` Fabio Estevam
2021-07-15 12:15 ` Marc Kleine-Budde
2021-07-15 12:40 ` Fabio Estevam
2021-07-16 2:05 ` Joakim Zhang
2021-07-16 2:03 ` Joakim Zhang
2021-07-16 7:03 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).