Linux-Devicetree Archive on lore.kernel.org
 help / color / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/7] dt-bindings: media: max9286: Re-indent example
Date: Thu, 15 Apr 2021 17:42:29 +0300
Message-ID: <YHhQ1fIicHoDKB0L@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210415122602.87697-2-jacopo+renesas@jmondi.org>

Hi Jacopo,

Thank you for the patch.

On Thu, Apr 15, 2021 at 02:25:56PM +0200, Jacopo Mondi wrote:
> The dt-bindings examples are usually indented with 4 spaces.
> 
> The maxim,max9286 schema has the example indented with only
> 2 spaces, re-indent it.
> 
> Cosmetic change only.
> 
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Tested by applying and verifying that `git show -b` shows an empty diff.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  .../bindings/media/i2c/maxim,max9286.yaml     | 214 +++++++++---------
>  1 file changed, 107 insertions(+), 107 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> index ee16102fdfe7..0e7162998b77 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> @@ -191,140 +191,140 @@ examples:
>      #include <dt-bindings/gpio/gpio.h>
>  
>      i2c@e66d8000 {
> -      #address-cells = <1>;
> -      #size-cells = <0>;
> +        #address-cells = <1>;
> +        #size-cells = <0>;
>  
> -      reg = <0 0xe66d8000>;
> +        reg = <0 0xe66d8000>;
>  
> -      gmsl-deserializer@2c {
> -        compatible = "maxim,max9286";
> -        reg = <0x2c>;
> -        poc-supply = <&camera_poc_12v>;
> -        enable-gpios = <&gpio 13 GPIO_ACTIVE_HIGH>;
> +        gmsl-deserializer@2c {
> +            compatible = "maxim,max9286";
> +            reg = <0x2c>;
> +            poc-supply = <&camera_poc_12v>;
> +            enable-gpios = <&gpio 13 GPIO_ACTIVE_HIGH>;
>  
> -        gpio-controller;
> -        #gpio-cells = <2>;
> +            gpio-controller;
> +            #gpio-cells = <2>;
>  
> -        maxim,reverse-channel-microvolt = <170000>;
> +            maxim,reverse-channel-microvolt = <170000>;
>  
> -        ports {
> -          #address-cells = <1>;
> -          #size-cells = <0>;
> +            ports {
> +                #address-cells = <1>;
> +                #size-cells = <0>;
>  
> -          port@0 {
> -            reg = <0>;
> +                port@0 {
> +                    reg = <0>;
>  
> -            max9286_in0: endpoint {
> -              remote-endpoint = <&rdacm20_out0>;
> -            };
> -          };
> -
> -          port@1 {
> -            reg = <1>;
> -
> -            max9286_in1: endpoint {
> -              remote-endpoint = <&rdacm20_out1>;
> -            };
> -          };
> -
> -          port@2 {
> -            reg = <2>;
> -
> -            max9286_in2: endpoint {
> -              remote-endpoint = <&rdacm20_out2>;
> -            };
> -          };
> +                    max9286_in0: endpoint {
> +                        remote-endpoint = <&rdacm20_out0>;
> +                    };
> +                };
>  
> -          port@3 {
> -            reg = <3>;
> +                port@1 {
> +                    reg = <1>;
>  
> -            max9286_in3: endpoint {
> -              remote-endpoint = <&rdacm20_out3>;
> -            };
> -          };
> +                    max9286_in1: endpoint {
> +                        remote-endpoint = <&rdacm20_out1>;
> +                    };
> +                };
>  
> -          port@4 {
> -            reg = <4>;
> +                port@2 {
> +                    reg = <2>;
>  
> -            max9286_out: endpoint {
> -              data-lanes = <1 2 3 4>;
> -              remote-endpoint = <&csi40_in>;
> -            };
> -          };
> -        };
> +                    max9286_in2: endpoint {
> +                        remote-endpoint = <&rdacm20_out2>;
> +                    };
> +                };
>  
> -        i2c-mux {
> -          #address-cells = <1>;
> -          #size-cells = <0>;
> +                port@3 {
> +                    reg = <3>;
>  
> -          i2c@0 {
> -            #address-cells = <1>;
> -            #size-cells = <0>;
> -            reg = <0>;
> +                    max9286_in3: endpoint {
> +                        remote-endpoint = <&rdacm20_out3>;
> +                    };
> +                };
>  
> -            camera@51 {
> -              compatible = "imi,rdacm20";
> -              reg = <0x51>, <0x61>;
> +                port@4 {
> +                    reg = <4>;
>  
> -              port {
> -                rdacm20_out0: endpoint {
> -                  remote-endpoint = <&max9286_in0>;
> +                    max9286_out: endpoint {
> +                        data-lanes = <1 2 3 4>;
> +                        remote-endpoint = <&csi40_in>;
> +                    };
>                  };
> -              };
> -
>              };
> -          };
> -
> -          i2c@1 {
> -            #address-cells = <1>;
> -            #size-cells = <0>;
> -            reg = <1>;
>  
> -            camera@52 {
> -              compatible = "imi,rdacm20";
> -              reg = <0x52>, <0x62>;
> +            i2c-mux {
> +                #address-cells = <1>;
> +                #size-cells = <0>;
>  
> -              port {
> -                rdacm20_out1: endpoint {
> -                  remote-endpoint = <&max9286_in1>;
> -                };
> -              };
> -            };
> -          };
> +                i2c@0 {
> +                    #address-cells = <1>;
> +                    #size-cells = <0>;
> +                    reg = <0>;
>  
> -          i2c@2 {
> -            #address-cells = <1>;
> -            #size-cells = <0>;
> -            reg = <2>;
> +                    camera@51 {
> +                        compatible = "imi,rdacm20";
> +                        reg = <0x51>, <0x61>;
>  
> -            camera@53 {
> -              compatible = "imi,rdacm20";
> -              reg = <0x53>, <0x63>;
> +                        port {
> +                            rdacm20_out0: endpoint {
> +                                remote-endpoint = <&max9286_in0>;
> +                            };
> +                        };
>  
> -              port {
> -                rdacm20_out2: endpoint {
> -                  remote-endpoint = <&max9286_in2>;
> +                    };
>                  };
> -              };
> -            };
> -          };
>  
> -          i2c@3 {
> -            #address-cells = <1>;
> -            #size-cells = <0>;
> -            reg = <3>;
> +                i2c@1 {
> +                    #address-cells = <1>;
> +                    #size-cells = <0>;
> +                    reg = <1>;
> +
> +                    camera@52 {
> +                        compatible = "imi,rdacm20";
> +                        reg = <0x52>, <0x62>;
> +
> +                        port {
> +                            rdacm20_out1: endpoint {
> +                                remote-endpoint = <&max9286_in1>;
> +                            };
> +                        };
> +                    };
> +                };
>  
> -            camera@54 {
> -              compatible = "imi,rdacm20";
> -              reg = <0x54>, <0x64>;
> +                i2c@2 {
> +                    #address-cells = <1>;
> +                    #size-cells = <0>;
> +                    reg = <2>;
> +
> +                    camera@53 {
> +                        compatible = "imi,rdacm20";
> +                        reg = <0x53>, <0x63>;
> +
> +                        port {
> +                            rdacm20_out2: endpoint {
> +                                remote-endpoint = <&max9286_in2>;
> +                            };
> +                        };
> +                    };
> +                };
>  
> -              port {
> -                rdacm20_out3: endpoint {
> -                  remote-endpoint = <&max9286_in3>;
> +                i2c@3 {
> +                    #address-cells = <1>;
> +                    #size-cells = <0>;
> +                    reg = <3>;
> +
> +                    camera@54 {
> +                        compatible = "imi,rdacm20";
> +                        reg = <0x54>, <0x64>;
> +
> +                        port {
> +                            rdacm20_out3: endpoint {
> +                                remote-endpoint = <&max9286_in3>;
> +                            };
> +                        };
> +                    };
>                  };
> -              };
>              };
> -          };
>          };
> -      };
>      };

-- 
Regards,

Laurent Pinchart

  reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 12:25 [PATCH v4 0/7] arm64: dts: renesas: Enable GMSL on R8A77970 V3M Eagle Jacopo Mondi
2021-04-15 12:25 ` [PATCH v4 1/7] dt-bindings: media: max9286: Re-indent example Jacopo Mondi
2021-04-15 14:42   ` Laurent Pinchart [this message]
2021-04-15 16:40   ` Rob Herring
2021-04-15 12:25 ` [PATCH v4 2/7] dt-bindings: media: max9286: Define 'maxim,gpio-poc' Jacopo Mondi
2021-04-15 16:53   ` Rob Herring
2021-04-15 12:25 ` [PATCH v4 3/7] media: i2c: max9286: Use "maxim,gpio-poc" property Jacopo Mondi
2021-04-15 19:19   ` Laurent Pinchart
2021-04-18 15:01     ` Jacopo Mondi
2021-04-15 12:25 ` [PATCH v4 4/7] arm64: dts: renesas: r8a77970: Add csi40 port@0 Jacopo Mondi
2021-04-15 14:47   ` Laurent Pinchart
2021-04-15 16:47     ` Geert Uytterhoeven
2021-04-15 19:09       ` Laurent Pinchart
2021-04-15 12:26 ` [PATCH v4 5/7] arm64: dts: renesas: eagle: Enable MAX9286 Jacopo Mondi
2021-04-15 12:26 ` [PATCH v4 6/7] arm64: dts: renesas: eagle: Add GMSL .dtsi Jacopo Mondi
2021-04-15 12:26 ` [PATCH v4 7/7] DNI: arm64: dts: renesas: eagle: Include eagle-gmsl Jacopo Mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHhQ1fIicHoDKB0L@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=jacopo+renesas@jmondi.org \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Devicetree Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-devicetree/0 linux-devicetree/git/0.git
	git clone --mirror https://lore.kernel.org/linux-devicetree/1 linux-devicetree/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-devicetree linux-devicetree/ https://lore.kernel.org/linux-devicetree \
		devicetree@vger.kernel.org
	public-inbox-index linux-devicetree

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-devicetree


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git