devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
To: Adam Ford <aford173-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>,
	linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Michael Turquette
	<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Kevin Hilman <khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks
Date: Thu, 11 Jan 2018 14:04:43 -0600	[thread overview]
Message-ID: <a79184c5-3e28-bbac-0783-992615d49fae@lechnology.com> (raw)
In-Reply-To: <CAHCN7x+G5pxOeD7TahqiQUePEu1Z4Hyinkjq_bcSM+Hz36xoSg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 01/11/2018 12:50 PM, Adam Ford wrote:
> On Thu, Jan 11, 2018 at 12:29 PM, David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org> wrote:
>> If removing the "clk_ignore_unused" option causes the board to not boot,
>> then we still have problems that need to be fixed, so please also test
>> without this option.
> 
> Without this option, it still does not boot.  Without device tree it
> hangs after:
> 
> [snip]
> 
> NET: Registered protocol family 17
> Loading compiled-in X.509 certificates
> console [netcon0] enabled
> netconsole: network logging started
> davinci_emac davinci_emac.1: using random MAC addr: 5e:38:1a:1f:4f:77
> mmc0: host does not support reading read-only switch, assuming write-enable
> hctosys: unable to open rtc device (rtc0)
> mmc0: new high speed SDHC card at address b368
> 
> 
> With device tree it hangs after:
> 
> [snip]
> mmc0: host does not support reading read-only switch, assuming write-enable
> mmc0: new high speed SDHC card at address b368
> mmcblk0: mmc0:b368 00000 3.75 GiB
>   mmcblk0: p1 p2
> pca953x 0-0020: 0-0020 supply vcc not found, using dummy regulator
> pca953x 0-0020: failed reading register
> pca953x: probe of 0-0020 failed with error -121
> console [netcon0] enabled
> netconsole: network logging started
> davinci_emac 1e20000.ethernet: incompatible machine/device type for
> reading mac address
> hctosys: unable to open rtc device (rtc0)
> 
> 

Please try this change:

diff --git a/drivers/clk/davinci/psc-da850.c b/drivers/clk/davinci/psc-da850.c
index 3fd6b49..a526cc2 100644
--- a/drivers/clk/davinci/psc-da850.c
+++ b/drivers/clk/davinci/psc-da850.c
@@ -17,7 +17,7 @@ static const struct davinci_psc_clk_info da850_psc0_info[] __initconst = {
  	LPSC(0, 0, tpcc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED),
  	LPSC(1, 0, tptc0, pll0_sysclk2, LPSC_ALWAYS_ENABLED),
  	LPSC(2, 0, tptc1, pll0_sysclk2, LPSC_ALWAYS_ENABLED),
-	LPSC(3, 0, aemif, pll0_sysclk3, 0),
+	LPSC(3, 0, aemif, pll0_sysclk3, LPSC_ALWAYS_ENABLED),
  	LPSC(4, 0, spi0, pll0_sysclk2, 0),
  	LPSC(5, 0, mmcsd0, pll0_sysclk2, 0),
  	LPSC(6, 0, aintc, pll0_sysclk4, LPSC_ALWAYS_ENABLED),



If that does not work, try adding LPSC_ALWAYS_ENABLED to all of the clocks
in this file and then eliminate them one by one until you find which one is
preventing boot.

If it still does not boot, there is a similar DIVCLK_ALWAYS_ENABLED flag in
drivers/clk/davinci/pll-da850.c that you can repeat the exercise with. Add
DIVCLK_ALWAYS_ENABLED to all of the clocks there and then eliminate it one
by one until you find the clock that is causing the problem.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-01-11 20:04 UTC|newest]

Thread overview: 121+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-08  2:16 [PATCH v5 00/44] ARM: davinci: convert to common clock framework​ David Lechner
2018-01-08  2:17 ` [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks David Lechner
     [not found]   ` <1515377863-20358-2-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2018-01-08 14:00     ` Sekhar Nori
2018-01-08 16:29       ` David Lechner
2018-01-09 12:35         ` Sekhar Nori
     [not found]           ` <0f90b5f7-f21e-5f81-1154-9a815bbb786d-l0cyMroinI0@public.gmane.org>
2018-01-10  3:01             ` David Lechner
2018-01-10 18:52               ` Sekhar Nori
2018-01-10 22:24                 ` Adam Ford
     [not found]                   ` <CAHCN7x+ZYezmEU_0mF=6_gF14DZxKnuDp1Cx=aC2=eN_QLNdJQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-11  2:50                     ` David Lechner
2018-01-11 12:45                       ` Adam Ford
2018-01-11 15:47                         ` Sekhar Nori
     [not found]                           ` <14320e05-c6f7-fa2d-35cd-c01414c59f2f-l0cyMroinI0@public.gmane.org>
2018-01-11 16:14                             ` Adam Ford
2018-01-11 17:22                         ` David Lechner
2018-01-11 18:09                           ` Adam Ford
2018-01-11 18:29                             ` David Lechner
2018-01-11 18:50                               ` Adam Ford
     [not found]                                 ` <CAHCN7x+G5pxOeD7TahqiQUePEu1Z4Hyinkjq_bcSM+Hz36xoSg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-11 20:04                                   ` David Lechner [this message]
2018-01-11 20:58                                     ` Adam Ford
     [not found]                                       ` <CAHCN7x+EtQs6NHAYbVga7vU1U+qQLqOxdf+1MW6HewaT+ZF_Xg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-11 21:04                                         ` David Lechner
     [not found]                                           ` <5832fd62-16aa-e167-7e52-2ce493e33cdc-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2018-01-11 21:34                                             ` Adam Ford
2018-01-11 21:46                                               ` David Lechner
     [not found]                                                 ` <c1e27013-cbad-3b09-0e0d-f68d75162c1f-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2018-01-12  6:03                                                   ` Sekhar Nori
2018-01-16 11:22                                               ` Sekhar Nori
2018-01-16 12:21                                                 ` Adam Ford
2018-01-16 16:41                                                   ` David Lechner
2018-01-11 23:20                             ` David Lechner
2018-01-11  2:54                 ` David Lechner
2018-01-08  2:17 ` [PATCH v5 02/44] clk: davinci: New driver for davinci " David Lechner
2018-01-12  9:21   ` Sekhar Nori
2018-01-12 15:25     ` David Lechner
     [not found]       ` <01fbde0e-36a0-2b19-e385-e63bc4a3ae4a-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2018-01-12 15:30         ` Adam Ford
     [not found]           ` <CAHCN7xK44_zv27xe5yxL8Efey=VC-nypK6hY6VWqsoLqnKe04g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-12 15:48             ` David Lechner
2018-01-12 16:18       ` Sekhar Nori
     [not found]         ` <eb2b1a63-9c7c-aeca-170f-d38642442438-l0cyMroinI0@public.gmane.org>
2018-01-13  1:11           ` David Lechner
2018-01-16  6:48             ` Sekhar Nori
2018-01-13  2:13     ` David Lechner
2018-01-16  6:32       ` Sekhar Nori
2018-01-08  2:17 ` [PATCH v5 03/44] clk: davinci: Add platform information for TI DA830 PLL David Lechner
     [not found]   ` <1515377863-20358-4-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2018-01-12  9:41     ` Sekhar Nori
2018-01-08  2:17 ` [PATCH v5 04/44] clk: davinci: Add platform information for TI DA850 PLL David Lechner
2018-01-16  8:37   ` Sekhar Nori
2018-01-08  2:17 ` [PATCH v5 05/44] clk: davinci: Add platform information for TI DM355 PLL David Lechner
2018-01-16  8:38   ` Sekhar Nori
2018-01-08  2:17 ` [PATCH v5 06/44] clk: davinci: Add platform information for TI DM365 PLL David Lechner
     [not found]   ` <1515377863-20358-7-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2018-01-16  8:48     ` Sekhar Nori
2018-01-08  2:17 ` [PATCH v5 07/44] clk: davinci: Add platform information for TI DM644x PLL David Lechner
     [not found]   ` <1515377863-20358-8-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2018-01-16  8:56     ` Sekhar Nori
2018-01-08  2:17 ` [PATCH v5 08/44] clk: davinci: Add platform information for TI DM646x PLL David Lechner
2018-01-16  9:01   ` Sekhar Nori
2018-01-08  2:17 ` [PATCH v5 09/44] dt-bindings: clock: New bindings for TI Davinci PSC David Lechner
     [not found]   ` <1515377863-20358-10-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2018-01-11 21:22     ` Rob Herring
2018-01-08  2:17 ` [PATCH v5 10/44] clk: davinci: New driver for davinci PSC clocks David Lechner
2018-01-16 11:03   ` Sekhar Nori
2018-01-16 16:51     ` David Lechner
     [not found]       ` <83f3d207-9645-cbdf-d6cf-b6e6a8458abe-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2018-01-17 12:25         ` Sekhar Nori
2018-01-17 17:28           ` David Lechner
2018-01-08  2:17 ` [PATCH v5 11/44] clk: davinci: Add platform information for TI DA830 PSC David Lechner
     [not found]   ` <1515377863-20358-12-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2018-01-16 13:38     ` Sekhar Nori
     [not found]       ` <91fe16dc-907e-6dbb-c8db-c27561132093-l0cyMroinI0@public.gmane.org>
2018-01-16 17:16         ` David Lechner
     [not found]           ` <4dd36ca7-e41d-58d8-ec8c-787978307943-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2018-01-17 12:18             ` Sekhar Nori
     [not found]               ` <86581de6-a982-7a7b-9a83-22c869417211-l0cyMroinI0@public.gmane.org>
2018-01-17 17:32                 ` David Lechner
2018-01-18  7:53                   ` Sekhar Nori
     [not found] ` <1515377863-20358-1-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2018-01-08  2:17   ` [PATCH v5 12/44] clk: davinci: Add platform information for TI DA850 PSC David Lechner
     [not found]     ` <1515377863-20358-13-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2018-01-16 14:00       ` Sekhar Nori
2018-01-16 17:21         ` David Lechner
2018-01-17 11:57           ` Sekhar Nori
2018-01-17 17:33             ` David Lechner
2018-01-17 19:08             ` David Lechner
2018-01-18  6:37               ` Sekhar Nori
2018-02-09 16:22     ` Bartosz Golaszewski
2018-02-09 16:48       ` Michael Turquette
2018-02-12  3:03         ` David Lechner
2018-04-05 13:09         ` Sekhar Nori
2018-04-05 13:44           ` Bartosz Golaszewski
2018-04-05 14:36             ` Sekhar Nori
2018-04-05 15:37               ` David Lechner
2018-04-05 15:51               ` Bartosz Golaszewski
2018-04-06  9:37                 ` Sekhar Nori
2018-04-06 16:46                   ` Stephen Boyd
2018-04-23 14:59                     ` David Lechner
2018-04-24  8:28                       ` Sekhar Nori
2018-04-24 16:11                         ` David Lechner
2018-04-25  6:07                           ` Sekhar Nori
2018-04-25 10:09                             ` Bartosz Golaszewski
2018-04-25 10:26                               ` Bartosz Golaszewski
2018-01-08  2:17   ` [PATCH v5 13/44] clk: davinci: Add platform information for TI DM355 PSC David Lechner
     [not found]     ` <1515377863-20358-14-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2018-01-16 14:15       ` Sekhar Nori
2018-01-08  2:17 ` [PATCH v5 14/44] clk: davinci: Add platform information for TI DM365 PSC David Lechner
2018-01-16 14:16   ` Sekhar Nori
2018-01-08  2:17 ` [PATCH v5 15/44] clk: davinci: Add platform information for TI DM644x PSC David Lechner
2018-01-17 13:57   ` Sekhar Nori
2018-01-08  2:17 ` [PATCH v5 16/44] clk: davinci: Add platform information for TI DM646x PSC David Lechner
2018-01-17 14:59   ` Sekhar Nori
2018-01-08  2:17 ` [PATCH v5 17/44] dt-bindings: clock: Add bindings for DA8XX CFGCHIP gate clocks David Lechner
     [not found]   ` <1515377863-20358-18-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2018-01-11 21:45     ` Rob Herring
2018-01-11 21:51       ` David Lechner
2018-01-08  2:17 ` [PATCH v5 18/44] dt-bindings: clock: Add binding for TI DA8XX CFGCHIP mux clocks David Lechner
2018-01-08  2:17 ` [PATCH v5 19/44] clk: davinci: New driver for TI DA8XX CFGCHIP clocks David Lechner
2018-01-17 15:31   ` Sekhar Nori
2018-01-17 17:35     ` David Lechner
2018-01-08  2:17 ` [PATCH v5 20/44] dt-bindings: clock: Add bindings for TI DA8XX USB PHY clocks David Lechner
2018-01-18 12:10   ` Sekhar Nori
     [not found]     ` <33f0feba-adee-e365-54d5-16fe3d49302d-l0cyMroinI0@public.gmane.org>
2018-01-18 19:00       ` David Lechner
2018-01-19  6:17         ` Sekhar Nori
2018-01-08  2:17 ` [PATCH v5 21/44] clk: davinci: New driver " David Lechner
2018-01-18 13:05   ` Sekhar Nori
     [not found]     ` <493e4809-6b77-7772-70c7-ad0fa04e9033-l0cyMroinI0@public.gmane.org>
2018-01-18 18:49       ` David Lechner
2018-01-19  5:04         ` Sekhar Nori
2018-01-08  2:17 ` [PATCH v5 22/44] ARM: davinci: move davinci_clk_init() to init_time David Lechner
2018-01-08  2:17 ` [PATCH v5 23/44] ARM: da830: add new clock init using common clock framework David Lechner
2018-01-08  2:17 ` [PATCH v5 24/44] ARM: da850: " David Lechner
     [not found]   ` <1515377863-20358-25-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2018-01-18 15:24     ` Sekhar Nori
2018-01-08  2:17 ` [PATCH v5 25/44] ARM: dm355: " David Lechner
2018-01-08  2:17 ` [PATCH v5 26/44] ARM: dm365: " David Lechner
2018-01-08  2:17 ` [PATCH v5 27/44] ARM: dm644x: " David Lechner
2018-01-08  2:17 ` [PATCH v5 28/44] ARM: dm646x: " David Lechner
2018-01-08  2:17 ` [PATCH v5 29/44] ARM: da8xx: add new USB PHY " David Lechner
2018-01-18 15:14   ` Sekhar Nori
     [not found]     ` <83dfab9a-be30-6313-d756-50fa018e757e-l0cyMroinI0@public.gmane.org>
2018-01-18 18:43       ` David Lechner
2018-01-19  5:08         ` Sekhar Nori
2018-01-08  2:17 ` [PATCH v5 35/44] ARM: da850: Remove legacy clock init David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a79184c5-3e28-bbac-0783-992615d49fae@lechnology.com \
    --to=david-nq/r/kbu++upp/zk7jdf2g@public.gmane.org \
    --cc=aford173-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=nsekhar-l0cyMroinI0@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).