From: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
henryc.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: chen.zhong-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
chenglin.xu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 6/9] soc: mediatek: pwrap: update pwrap_init without slave programming
Date: Tue, 10 Oct 2017 11:53:01 +0200 [thread overview]
Message-ID: <a90b5197-962b-a583-bed2-5ef39f5fca45@gmail.com> (raw)
In-Reply-To: <23b1e9fa5d4d8932b36e08d2a6713d4f33c055d9.1502779753.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
On 08/15/2017 11:09 AM, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote:
> From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>
> pwrap initialization is highly associated with the base SoC, so
> update here for allowing pwrap_init without slave program which would be
> used to those PMICs without extra encryption on bus such as MT6380.
>
> Signed-off-by: Chenglin Xu <chenglin.xu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Chen Zhong <chen.zhong-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 91 +++++++++++++++++++++---------------
> 1 file changed, 54 insertions(+), 37 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 9d1f4c6..1f8b69a 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -531,6 +531,7 @@ struct pmic_wrapper_type {
> u32 spi_w;
> u32 wdt_src;
> int has_bridge:1;
> + int slv_program:1;
From the commit log, it looks like that this depends on the PMIC used and not
on the pmic_wrapper of the SoC. So we should put this into prawp_slv_type.
Regards,
Matthias
> int (*init_reg_clock)(struct pmic_wrapper *wrp);
> int (*init_soc_specific)(struct pmic_wrapper *wrp);
> };
> @@ -999,9 +1000,12 @@ static int pwrap_init(struct pmic_wrapper *wrp)
> }
>
> /* Reset SPI slave */
> - ret = pwrap_reset_spislave(wrp);
> - if (ret)
> - return ret;
> +
> + if (wrp->master->slv_program) {
> + ret = pwrap_reset_spislave(wrp);
> + if (ret)
> + return ret;
> + }
>
> pwrap_writel(wrp, 1, PWRAP_WRAP_EN);
>
> @@ -1013,45 +1017,52 @@ static int pwrap_init(struct pmic_wrapper *wrp)
> if (ret)
> return ret;
>
> - /* Setup serial input delay */
> - ret = pwrap_init_sidly(wrp);
> - if (ret)
> - return ret;
> + if (wrp->master->slv_program) {
> + /* Setup serial input delay */
> + ret = pwrap_init_sidly(wrp);
> + if (ret)
> + return ret;
>
> - /* Enable dual IO mode */
> - pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_DIO_EN], 1);
> + /* Enable dual IO mode */
> + pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_DIO_EN], 1);
>
> - /* Check IDLE & INIT_DONE in advance */
> - ret = pwrap_wait_for_state(wrp, pwrap_is_fsm_idle_and_sync_idle);
> - if (ret) {
> - dev_err(wrp->dev, "%s fail, ret=%d\n", __func__, ret);
> - return ret;
> - }
> + /* Check IDLE & INIT_DONE in advance */
> + ret = pwrap_wait_for_state(wrp,
> + pwrap_is_fsm_idle_and_sync_idle);
> + if (ret) {
> + dev_err(wrp->dev, "%s fail, ret=%d\n", __func__, ret);
> + return ret;
> + }
>
> - pwrap_writel(wrp, 1, PWRAP_DIO_EN);
> + pwrap_writel(wrp, 1, PWRAP_DIO_EN);
>
> - /* Read Test */
> - pwrap_read(wrp, wrp->slave->dew_regs[PWRAP_DEW_READ_TEST], &rdata);
> - if (rdata != PWRAP_DEW_READ_TEST_VAL) {
> - dev_err(wrp->dev, "Read test failed after switch to DIO mode: 0x%04x != 0x%04x\n",
> + /* Read Test */
> + pwrap_read(wrp,
> + wrp->slave->dew_regs[PWRAP_DEW_READ_TEST], &rdata);
> + if (rdata != PWRAP_DEW_READ_TEST_VAL) {
> + dev_err(wrp->dev,
> + "Read failed on DIO mode: 0x%04x!=0x%04x\n",
> PWRAP_DEW_READ_TEST_VAL, rdata);
> - return -EFAULT;
> - }
> -
> - /* Enable encryption */
> - ret = pwrap_init_cipher(wrp);
> - if (ret)
> - return ret;
> + return -EFAULT;
> + }
>
> - /* Signature checking - using CRC */
> - if (pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CRC_EN], 0x1))
> - return -EFAULT;
> + /* Enable encryption */
> + ret = pwrap_init_cipher(wrp);
> + if (ret)
> + return ret;
>
> - pwrap_writel(wrp, 0x1, PWRAP_CRC_EN);
> - pwrap_writel(wrp, 0x0, PWRAP_SIG_MODE);
> - pwrap_writel(wrp, wrp->slave->dew_regs[PWRAP_DEW_CRC_VAL],
> - PWRAP_SIG_ADR);
> - pwrap_writel(wrp, wrp->master->arb_en_all, PWRAP_HIPRIO_ARB_EN);
> + /* Signature checking - using CRC */
> + if (pwrap_write(wrp,
> + wrp->slave->dew_regs[PWRAP_DEW_CRC_EN], 0x1))
> + return -EFAULT;
> +
> + pwrap_writel(wrp, 0x1, PWRAP_CRC_EN);
> + pwrap_writel(wrp, 0x0, PWRAP_SIG_MODE);
> + pwrap_writel(wrp, wrp->slave->dew_regs[PWRAP_DEW_CRC_VAL],
> + PWRAP_SIG_ADR);
> + pwrap_writel(wrp,
> + wrp->master->arb_en_all, PWRAP_HIPRIO_ARB_EN);
> + }
>
> if (wrp->master->type == PWRAP_MT8135)
> pwrap_writel(wrp, 0x7, PWRAP_RRARB_EN);
> @@ -1059,8 +1070,11 @@ static int pwrap_init(struct pmic_wrapper *wrp)
> pwrap_writel(wrp, 0x1, PWRAP_WACS0_EN);
> pwrap_writel(wrp, 0x1, PWRAP_WACS1_EN);
> pwrap_writel(wrp, 0x1, PWRAP_WACS2_EN);
> - pwrap_writel(wrp, 0x5, PWRAP_STAUPD_PRD);
> - pwrap_writel(wrp, 0xff, PWRAP_STAUPD_GRPEN);
> +
> + if (wrp->master->slv_program) {
> + pwrap_writel(wrp, 0x5, PWRAP_STAUPD_PRD);
> + pwrap_writel(wrp, 0xff, PWRAP_STAUPD_GRPEN);
> + }
>
> if (wrp->master->init_soc_specific) {
> ret = wrp->master->init_soc_specific(wrp);
> @@ -1146,6 +1160,7 @@ static const struct pmic_wrapper_type pwrap_mt2701 = {
> .spi_w = PWRAP_MAN_CMD_SPI_WRITE_NEW,
> .wdt_src = PWRAP_WDT_SRC_MASK_ALL,
> .has_bridge = 0,
> + .slv_program = 1,
> .init_reg_clock = pwrap_mt2701_init_reg_clock,
> .init_soc_specific = pwrap_mt2701_init_soc_specific,
> };
> @@ -1158,6 +1173,7 @@ static const struct pmic_wrapper_type pwrap_mt8135 = {
> .spi_w = PWRAP_MAN_CMD_SPI_WRITE,
> .wdt_src = PWRAP_WDT_SRC_MASK_ALL,
> .has_bridge = 1,
> + .slv_program = 1,
> .init_reg_clock = pwrap_mt8135_init_reg_clock,
> .init_soc_specific = pwrap_mt8135_init_soc_specific,
> };
> @@ -1170,6 +1186,7 @@ static const struct pmic_wrapper_type pwrap_mt8173 = {
> .spi_w = PWRAP_MAN_CMD_SPI_WRITE,
> .wdt_src = PWRAP_WDT_SRC_MASK_NO_STAUPD,
> .has_bridge = 0,
> + .slv_program = 1,
> .init_reg_clock = pwrap_mt8173_init_reg_clock,
> .init_soc_specific = pwrap_mt8173_init_soc_specific,
> };
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-10 9:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 9:09 [PATCH v3 0/9] Add PMIC support to MediaTek MT7622 SoC sean.wang-NuS5LvNUpcJWk0Htik3J/w
2017-08-15 9:09 ` [PATCH v3 1/9] dt-bindings: arm: mediatek: add MT7622 string to the PMIC wrapper doc sean.wang
2017-08-15 9:09 ` [PATCH v3 4/9] soc: mediatek: pwrap: add pwrap_read32 for reading in 32-bit mode sean.wang
2017-08-15 9:09 ` [PATCH v3 5/9] soc: mediatek: pwrap: add pwrap_write32 for writing " sean.wang
[not found] ` <236a04acb383fc655549bc345a16a2d015e5727d.1502779753.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-10-10 9:38 ` Matthias Brugger
[not found] ` <d34460e3-9233-3c31-578d-cf2fe91a4316-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-12 3:19 ` Sean Wang
[not found] ` <cover.1502779753.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-08-15 9:09 ` [PATCH v3 2/9] dt-bindings: regulator: Add document for MediaTek MT6380 regulator sean.wang-NuS5LvNUpcJWk0Htik3J/w
2017-08-15 11:50 ` Mark Brown
[not found] ` <20170815115038.65wos2ega2akxet4-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-08-15 15:06 ` Sean Wang
2017-08-15 15:10 ` Mark Brown
2017-08-15 15:10 ` Applied "regulator: Add document for MediaTek MT6380 regulator" to the regulator tree Mark Brown
2017-08-15 9:09 ` [PATCH v3 3/9] regulator: mt6380: Add support for MT6380 sean.wang-NuS5LvNUpcJWk0Htik3J/w
2017-08-15 15:11 ` Applied "regulator: mt6380: Add support for MT6380" to the regulator tree Mark Brown
2017-08-15 9:09 ` [PATCH v3 6/9] soc: mediatek: pwrap: update pwrap_init without slave programming sean.wang-NuS5LvNUpcJWk0Htik3J/w
[not found] ` <23b1e9fa5d4d8932b36e08d2a6713d4f33c055d9.1502779753.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-10-10 9:53 ` Matthias Brugger [this message]
2017-08-15 9:09 ` [PATCH v3 7/9] soc: mediatek: pwrap: add MediaTek MT6380 as one slave of pwrap sean.wang-NuS5LvNUpcJWk0Htik3J/w
[not found] ` <398d87c6ae2b414016fc0c0a9c6bada3ce746118.1502779753.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-10-10 10:02 ` Matthias Brugger
[not found] ` <0491f3fc-0404-c775-70f3-8bc86b3cf6c8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-12 3:44 ` Sean Wang
2017-08-15 9:09 ` [PATCH v3 8/9] soc: mediatek: pwrap: add support for MT7622 SoC sean.wang-NuS5LvNUpcJWk0Htik3J/w
2017-10-10 9:57 ` Matthias Brugger
2017-08-15 9:09 ` [PATCH v3 9/9] soc: mediatek: pwrap: fixup warnings from coding style sean.wang
2017-10-10 10:03 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a90b5197-962b-a583-bed2-5ef39f5fca45@gmail.com \
--to=matthias.bgg-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=chen.zhong-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=chenglin.xu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=henryc.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).