* [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb
@ 2018-02-06 11:08 Bartosz Golaszewski
[not found] ` <20180206110810.9093-1-brgl-ARrdPY/1zhM@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Bartosz Golaszewski @ 2018-02-06 11:08 UTC (permalink / raw)
To: Alexey Brodkin, Rob Herring, Mark Rutland, Vineet Gupta
Cc: devicetree, linux-snps-arc, linux-kernel, Bartosz Golaszewski
Using compatible strings without the <manufacturer> part for at24 is
deprecated since commit 6da28acf745f ("dt-bindings: at24: consistently
document the compatible property"). Use a correct 'atmel,<model>'
value.
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
- explicitly mention the commit in which we deprecated compatible
fallbacks other than "atmel,<manufacturer>"
arch/arc/boot/dts/axs10x_mb.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
index 74d070cd3c13..47b74fbc403c 100644
--- a/arch/arc/boot/dts/axs10x_mb.dtsi
+++ b/arch/arc/boot/dts/axs10x_mb.dtsi
@@ -214,13 +214,13 @@
};
eeprom@0x54{
- compatible = "24c01";
+ compatible = "atmel,24c01";
reg = <0x54>;
pagesize = <0x8>;
};
eeprom@0x57{
- compatible = "24c04";
+ compatible = "atmel,24c04";
reg = <0x57>;
pagesize = <0x8>;
};
--
2.16.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb
[not found] ` <20180206110810.9093-1-brgl-ARrdPY/1zhM@public.gmane.org>
@ 2018-02-06 12:25 ` Alexey Brodkin
2018-02-06 18:01 ` Bartosz Golaszewski
0 siblings, 1 reply; 5+ messages in thread
From: Alexey Brodkin @ 2018-02-06 12:25 UTC (permalink / raw)
To: brgl-ARrdPY/1zhM
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, mark.rutland-5wv7dgnIgG8,
Vineet.Gupta1-HKixBCOQz3hWk0Htik3J/w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Hi Bartosz,
On Tue, 2018-02-06 at 12:08 +0100, Bartosz Golaszewski wrote:
> Using compatible strings without the <manufacturer> part for at24 is
> deprecated since commit 6da28acf745f ("dt-bindings: at24: consistently
> document the compatible property"). Use a correct 'atmel,<model>'
> value.
>
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
So my further input might be a bit unexpected :)
I took a look at the real board and understood that we specified in .dts
wrong ICs. Those Atmel parts are not connected to the CPU at all (used by some
external device) and instead I2C EEPROM we really have connected (but not yet
obviously used in the Linux kernel) is NXP's PCF8594C-2.
That said we may accept your change because it doesn't break anything
and then I'll send an update to axs10x_mb.dts with replacement of EEPROM nodes.
Or we may drop your change at all since I'm going to replace corresponding nodes.
-Alexey
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb
2018-02-06 12:25 ` Alexey Brodkin
@ 2018-02-06 18:01 ` Bartosz Golaszewski
[not found] ` <CAMRc=MfgLA2KDMFLM_GrbSb6MfQeAdHfVJXbnx-ss+S4xm72uw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Bartosz Golaszewski @ 2018-02-06 18:01 UTC (permalink / raw)
To: Alexey Brodkin
Cc: linux-kernel, mark.rutland, Vineet.Gupta1, robh+dt, devicetree,
linux-snps-arc
2018-02-06 13:25 GMT+01:00 Alexey Brodkin <Alexey.Brodkin@synopsys.com>:
> Hi Bartosz,
>
> On Tue, 2018-02-06 at 12:08 +0100, Bartosz Golaszewski wrote:
>> Using compatible strings without the <manufacturer> part for at24 is
>> deprecated since commit 6da28acf745f ("dt-bindings: at24: consistently
>> document the compatible property"). Use a correct 'atmel,<model>'
>> value.
>>
>> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
>
> So my further input might be a bit unexpected :)
>
> I took a look at the real board and understood that we specified in .dts
> wrong ICs. Those Atmel parts are not connected to the CPU at all (used by some
> external device) and instead I2C EEPROM we really have connected (but not yet
> obviously used in the Linux kernel) is NXP's PCF8594C-2.
>
> That said we may accept your change because it doesn't break anything
> and then I'll send an update to axs10x_mb.dts with replacement of EEPROM nodes.
> Or we may drop your change at all since I'm going to replace corresponding nodes.
>
> -Alexey
Looks like PCF8594C-2 is compatible with atmel,24c04 - when you'll be
submitting this patch, please extend the at24 DT bindings with a new
naming exception (just like the one for renesas).
Feel free to drop this patch if you plan to submit the fix soon -
otherwise, apply it if it may take some time.
Thanks,
Bartosz
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb
[not found] ` <CAMRc=MfgLA2KDMFLM_GrbSb6MfQeAdHfVJXbnx-ss+S4xm72uw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2018-02-06 21:04 ` Alexey Brodkin
[not found] ` <4881796E12491D4BB15146FE0209CE646802AACB-okAzG6w2b9vBRDCkatnZjvufCSb+aD3WLzEdoUbNIic@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Alexey Brodkin @ 2018-02-06 21:04 UTC (permalink / raw)
To: Bartosz Golaszewski, Vineet Gupta
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, mark.rutland-5wv7dgnIgG8,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Hi Bartosz,
> -----Original Message-----
> From: Bartosz Golaszewski [mailto:brgl@bgdev.pl]
> Sent: Tuesday, February 6, 2018 7:02 PM
> To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> Cc: linux-kernel@vger.kernel.org; mark.rutland@arm.com; Vineet.Gupta1@synopsys.com; robh+dt@kernel.org;
> devicetree@vger.kernel.org; linux-snps-arc@lists.infradead.org
> Subject: Re: [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb
>
> 2018-02-06 13:25 GMT+01:00 Alexey Brodkin <Alexey.Brodkin@synopsys.com>:
> > Hi Bartosz,
> >
> > On Tue, 2018-02-06 at 12:08 +0100, Bartosz Golaszewski wrote:
> >> Using compatible strings without the <manufacturer> part for at24 is
> >> deprecated since commit 6da28acf745f ("dt-bindings: at24: consistently
> >> document the compatible property"). Use a correct 'atmel,<model>'
> >> value.
> >>
> >> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> >
> > So my further input might be a bit unexpected :)
> >
> > I took a look at the real board and understood that we specified in .dts
> > wrong ICs. Those Atmel parts are not connected to the CPU at all (used by some
> > external device) and instead I2C EEPROM we really have connected (but not yet
> > obviously used in the Linux kernel) is NXP's PCF8594C-2.
> >
> > That said we may accept your change because it doesn't break anything
> > and then I'll send an update to axs10x_mb.dts with replacement of EEPROM nodes.
> > Or we may drop your change at all since I'm going to replace corresponding nodes.
> >
> > -Alexey
>
> Looks like PCF8594C-2 is compatible with atmel,24c04 - when you'll be
> submitting this patch, please extend the at24 DT bindings with a new
> naming exception (just like the one for renesas).
Thanks for checking this.
> Feel free to drop this patch if you plan to submit the fix soon -
> otherwise, apply it if it may take some time.
No I think it worth applying especially in the light of your comment about NXP EEPROM.
Vineet, could you please take this one?
-Alexey
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb
[not found] ` <4881796E12491D4BB15146FE0209CE646802AACB-okAzG6w2b9vBRDCkatnZjvufCSb+aD3WLzEdoUbNIic@public.gmane.org>
@ 2018-02-06 22:39 ` Vineet Gupta
0 siblings, 0 replies; 5+ messages in thread
From: Vineet Gupta @ 2018-02-06 22:39 UTC (permalink / raw)
To: Alexey Brodkin, Bartosz Golaszewski
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, mark.rutland-5wv7dgnIgG8,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On 02/06/2018 01:04 PM, Alexey Brodkin wrote:
>> Feel free to drop this patch if you plan to submit the fix soon -
>> otherwise, apply it if it may take some time.
> No I think it worth applying especially in the light of your comment about NXP EEPROM.
>
> Vineet, could you please take this one?
I've added your Acked-by to patch and pushed to for-curr !
-Vineet
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-06 22:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-06 11:08 [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb Bartosz Golaszewski
[not found] ` <20180206110810.9093-1-brgl-ARrdPY/1zhM@public.gmane.org>
2018-02-06 12:25 ` Alexey Brodkin
2018-02-06 18:01 ` Bartosz Golaszewski
[not found] ` <CAMRc=MfgLA2KDMFLM_GrbSb6MfQeAdHfVJXbnx-ss+S4xm72uw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-06 21:04 ` Alexey Brodkin
[not found] ` <4881796E12491D4BB15146FE0209CE646802AACB-okAzG6w2b9vBRDCkatnZjvufCSb+aD3WLzEdoUbNIic@public.gmane.org>
2018-02-06 22:39 ` Vineet Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).