From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: "Madalin Bucur (OSS)" <madalin.bucur@oss.nxp.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jonathan Corbet <corbet@lwn.net>,
Kishon Vijay Abraham I <kishon@ti.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 0/2] Fix 10G PHY interface types
Date: Fri, 3 Jan 2020 12:57:19 +0000 [thread overview]
Message-ID: <20200103125719.GF25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <DB8PR04MB698593C7DB07A82577562348EC230@DB8PR04MB6985.eurprd04.prod.outlook.com>
On Fri, Jan 03, 2020 at 12:22:58PM +0000, Madalin Bucur (OSS) wrote:
> > -----Original Message-----
> > From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org> On
> > Behalf Of Russell King - ARM Linux admin
> > Sent: Friday, January 3, 2020 1:51 PM
> > To: Andrew Lunn <andrew@lunn.ch>; Florian Fainelli <f.fainelli@gmail.com>;
> > Heiner Kallweit <hkallweit1@gmail.com>
> > Cc: David S. Miller <davem@davemloft.net>; Jonathan Corbet
> > <corbet@lwn.net>; Kishon Vijay Abraham I <kishon@ti.com>; linux-
> > doc@vger.kernel.org; netdev@vger.kernel.org
> > Subject: [PATCH net-next 0/2] Fix 10G PHY interface types
> >
> > Recent discussion has revealed that our current usage of the 10GKR
> > phy_interface_t is not correct. This is based on a misunderstanding
> > caused in part by the various specifications being difficult to
> > obtain. Now that a better understanding has been reached, we ought
> > to correct this.
> >
> > This series introduce PHY_INTERFACE_MODE_10GBASER to replace the
> > existing usage of 10GKR mode, and document their differences in the
> > phylib documentation. Then switch PHY, SFP/phylink, the Marvell
> > PP2 network driver, and its associated comphy driver over to use
> > the correct interface mode. None of the existing platform usage
> > was actually using 10GBASE-KR.
> >
> > In order to maintain compatibility with existing DT files, arrange
> > for the Marvell PP2 driver to rewrite the phy interface mode; this
> > allows other drivers to adopt correct behaviour w.r.t whether the
> > 10G connection conforms to the backplane 10GBASE-KR protocol vs
> > normal 10GBASE-R protocol.
> >
> > After applying these locally to net-next I've validated that the
> > only places which mention the old PHY_INTERFACE_MODE_10GKR
> > definition are:
> >
> > Documentation/networking/phy.rst:``PHY_INTERFACE_MODE_10GKR``
> > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c: if (phy_mode ==
> > PHY_INTERFACE_MODE_10GKR)
> > drivers/net/phy/aquantia_main.c: phydev->interface =
> > PHY_INTERFACE_MODE_10GKR;
> > drivers/net/phy/aquantia_main.c: phydev->interface !=
> > PHY_INTERFACE_MODE_10GKR &&
> > include/linux/phy.h: PHY_INTERFACE_MODE_10GKR,
> > include/linux/phy.h: case PHY_INTERFACE_MODE_10GKR:
> >
> > which is as expected. The only users of "10gbase-kr" in DT are:
> >
> > arch/arm64/boot/dts/marvell/armada-7040-db.dts: phy-mode = "10gbase-kr";
> > arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts: phy-mode =
> > "10gbase-kr";
> > arch/arm64/boot/dts/marvell/armada-8040-db.dts: phy-mode = "10gbase-kr";
> > arch/arm64/boot/dts/marvell/armada-8040-db.dts: phy-mode = "10gbase-kr";
> > arch/arm64/boot/dts/marvell/armada-8040-mcbin-singleshot.dts: phy-mode =
> > "10gbase-kr";
> > arch/arm64/boot/dts/marvell/armada-8040-mcbin-singleshot.dts: phy-mode =
> > "10gbase-kr";
> > arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts: phy-mode =
> > "10gbase-kr";arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts: phy-
> > mode = "10gbase-kr";arch/arm64/boot/dts/marvell/cn9130-db.dts: phy-
> > mode = "10gbase-kr";
> > arch/arm64/boot/dts/marvell/cn9131-db.dts: phy-mode = "10gbase-kr";
> > arch/arm64/boot/dts/marvell/cn9132-db.dts: phy-mode = "10gbase-kr";
> >
> > which all use the mvpp2 driver, and these will be updated in a
> > separate patch to be submitted in the following kernel cycle.
> >
> > Documentation/networking/phy.rst | 18 ++++++++++++++++++
> > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 13 ++++++++-----
> > drivers/net/phy/aquantia_main.c | 7 +++++--
> > drivers/net/phy/bcm84881.c | 4 ++--
> > drivers/net/phy/marvell10g.c | 11 ++++++-----
> > drivers/net/phy/phylink.c | 1 +
> > drivers/net/phy/sfp-bus.c | 2 +-
> > drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 20 ++++++++++----------
> > include/linux/phy.h | 12 ++++++++----
> > 9 files changed, 59 insertions(+), 29 deletions(-)
> >
> > --
> > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> > FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps
> > up
> > According to speedtest.net: 11.9Mbps down 500kbps up
>
> Hi,
>
> we should conclude our discussions on the initial thread before we do this.
> The current use on 10GBASE_KR is not correct, I agree but changing this to
> 10GBASE-R may not be the way to go. We need to determine if the existing
> device tree binding corelated type is the one we need to change or maybe a
> more complex solution is required. There are multiple paths forward:
>
> Extending this enum that has a mix of things in it that are barely related.
>
> For 10G Ethernet there is already an XGMII entry that describes the MII, if
> this should stick to strict MIIs. This is of little value for chips that
> have part of the traditional PHY blocks grouped along with the MAC, the XGMII
> is not exposed outside the RTL (if it even exists there) and the actual
> visible interfaces are completely different.
>
> Describing the actual interface at chip to chip level (RGMII, SGMII, XAUI,
> XFI, etc.). This may be incomplete for people trying to configure their HW
> that supports multiple modes (reminder - device trees describe HW, they do
> not configure SW). More details would be required and the list would be...
> eclectic.
>
> Moving to something different altogether, that would not conflict existing
> device trees but permit a more thorough classification and less ambiguity.
> We need more work on clearing a path towards that.
I think we've reached stalemate in this discussion. I don't think we
can make any useful forward progress at this point.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2020-01-03 12:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 11:51 [PATCH net-next 0/2] Fix 10G PHY interface types Russell King - ARM Linux admin
2020-01-03 11:52 ` [PATCH net-next 1/2] net: phy: add PHY_INTERFACE_MODE_10GBASER Russell King
2020-01-03 20:22 ` Andrew Lunn
2020-01-03 11:52 ` [PATCH net-next 2/2] net: switch to using PHY_INTERFACE_MODE_10GBASER rather than 10GKR Russell King
2020-01-03 20:25 ` Andrew Lunn
2020-01-03 20:41 ` Russell King - ARM Linux admin
2020-01-03 12:22 ` [PATCH net-next 0/2] Fix 10G PHY interface types Madalin Bucur (OSS)
2020-01-03 12:57 ` Russell King - ARM Linux admin [this message]
2020-01-03 14:17 ` Andrew Lunn
2020-01-03 16:33 ` Madalin Bucur (OSS)
2020-01-03 16:47 ` Andrew Lunn
2020-01-06 9:16 ` Madalin Bucur (OSS)
2020-01-03 20:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103125719.GF25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kishon@ti.com \
--cc=linux-doc@vger.kernel.org \
--cc=madalin.bucur@oss.nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).