From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jonathan Corbet <corbet@lwn.net>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-doc@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: switch to using PHY_INTERFACE_MODE_10GBASER rather than 10GKR
Date: Fri, 3 Jan 2020 20:41:02 +0000 [thread overview]
Message-ID: <20200103204102.GI25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200103202504.GQ1397@lunn.ch>
On Fri, Jan 03, 2020 at 09:25:04PM +0100, Andrew Lunn wrote:
> > For Marvell mvpp2, we detect 10GBASE-KR, and rewrite it to 10GBASE-R
> > for compatibility with existing DT - this is the only network driver
> > at present that makes use of PHY_INTERFACE_MODE_10GKR.
> >
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > @@ -5247,6 +5247,9 @@ static int mvpp2_port_probe(struct platform_device *pdev,
> > goto err_free_netdev;
> > }
> >
> > + if (phy_mode == PHY_INTERFACE_MODE_10GKR)
> > + phy_mode = PHY_INTERFACE_MODE_10GBASER;
>
> Hi Russell
>
> Maybe consider adding a comment here, or suggest readers to read the
> commit message of the patch that added these two lines to get the full
> story.
It's a bit difficult to refer to the commit SHA in the commit itself,
but yes, that's a good idea. I'll send v2 shortly.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2020-01-03 20:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 11:51 [PATCH net-next 0/2] Fix 10G PHY interface types Russell King - ARM Linux admin
2020-01-03 11:52 ` [PATCH net-next 1/2] net: phy: add PHY_INTERFACE_MODE_10GBASER Russell King
2020-01-03 20:22 ` Andrew Lunn
2020-01-03 11:52 ` [PATCH net-next 2/2] net: switch to using PHY_INTERFACE_MODE_10GBASER rather than 10GKR Russell King
2020-01-03 20:25 ` Andrew Lunn
2020-01-03 20:41 ` Russell King - ARM Linux admin [this message]
2020-01-03 12:22 ` [PATCH net-next 0/2] Fix 10G PHY interface types Madalin Bucur (OSS)
2020-01-03 12:57 ` Russell King - ARM Linux admin
2020-01-03 14:17 ` Andrew Lunn
2020-01-03 16:33 ` Madalin Bucur (OSS)
2020-01-03 16:47 ` Andrew Lunn
2020-01-06 9:16 ` Madalin Bucur (OSS)
2020-01-03 20:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103204102.GI25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kishon@ti.com \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).