* [PATCH] docs: lockdep-design: improve readability of the block matrix
@ 2021-05-24 15:05 Xiongwei Song
2021-05-27 3:30 ` Boqun Feng
2021-05-27 13:37 ` Waiman Long
0 siblings, 2 replies; 4+ messages in thread
From: Xiongwei Song @ 2021-05-24 15:05 UTC (permalink / raw)
To: peterz, mingo, will, longman, boqun.feng, corbet
Cc: linux-doc, linux-kernel, Xiongwei Song
From: Xiongwei Song <sxwjean@gmail.com>
The block condition matrix is using 'E' as the writer notation, however,
the writer reminder below the matrix is using 'W', to make them consistent
and make the matrix more readable, we'd better to use 'W' to represent
writer.
Suggested-by: Waiman Long <llong@redhat.com>
Suggested-by: Boqun Feng <boqun.feng@gmail.com>
Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
---
Documentation/locking/lockdep-design.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/locking/lockdep-design.rst b/Documentation/locking/lockdep-design.rst
index 9f3cfca..82f36ca 100644
--- a/Documentation/locking/lockdep-design.rst
+++ b/Documentation/locking/lockdep-design.rst
@@ -453,9 +453,9 @@ There are simply four block conditions:
Block condition matrix, Y means the row blocks the column, and N means otherwise.
+---+---+---+---+
- | | E | r | R |
+ | | W | r | R |
+---+---+---+---+
- | E | Y | Y | Y |
+ | W | Y | Y | Y |
+---+---+---+---+
| r | Y | Y | N |
+---+---+---+---+
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] docs: lockdep-design: improve readability of the block matrix
2021-05-24 15:05 [PATCH] docs: lockdep-design: improve readability of the block matrix Xiongwei Song
@ 2021-05-27 3:30 ` Boqun Feng
2021-05-27 7:04 ` Peter Zijlstra
2021-05-27 13:37 ` Waiman Long
1 sibling, 1 reply; 4+ messages in thread
From: Boqun Feng @ 2021-05-27 3:30 UTC (permalink / raw)
To: Xiongwei Song
Cc: peterz, mingo, will, longman, corbet, linux-doc, linux-kernel,
Xiongwei Song
On Mon, May 24, 2021 at 11:05:45PM +0800, Xiongwei Song wrote:
> From: Xiongwei Song <sxwjean@gmail.com>
>
> The block condition matrix is using 'E' as the writer notation, however,
> the writer reminder below the matrix is using 'W', to make them consistent
> and make the matrix more readable, we'd better to use 'W' to represent
> writer.
>
> Suggested-by: Waiman Long <llong@redhat.com>
> Suggested-by: Boqun Feng <boqun.feng@gmail.com>
> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Regards,
Boqun
> ---
> Documentation/locking/lockdep-design.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/locking/lockdep-design.rst b/Documentation/locking/lockdep-design.rst
> index 9f3cfca..82f36ca 100644
> --- a/Documentation/locking/lockdep-design.rst
> +++ b/Documentation/locking/lockdep-design.rst
> @@ -453,9 +453,9 @@ There are simply four block conditions:
> Block condition matrix, Y means the row blocks the column, and N means otherwise.
>
> +---+---+---+---+
> - | | E | r | R |
> + | | W | r | R |
> +---+---+---+---+
> - | E | Y | Y | Y |
> + | W | Y | Y | Y |
> +---+---+---+---+
> | r | Y | Y | N |
> +---+---+---+---+
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] docs: lockdep-design: improve readability of the block matrix
2021-05-27 3:30 ` Boqun Feng
@ 2021-05-27 7:04 ` Peter Zijlstra
0 siblings, 0 replies; 4+ messages in thread
From: Peter Zijlstra @ 2021-05-27 7:04 UTC (permalink / raw)
To: Boqun Feng
Cc: Xiongwei Song, mingo, will, longman, corbet, linux-doc,
linux-kernel, Xiongwei Song
On Thu, May 27, 2021 at 11:30:14AM +0800, Boqun Feng wrote:
> On Mon, May 24, 2021 at 11:05:45PM +0800, Xiongwei Song wrote:
> > From: Xiongwei Song <sxwjean@gmail.com>
> >
> > The block condition matrix is using 'E' as the writer notation, however,
> > the writer reminder below the matrix is using 'W', to make them consistent
> > and make the matrix more readable, we'd better to use 'W' to represent
> > writer.
> >
> > Suggested-by: Waiman Long <llong@redhat.com>
> > Suggested-by: Boqun Feng <boqun.feng@gmail.com>
> > Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
>
> Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] docs: lockdep-design: improve readability of the block matrix
2021-05-24 15:05 [PATCH] docs: lockdep-design: improve readability of the block matrix Xiongwei Song
2021-05-27 3:30 ` Boqun Feng
@ 2021-05-27 13:37 ` Waiman Long
1 sibling, 0 replies; 4+ messages in thread
From: Waiman Long @ 2021-05-27 13:37 UTC (permalink / raw)
To: Xiongwei Song, peterz, mingo, will, boqun.feng, corbet
Cc: linux-doc, linux-kernel, Xiongwei Song
On 5/24/21 11:05 AM, Xiongwei Song wrote:
> From: Xiongwei Song <sxwjean@gmail.com>
>
> The block condition matrix is using 'E' as the writer notation, however,
> the writer reminder below the matrix is using 'W', to make them consistent
> and make the matrix more readable, we'd better to use 'W' to represent
> writer.
>
> Suggested-by: Waiman Long <llong@redhat.com>
> Suggested-by: Boqun Feng <boqun.feng@gmail.com>
> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
> ---
> Documentation/locking/lockdep-design.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/locking/lockdep-design.rst b/Documentation/locking/lockdep-design.rst
> index 9f3cfca..82f36ca 100644
> --- a/Documentation/locking/lockdep-design.rst
> +++ b/Documentation/locking/lockdep-design.rst
> @@ -453,9 +453,9 @@ There are simply four block conditions:
> Block condition matrix, Y means the row blocks the column, and N means otherwise.
>
> +---+---+---+---+
> - | | E | r | R |
> + | | W | r | R |
> +---+---+---+---+
> - | E | Y | Y | Y |
> + | W | Y | Y | Y |
> +---+---+---+---+
> | r | Y | Y | N |
> +---+---+---+---+
Acked-by: Waiman Long <longman@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-27 13:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24 15:05 [PATCH] docs: lockdep-design: improve readability of the block matrix Xiongwei Song
2021-05-27 3:30 ` Boqun Feng
2021-05-27 7:04 ` Peter Zijlstra
2021-05-27 13:37 ` Waiman Long
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).