Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
From: James Morse <james.morse@arm.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: bp@alien8.de, robh+dt@kernel.org, mark.rutland@arm.com,
	linux@armlinux.org.uk, patches@armlinux.org.uk,
	mchehab@kernel.org, jlu@pengutronix.de,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 8/8] EDAC: armada_xp: Add support for more SoCs
Date: Fri, 26 Jul 2019 15:51:15 +0100
Message-ID: <128016c1-380f-70c4-3a89-2d3b0edf9f88@arm.com> (raw)
In-Reply-To: <20190712034904.5747-9-chris.packham@alliedtelesis.co.nz>

Hi Chris,

On 12/07/2019 04:49, Chris Packham wrote:
> The Armada 38x and other integrated SoCs use a reduced pin count so the
> width of the SDRAM interface is smaller than the Armada XP SoCs. This
> means that the definition of "full" and "half" width is reduced from
> 64/32 to 32/16.

> diff --git a/drivers/edac/armada_xp_edac.c b/drivers/edac/armada_xp_edac.c
> index 3759a4fbbdee..7f227bdcbc84 100644
> --- a/drivers/edac/armada_xp_edac.c
> +++ b/drivers/edac/armada_xp_edac.c
> @@ -332,6 +332,11 @@ static int axp_mc_probe(struct platform_device *pdev)
>  
>  	axp_mc_read_config(mci);
>  
> +	/* These SoCs have a reduced width bus */
> +	if (of_machine_is_compatible("marvell,armada380") ||
> +	    of_machine_is_compatible("marvell,armadaxp-98dx3236"))
> +		drvdata->width /= 2;

So the hardware's SDRAM_CONFIG_BUS_WIDTH value is wrong? Yuck.

Is it too late for the DTs on these two systems to provide a DT version of the 'bus_width'
to override the hardware's mis-advertised value?

This way you don't need to grow this list.

Acked-by: James Morse <james.morse@arm.com>


Thanks,

James

  reply index

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12  3:48 [PATCH v9 0/8] EDAC drivers for Armada XP L2 and DDR Chris Packham
2019-07-12  3:48 ` [PATCH v9 1/8] ARM: aurora-l2: add prefix to MAX_RANGE_SIZE Chris Packham
2019-08-23 10:46   ` Russell King - ARM Linux admin
2019-08-23 10:50     ` Russell King - ARM Linux admin
2019-08-26  0:46       ` Chris Packham
2019-08-27  9:13         ` Russell King - ARM Linux admin
2019-08-27 20:56           ` Chris Packham
2019-08-27 21:07             ` Russell King - ARM Linux admin
2019-08-27 21:13               ` Chris Packham
2019-08-27 21:15                 ` Russell King - ARM Linux admin
2019-07-12  3:48 ` [PATCH v9 2/8] ARM: aurora-l2: add defines for parity and ECC registers Chris Packham
2019-07-12  3:48 ` [PATCH v9 3/8] ARM: l2x0: support parity-enable/disable on aurora Chris Packham
2019-07-12  3:49 ` [PATCH v9 4/8] dt-bindings: ARM: document marvell,ecc-enable binding Chris Packham
2019-07-12  3:49 ` [PATCH v9 5/8] ARM: l2x0: add marvell,ecc-enable property for aurora Chris Packham
2019-07-12  3:49 ` [PATCH v9 6/8] EDAC: Add missing debugfs_create_x32 wrapper Chris Packham
2019-07-12  3:49 ` [PATCH v9 7/8] EDAC: Add driver for the Marvell Armada XP SDRAM and L2 cache ECC Chris Packham
2019-07-12  3:49 ` [PATCH v9 8/8] EDAC: armada_xp: Add support for more SoCs Chris Packham
2019-07-26 14:51   ` James Morse [this message]
2019-07-28 20:52     ` Chris Packham
2019-07-26 14:53 ` [PATCH v9 0/8] EDAC drivers for Armada XP L2 and DDR James Morse
2019-07-28 20:33   ` Chris Packham

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=128016c1-380f-70c4-3a89-2d3b0edf9f88@arm.com \
    --to=james.morse@arm.com \
    --cc=bp@alien8.de \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=devicetree@vger.kernel.org \
    --cc=jlu@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=patches@armlinux.org.uk \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org linux-edac@archiver.kernel.org
	public-inbox-index linux-edac


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/ public-inbox