* [PATCH -next] EDAC, thunderx: Make symbol 'lmc_dfs_ents' static
@ 2020-07-14 14:23 Wei Yongjun
2020-07-27 13:56 ` Robert Richter
2020-08-17 8:49 ` Borislav Petkov
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2020-07-14 14:23 UTC (permalink / raw)
To: Hulk Robot, Robert Richter, Borislav Petkov,
Mauro Carvalho Chehab, Tony Luck
Cc: Wei Yongjun, linux-edac
The sparse tool complains as follows:
drivers/edac/thunderx_edac.c:457:22: warning:
symbol 'lmc_dfs_ents' was not declared. Should it be static?
Symbol 'lmc_dfs_ents' is not used outside of thunderx_edac.c, so
marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/edac/thunderx_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
index 4af9744cc6d0..0eb5eb97fd74 100644
--- a/drivers/edac/thunderx_edac.c
+++ b/drivers/edac/thunderx_edac.c
@@ -454,7 +454,7 @@ DEBUGFS_STRUCT(inject_int, 0200, thunderx_lmc_inject_int_write, NULL);
DEBUGFS_STRUCT(inject_ecc, 0200, thunderx_lmc_inject_ecc_write, NULL);
DEBUGFS_STRUCT(int_w1c, 0400, NULL, thunderx_lmc_int_read);
-struct debugfs_entry *lmc_dfs_ents[] = {
+static struct debugfs_entry *lmc_dfs_ents[] = {
&debugfs_mask0,
&debugfs_mask2,
&debugfs_parity_test,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] EDAC, thunderx: Make symbol 'lmc_dfs_ents' static
2020-07-14 14:23 [PATCH -next] EDAC, thunderx: Make symbol 'lmc_dfs_ents' static Wei Yongjun
@ 2020-07-27 13:56 ` Robert Richter
2020-08-17 8:49 ` Borislav Petkov
1 sibling, 0 replies; 3+ messages in thread
From: Robert Richter @ 2020-07-27 13:56 UTC (permalink / raw)
To: Wei Yongjun
Cc: Hulk Robot, Borislav Petkov, Mauro Carvalho Chehab, Tony Luck,
linux-edac
On 14.07.20 22:23:08, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/edac/thunderx_edac.c:457:22: warning:
> symbol 'lmc_dfs_ents' was not declared. Should it be static?
>
> Symbol 'lmc_dfs_ents' is not used outside of thunderx_edac.c, so
> marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Robert Richter <rrichter@marvell.com>
> ---
> drivers/edac/thunderx_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
> index 4af9744cc6d0..0eb5eb97fd74 100644
> --- a/drivers/edac/thunderx_edac.c
> +++ b/drivers/edac/thunderx_edac.c
> @@ -454,7 +454,7 @@ DEBUGFS_STRUCT(inject_int, 0200, thunderx_lmc_inject_int_write, NULL);
> DEBUGFS_STRUCT(inject_ecc, 0200, thunderx_lmc_inject_ecc_write, NULL);
> DEBUGFS_STRUCT(int_w1c, 0400, NULL, thunderx_lmc_int_read);
>
> -struct debugfs_entry *lmc_dfs_ents[] = {
> +static struct debugfs_entry *lmc_dfs_ents[] = {
> &debugfs_mask0,
> &debugfs_mask2,
> &debugfs_parity_test,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] EDAC, thunderx: Make symbol 'lmc_dfs_ents' static
2020-07-14 14:23 [PATCH -next] EDAC, thunderx: Make symbol 'lmc_dfs_ents' static Wei Yongjun
2020-07-27 13:56 ` Robert Richter
@ 2020-08-17 8:49 ` Borislav Petkov
1 sibling, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2020-08-17 8:49 UTC (permalink / raw)
To: Wei Yongjun
Cc: Hulk Robot, Robert Richter, Mauro Carvalho Chehab, Tony Luck, linux-edac
On Tue, Jul 14, 2020 at 10:23:08PM +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/edac/thunderx_edac.c:457:22: warning:
> symbol 'lmc_dfs_ents' was not declared. Should it be static?
>
> Symbol 'lmc_dfs_ents' is not used outside of thunderx_edac.c, so
> marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/edac/thunderx_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
> index 4af9744cc6d0..0eb5eb97fd74 100644
> --- a/drivers/edac/thunderx_edac.c
> +++ b/drivers/edac/thunderx_edac.c
> @@ -454,7 +454,7 @@ DEBUGFS_STRUCT(inject_int, 0200, thunderx_lmc_inject_int_write, NULL);
> DEBUGFS_STRUCT(inject_ecc, 0200, thunderx_lmc_inject_ecc_write, NULL);
> DEBUGFS_STRUCT(int_w1c, 0400, NULL, thunderx_lmc_int_read);
>
> -struct debugfs_entry *lmc_dfs_ents[] = {
> +static struct debugfs_entry *lmc_dfs_ents[] = {
> &debugfs_mask0,
> &debugfs_mask2,
> &debugfs_parity_test,
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-17 8:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-14 14:23 [PATCH -next] EDAC, thunderx: Make symbol 'lmc_dfs_ents' static Wei Yongjun
2020-07-27 13:56 ` Robert Richter
2020-08-17 8:49 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).