* [PATCH] edac: amd64_edac: remove unneeded break
@ 2020-10-19 19:35 trix
2020-10-19 21:07 ` Robert Richter
2020-10-26 11:11 ` Borislav Petkov
0 siblings, 2 replies; 3+ messages in thread
From: trix @ 2020-10-19 19:35 UTC (permalink / raw)
To: bp, mchehab, tony.luck, james.morse, rric
Cc: linux-edac, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a return
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/edac/amd64_edac.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index fcc08bbf6945..386a3a4cf279 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -2461,14 +2461,11 @@ static int map_err_sym_to_channel(int err_sym, int sym_size)
case 0x20:
case 0x21:
return 0;
- break;
case 0x22:
case 0x23:
return 1;
- break;
default:
return err_sym >> 4;
- break;
}
/* x8 symbols */
else
@@ -2478,17 +2475,12 @@ static int map_err_sym_to_channel(int err_sym, int sym_size)
WARN(1, KERN_ERR "Invalid error symbol: 0x%x\n",
err_sym);
return -1;
- break;
-
case 0x11:
return 0;
- break;
case 0x12:
return 1;
- break;
default:
return err_sym >> 3;
- break;
}
return -1;
}
--
2.18.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] edac: amd64_edac: remove unneeded break
2020-10-19 19:35 [PATCH] edac: amd64_edac: remove unneeded break trix
@ 2020-10-19 21:07 ` Robert Richter
2020-10-26 11:11 ` Borislav Petkov
1 sibling, 0 replies; 3+ messages in thread
From: Robert Richter @ 2020-10-19 21:07 UTC (permalink / raw)
To: trix; +Cc: bp, mchehab, tony.luck, james.morse, linux-edac, linux-kernel
On 19.10.20 12:35:24, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Robert Richter <rric@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] edac: amd64_edac: remove unneeded break
2020-10-19 19:35 [PATCH] edac: amd64_edac: remove unneeded break trix
2020-10-19 21:07 ` Robert Richter
@ 2020-10-26 11:11 ` Borislav Petkov
1 sibling, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2020-10-26 11:11 UTC (permalink / raw)
To: trix; +Cc: mchehab, tony.luck, james.morse, rric, linux-edac, linux-kernel
On Mon, Oct 19, 2020 at 12:35:24PM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/edac/amd64_edac.c | 8 --------
> 1 file changed, 8 deletions(-)
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-26 11:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 19:35 [PATCH] edac: amd64_edac: remove unneeded break trix
2020-10-19 21:07 ` Robert Richter
2020-10-26 11:11 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).