Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] EDAC/amd64: Discard unnecessary break
@ 2020-10-26  9:11 Zhang Qilong
  2020-10-26 11:12 ` Borislav Petkov
  0 siblings, 1 reply; 2+ messages in thread
From: Zhang Qilong @ 2020-10-26  9:11 UTC (permalink / raw)
  To: bp, james.morse, rric; +Cc: mchehab, tony.luck, linux-edac

A 'break' is unnecessary because of previous 'return'.

Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
 drivers/edac/amd64_edac.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 1362274d840b..a1c9e68b35d9 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -2461,14 +2461,11 @@ static int map_err_sym_to_channel(int err_sym, int sym_size)
 		case 0x20:
 		case 0x21:
 			return 0;
-			break;
 		case 0x22:
 		case 0x23:
 			return 1;
-			break;
 		default:
 			return err_sym >> 4;
-			break;
 		}
 	/* x8 symbols */
 	else
@@ -2478,17 +2475,13 @@ static int map_err_sym_to_channel(int err_sym, int sym_size)
 			WARN(1, KERN_ERR "Invalid error symbol: 0x%x\n",
 					  err_sym);
 			return -1;
-			break;
 
 		case 0x11:
 			return 0;
-			break;
 		case 0x12:
 			return 1;
-			break;
 		default:
 			return err_sym >> 3;
-			break;
 		}
 	return -1;
 }
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] EDAC/amd64: Discard unnecessary break
  2020-10-26  9:11 [PATCH -next] EDAC/amd64: Discard unnecessary break Zhang Qilong
@ 2020-10-26 11:12 ` Borislav Petkov
  0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2020-10-26 11:12 UTC (permalink / raw)
  To: Zhang Qilong; +Cc: james.morse, rric, mchehab, tony.luck, linux-edac

On Mon, Oct 26, 2020 at 05:11:03PM +0800, Zhang Qilong wrote:
> A 'break' is unnecessary because of previous 'return'.
> 
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> ---
>  drivers/edac/amd64_edac.c | 7 -------
>  1 file changed, 7 deletions(-)

https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git/commit/?h=edac-misc&id=f09056c1decec889721c24c72f99730376918044

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-26  9:11 [PATCH -next] EDAC/amd64: Discard unnecessary break Zhang Qilong
2020-10-26 11:12 ` Borislav Petkov

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git