linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org, avadhut.naik@amd.com
Subject: Re: [PATCH] EDAC/mce_amd: Decode Cache Level "L0" Error Code
Date: Mon, 10 Apr 2023 16:53:50 -0400	[thread overview]
Message-ID: <9549e422-e5b2-ccf6-3c8d-ac61436e7fa6@amd.com> (raw)
In-Reply-To: <20230410204710.GBZDR1ziKdqr4ihJZh@fat_crate.local>

On 4/10/23 16:47, Borislav Petkov wrote:
> On Mon, Apr 10, 2023 at 03:33:57PM -0500, Yazen Ghannam wrote:
>> The "L0" cache level is listed as "reserved" in legacy documentation.
>> This has now been defined as "Core" in current documentation for
>> Zen-based systems.
>>
>> Update the cache level strings to include this new definition.
>>
>> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
>> ---
>>  drivers/edac/mce_amd.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
>> index cc5c63feb26a..1d1b9da3b9bd 100644
>> --- a/drivers/edac/mce_amd.c
>> +++ b/drivers/edac/mce_amd.c
>> @@ -37,7 +37,7 @@ EXPORT_SYMBOL_GPL(amd_unregister_ecc_decoder);
>>  static const char * const tt_msgs[] = { "INSN", "DATA", "GEN", "RESV" };
>>  
>>  /* cache level */
>> -static const char * const ll_msgs[] = { "RESV", "L1", "L2", "L3/GEN" };
>> +static const char * const ll_msgs[] = { "CORE", "L1", "L2", "L3/GEN" };
> 
> Still used on legacy machines. I thought we agreed we'll move all the
> decoding to luserspace, for newer Zens...
> 

I was thinking about that for the Extended Error Code descriptions. But good
point, please disregard this patch.

Thanks,
Yazen



      reply	other threads:[~2023-04-10 20:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-10 20:33 [PATCH] EDAC/mce_amd: Decode Cache Level "L0" Error Code Yazen Ghannam
2023-04-10 20:47 ` Borislav Petkov
2023-04-10 20:53   ` Yazen Ghannam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9549e422-e5b2-ccf6-3c8d-ac61436e7fa6@amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=avadhut.naik@amd.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).