From: Zhenzhong Duan <zhenzhong.duan@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-edac@vger.kernel.org, tony.luck@intel.com,
mchehab@kernel.org, james.morse@arm.com, rrichter@marvell.com
Subject: Re: [PATCH] EDAC, {skx,i10nm}: Advice mcelog that the error were handled
Date: Wed, 10 Jun 2020 16:48:26 +0800 [thread overview]
Message-ID: <CAFH1YnNsM0okzpLru9Fd__F9yp-a00+J17L2atLBrnV3vWSqLw@mail.gmail.com> (raw)
In-Reply-To: <20200610082040.GB14118@zn.tnic>
On Wed, Jun 10, 2020 at 4:20 PM Borislav Petkov <bp@alien8.de> wrote:
>
> On Wed, Jun 10, 2020 at 02:58:01PM +0800, Zhenzhong Duan wrote:
> > If one MCE error has been processed in kernel, it's not necessory
> > to pass it to user level mcelog.
> >
> > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
> > ---
> > drivers/edac/skx_common.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c
> > index 46be1a7..8c0165b 100644
> > --- a/drivers/edac/skx_common.c
> > +++ b/drivers/edac/skx_common.c
> > @@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val,
> >
> > skx_mce_output_error(mci, mce, &res);
> >
> > - return NOTIFY_DONE;
> > + /* Advice mcelog that the error were handled */
> > + return NOTIFY_STOP;
> > }
> >
> > void skx_remove(void)
> > --
>
> No, we won't be doing that anymore. See here:
>
> https://git.kernel.org/tip/23ba710a0864108910c7531dc4c73ef65eca5568
>
> it should appear mainline soon-ish, I hope.
I see, thanks for showing.
Zhenzhong
next prev parent reply other threads:[~2020-06-10 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 6:58 [PATCH] EDAC, {skx,i10nm}: Advice mcelog that the error were handled Zhenzhong Duan
2020-06-10 8:20 ` Borislav Petkov
2020-06-10 8:48 ` Zhenzhong Duan [this message]
2020-06-10 10:18 ` [PATCH] EDAC, {skx, i10nm}: " Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFH1YnNsM0okzpLru9Fd__F9yp-a00+J17L2atLBrnV3vWSqLw@mail.gmail.com \
--to=zhenzhong.duan@gmail.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).