Linux-EDAC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] EDAC, {skx,i10nm}: Advice mcelog that the error were handled
@ 2020-06-10  6:58 Zhenzhong Duan
  2020-06-10  8:20 ` Borislav Petkov
  2020-06-10 10:18 ` [PATCH] EDAC, {skx, i10nm}: " Robert Richter
  0 siblings, 2 replies; 4+ messages in thread
From: Zhenzhong Duan @ 2020-06-10  6:58 UTC (permalink / raw)
  To: linux-kernel, linux-edac
  Cc: tony.luck, bp, mchehab, james.morse, rrichter, Zhenzhong Duan

If one MCE error has been processed in kernel, it's not necessory
to pass it to user level mcelog.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
---
 drivers/edac/skx_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c
index 46be1a7..8c0165b 100644
--- a/drivers/edac/skx_common.c
+++ b/drivers/edac/skx_common.c
@@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val,
 
 	skx_mce_output_error(mci, mce, &res);
 
-	return NOTIFY_DONE;
+	/* Advice mcelog that the error were handled */
+	return NOTIFY_STOP;
 }
 
 void skx_remove(void)
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] EDAC, {skx,i10nm}: Advice mcelog that the error were handled
  2020-06-10  6:58 [PATCH] EDAC, {skx,i10nm}: Advice mcelog that the error were handled Zhenzhong Duan
@ 2020-06-10  8:20 ` Borislav Petkov
  2020-06-10  8:48   ` Zhenzhong Duan
  2020-06-10 10:18 ` [PATCH] EDAC, {skx, i10nm}: " Robert Richter
  1 sibling, 1 reply; 4+ messages in thread
From: Borislav Petkov @ 2020-06-10  8:20 UTC (permalink / raw)
  To: Zhenzhong Duan
  Cc: linux-kernel, linux-edac, tony.luck, mchehab, james.morse, rrichter

On Wed, Jun 10, 2020 at 02:58:01PM +0800, Zhenzhong Duan wrote:
> If one MCE error has been processed in kernel, it's not necessory
> to pass it to user level mcelog.
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
> ---
>  drivers/edac/skx_common.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c
> index 46be1a7..8c0165b 100644
> --- a/drivers/edac/skx_common.c
> +++ b/drivers/edac/skx_common.c
> @@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val,
>  
>  	skx_mce_output_error(mci, mce, &res);
>  
> -	return NOTIFY_DONE;
> +	/* Advice mcelog that the error were handled */
> +	return NOTIFY_STOP;
>  }
>  
>  void skx_remove(void)
> -- 

No, we won't be doing that anymore. See here:

https://git.kernel.org/tip/23ba710a0864108910c7531dc4c73ef65eca5568

it should appear mainline soon-ish, I hope.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] EDAC, {skx,i10nm}: Advice mcelog that the error were handled
  2020-06-10  8:20 ` Borislav Petkov
@ 2020-06-10  8:48   ` Zhenzhong Duan
  0 siblings, 0 replies; 4+ messages in thread
From: Zhenzhong Duan @ 2020-06-10  8:48 UTC (permalink / raw)
  To: Borislav Petkov
  Cc: linux-kernel, linux-edac, tony.luck, mchehab, james.morse, rrichter

On Wed, Jun 10, 2020 at 4:20 PM Borislav Petkov <bp@alien8.de> wrote:
>
> On Wed, Jun 10, 2020 at 02:58:01PM +0800, Zhenzhong Duan wrote:
> > If one MCE error has been processed in kernel, it's not necessory
> > to pass it to user level mcelog.
> >
> > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
> > ---
> >  drivers/edac/skx_common.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c
> > index 46be1a7..8c0165b 100644
> > --- a/drivers/edac/skx_common.c
> > +++ b/drivers/edac/skx_common.c
> > @@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val,
> >
> >       skx_mce_output_error(mci, mce, &res);
> >
> > -     return NOTIFY_DONE;
> > +     /* Advice mcelog that the error were handled */
> > +     return NOTIFY_STOP;
> >  }
> >
> >  void skx_remove(void)
> > --
>
> No, we won't be doing that anymore. See here:
>
> https://git.kernel.org/tip/23ba710a0864108910c7531dc4c73ef65eca5568
>
> it should appear mainline soon-ish, I hope.

I see, thanks for showing.

Zhenzhong

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] EDAC, {skx, i10nm}: Advice mcelog that the error were handled
  2020-06-10  6:58 [PATCH] EDAC, {skx,i10nm}: Advice mcelog that the error were handled Zhenzhong Duan
  2020-06-10  8:20 ` Borislav Petkov
@ 2020-06-10 10:18 ` Robert Richter
  1 sibling, 0 replies; 4+ messages in thread
From: Robert Richter @ 2020-06-10 10:18 UTC (permalink / raw)
  To: Zhenzhong Duan
  Cc: linux-kernel, linux-edac, tony.luck, bp, mchehab, james.morse

On 10.06.20 14:58:01, Zhenzhong Duan wrote:
> If one MCE error has been processed in kernel, it's not necessory
> to pass it to user level mcelog.
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>

Reviewed-by: Robert Richter <rrichter@marvell.com>

> ---
>  drivers/edac/skx_common.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c
> index 46be1a7..8c0165b 100644
> --- a/drivers/edac/skx_common.c
> +++ b/drivers/edac/skx_common.c
> @@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val,
>  
>  	skx_mce_output_error(mci, mce, &res);
>  
> -	return NOTIFY_DONE;
> +	/* Advice mcelog that the error were handled */

... error was ...

And make a sentence out of it, so close with a dot.

> +	return NOTIFY_STOP;

This change aligns with other implementation in:

 i7core_mce_check_error(),
 amd_decode_mce() and
 sbridge_mce_check_error().

-Robert

>  }
>  
>  void skx_remove(void)
> -- 
> 1.8.3.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-10  6:58 [PATCH] EDAC, {skx,i10nm}: Advice mcelog that the error were handled Zhenzhong Duan
2020-06-10  8:20 ` Borislav Petkov
2020-06-10  8:48   ` Zhenzhong Duan
2020-06-10 10:18 ` [PATCH] EDAC, {skx, i10nm}: " Robert Richter

Linux-EDAC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-edac/0 linux-edac/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-edac linux-edac/ https://lore.kernel.org/linux-edac \
		linux-edac@vger.kernel.org
	public-inbox-index linux-edac

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-edac


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git