From: "Lei Wang (DPLAT)" <Wang.Lei@microsoft.com>
To: Borislav Petkov <bp@alien8.de>, wangglei <wangglei@gmail.com>
Cc: "mchehab@kernel.org" <mchehab@kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"rric@kernel.org" <rric@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hang Li <hangl@microsoft.com>,
"tyhicks@linux.microsoft.com" <tyhicks@linux.microsoft.com>,
Brandon Waller <bwaller@microsoft.com>
Subject: RE: [EXTERNAL] Re: [PATCH] EDAC: update edac printk wrappers to use printk_ratelimited.
Date: Wed, 5 May 2021 19:02:14 +0000 [thread overview]
Message-ID: <SJ0PR21MB199984A8B47FBEECEC5D11CE90599@SJ0PR21MB1999.namprd21.prod.outlook.com> (raw)
In-Reply-To: <YJLdZCcsgWG6TrKz@zn.tnic>
Hi Boris,
We found a corner case in production environment that there are ~500 CE errors per second. The SoC otherwise functions just fine. Making printk ratelimited reduced CE error logging to < 20 per second. Though this is just one case so far, we think moving to printk_ratelimited could benefit broader use as well, by helping control the amount of kernel logging. In most running condition, the error rate is way below the limit. And in an error case like this one, vast error logging would not provide much valuable details, rather it's storming the kernel logging.
Thanks,
-Lei
-----Original Message-----
From: Borislav Petkov <bp@alien8.de>
Sent: Wednesday, May 5, 2021 11:01 AM
To: wangglei <wangglei@gmail.com>
Cc: mchehab@kernel.org; tony.luck@intel.com; james.morse@arm.com; rric@kernel.org; linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; Lei Wang (DPLAT) <Wang.Lei@microsoft.com>; Hang Li <hangl@microsoft.com>; tyhicks@linux.microsoft.com; Brandon Waller <bwaller@microsoft.com>
Subject: [EXTERNAL] Re: [PATCH] EDAC: update edac printk wrappers to use printk_ratelimited.
On Wed, May 05, 2021 at 10:30:27AM -0700, Lei Wang wrote:
> Update printk to the ratelimited version, so that in some corner cases
> when vast of CE errors show up, the kernel logging can be suppressed.
Err, why?
--
Regards/Gruss,
Boris.
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeople.kernel.org%2Ftglx%2Fnotes-about-netiquette&data=04%7C01%7CWang.Lei%40microsoft.com%7C71421584bc2a43951df908d90fefc1b9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637558344708605379%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=fJG0%2Fdk8VCVNIGS0kM2BZDHAXLVcq4CLHEajhND0rzg%3D&reserved=0
next prev parent reply other threads:[~2021-05-05 19:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 17:30 [PATCH] EDAC: update edac printk wrappers to use printk_ratelimited Lei Wang
2021-05-05 18:01 ` Borislav Petkov
2021-05-05 19:02 ` Lei Wang (DPLAT) [this message]
2021-05-05 19:45 ` [EXTERNAL] " Borislav Petkov
2021-05-05 20:23 ` Tyler Hicks
2021-05-05 21:04 ` Borislav Petkov
2021-05-05 21:48 ` Tyler Hicks
2021-05-05 22:02 ` Borislav Petkov
2021-05-05 22:16 ` Tyler Hicks
2021-05-05 22:43 ` Tyler Hicks
2021-05-05 22:55 ` Borislav Petkov
2021-05-05 23:01 ` Tyler Hicks
2021-05-05 23:13 ` Luck, Tony
2021-05-06 7:16 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR21MB199984A8B47FBEECEC5D11CE90599@SJ0PR21MB1999.namprd21.prod.outlook.com \
--to=wang.lei@microsoft.com \
--cc=bp@alien8.de \
--cc=bwaller@microsoft.com \
--cc=hangl@microsoft.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=tyhicks@linux.microsoft.com \
--cc=wangglei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).