From: Borislav Petkov <bp@alien8.de>
To: Tyler Hicks <tyhicks@linux.microsoft.com>
Cc: wangglei <wangglei@gmail.com>,
"Lei Wang (DPLAT)" <Wang.Lei@microsoft.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"rric@kernel.org" <rric@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hang Li <hangl@microsoft.com>,
Brandon Waller <bwaller@microsoft.com>
Subject: Re: [EXTERNAL] Re: [PATCH] EDAC: update edac printk wrappers to use printk_ratelimited.
Date: Wed, 5 May 2021 23:04:44 +0200 [thread overview]
Message-ID: <YJMIbB31oEDaXm0C@zn.tnic> (raw)
In-Reply-To: <20210505202357.GC4967@sequoia>
On Wed, May 05, 2021 at 03:23:57PM -0500, Tyler Hicks wrote:
> Would it be any more acceptable to add an
> edac_mc_printk_ratelimited() macro, which uses printk_ratelimited(),
> and then call that new macro from edac_ce_error()?
You guys are way off here: the intent of EDAC drivers is to accurately
report errors for purposes of counting them and doing analysis on
that collected data as to whether components are going wrong - not to
ratelimit them as some nuisance output.
With breaking the EDAC reporting, you're barking up the wrong tree - if
you don't want to see those errors, do not load the drivers. It is that
simple.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-05-05 21:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 17:30 [PATCH] EDAC: update edac printk wrappers to use printk_ratelimited Lei Wang
2021-05-05 18:01 ` Borislav Petkov
2021-05-05 19:02 ` [EXTERNAL] " Lei Wang (DPLAT)
2021-05-05 19:45 ` Borislav Petkov
2021-05-05 20:23 ` Tyler Hicks
2021-05-05 21:04 ` Borislav Petkov [this message]
2021-05-05 21:48 ` Tyler Hicks
2021-05-05 22:02 ` Borislav Petkov
2021-05-05 22:16 ` Tyler Hicks
2021-05-05 22:43 ` Tyler Hicks
2021-05-05 22:55 ` Borislav Petkov
2021-05-05 23:01 ` Tyler Hicks
2021-05-05 23:13 ` Luck, Tony
2021-05-06 7:16 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJMIbB31oEDaXm0C@zn.tnic \
--to=bp@alien8.de \
--cc=Wang.Lei@microsoft.com \
--cc=bwaller@microsoft.com \
--cc=hangl@microsoft.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=tyhicks@linux.microsoft.com \
--cc=wangglei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).