From: Borislav Petkov <bp@alien8.de>
To: "Lei Wang (DPLAT)" <Wang.Lei@microsoft.com>
Cc: wangglei <wangglei@gmail.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"rric@kernel.org" <rric@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hang Li <hangl@microsoft.com>,
"tyhicks@linux.microsoft.com" <tyhicks@linux.microsoft.com>,
Brandon Waller <bwaller@microsoft.com>
Subject: Re: [EXTERNAL] Re: [PATCH] EDAC: update edac printk wrappers to use printk_ratelimited.
Date: Wed, 5 May 2021 21:45:01 +0200 [thread overview]
Message-ID: <YJL1vU6HNBWPKy8g@zn.tnic> (raw)
In-Reply-To: <SJ0PR21MB199984A8B47FBEECEC5D11CE90599@SJ0PR21MB1999.namprd21.prod.outlook.com>
Hi Lei,
On Wed, May 05, 2021 at 07:02:14PM +0000, Lei Wang (DPLAT) wrote:
> Hi Boris,
first of all, please do not top-post.
> We found a corner case in production environment that there are ~500
> CE errors per second. The SoC otherwise functions just fine. Making
> printk ratelimited reduced CE error logging to < 20 per second.
If you want to avoid CE logs flooding dmesg, there's a couple of things
you can do:
1. Use drivers/ras/cec.c
2. Do not load EDAC drivers at all since you don't care about the error
reports, apparently.
3. Fix the CE source: replace the DIMMs, etc.
> Though this is just one case so far, we think moving to
> printk_ratelimited could benefit broader use as well, by helping
> control the amount of kernel logging.
No, this will make EDAC driver loading output incomplete when some of
the messages are omitted due to the ratelimiting. And no, this is not
going to happen.
HTH.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-05-05 19:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 17:30 [PATCH] EDAC: update edac printk wrappers to use printk_ratelimited Lei Wang
2021-05-05 18:01 ` Borislav Petkov
2021-05-05 19:02 ` [EXTERNAL] " Lei Wang (DPLAT)
2021-05-05 19:45 ` Borislav Petkov [this message]
2021-05-05 20:23 ` Tyler Hicks
2021-05-05 21:04 ` Borislav Petkov
2021-05-05 21:48 ` Tyler Hicks
2021-05-05 22:02 ` Borislav Petkov
2021-05-05 22:16 ` Tyler Hicks
2021-05-05 22:43 ` Tyler Hicks
2021-05-05 22:55 ` Borislav Petkov
2021-05-05 23:01 ` Tyler Hicks
2021-05-05 23:13 ` Luck, Tony
2021-05-06 7:16 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJL1vU6HNBWPKy8g@zn.tnic \
--to=bp@alien8.de \
--cc=Wang.Lei@microsoft.com \
--cc=bwaller@microsoft.com \
--cc=hangl@microsoft.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=tyhicks@linux.microsoft.com \
--cc=wangglei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).