From: "Luck, Tony" <tony.luck@intel.com>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
Kees Cook <keescook@chromium.org>,
Matt Fleming <matt@codeblueprint.co.uk>,
"Gao, Liming" <liming.gao@intel.com>,
linux-efi <linux-efi@vger.kernel.org>
Subject: Re: [PATCH v6 0/2] Add capsule-pstore backend support
Date: Fri, 20 Mar 2020 12:25:27 -0700 [thread overview]
Message-ID: <20200320192527.GA31764@agluck-desk2.amr.corp.intel.com> (raw)
In-Reply-To: <abd0a0d1095f4bc4a8fc2be420a2478a@intel.com>
On Thu, Mar 19, 2020 at 01:53:38AM -0700, Zhuo, Qiuxu wrote:
> > From: linux-efi-owner@vger.kernel.org <linux-efi-owner@vger.kernel.org> On> Behalf Of Ard Biesheuvel
> > ...
> > > The following commit on the tip tree removes the variables 'config_table' from the efi structure.
> > >
> > > 9cd437ac0ef4 ("efi/x86: Make fw_vendor, config_table and runtime sysfs nodes x86 specific")
> > >
> > > But the external driver "capsule-pstore.ko" needs to access 'config_table' and 'nr_tables' to go through the configuration table to extract crash capsules.
> > >
> > > Adding 'config_table' and 'nr_tables' back to the efi structure looks like not a good way.
> > > Do you have any suggestion on how to export 'config_table' and 'nr_tables' variables for the external driver "capsule-pstore.ko"?
> > >
> >
> > I will get back to you on monday about this. In any case, this will have to wait until v5.8
>
> OK. Thanks!
Would it be acceptable to take the first half of Qiuxu's
function efi_capsule_table_get() and move it into the
generic efi code naming it something like: "efi_get_table_by_guid()"?
Then EXPORT_GPL that function?
-Tony
next prev parent reply other threads:[~2020-03-20 19:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 1:13 [PATCH v6 0/2] Add capsule-pstore backend support Qiuxu Zhuo
2020-03-15 13:56 ` Ard Biesheuvel
2020-03-15 14:45 ` Zhuo, Qiuxu
2020-03-16 5:32 ` Zhuo, Qiuxu
2020-03-18 20:19 ` Ard Biesheuvel
2020-03-19 8:53 ` Zhuo, Qiuxu
2020-03-20 19:25 ` Luck, Tony [this message]
2020-03-25 15:52 ` Ard Biesheuvel
2020-03-25 17:33 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320192527.GA31764@agluck-desk2.amr.corp.intel.com \
--to=tony.luck@intel.com \
--cc=ardb@kernel.org \
--cc=keescook@chromium.org \
--cc=liming.gao@intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=qiuxu.zhuo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).