linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
	"Luck, Tony" <tony.luck@intel.com>,
	Matt Fleming <matt@codeblueprint.co.uk>,
	"Gao, Liming" <liming.gao@intel.com>,
	linux-efi <linux-efi@vger.kernel.org>
Subject: RE: [PATCH v6 0/2] Add capsule-pstore backend support
Date: Mon, 16 Mar 2020 05:32:41 +0000	[thread overview]
Message-ID: <d0a09900ca0341029980d351bbe2aecc@intel.com> (raw)
In-Reply-To: <CAKv+Gu9BvqZavV6XjfuacXXpabNCXLYEw-f=81fwX8hdL6Fn-A@mail.gmail.com>

> From: linux-efi-owner@vger.kernel.org <linux-efi-owner@vger.kernel.org> On
>...
> On Wed, 11 Mar 2020 at 21:12, Qiuxu Zhuo <qiuxu.zhuo@intel.com> wrote:
> >
> > Change Log v5->v6:
> >   Part1: No changes.
> >   Part2: Update capsule-pstore.c file header.
> >          Move the variable 'efi_capsule_pstore_info' backward (for removing
> some function declarations).
> >
> 
> This conflicts badly with the efi/core changes queued up in the tip tree (and hence linux-next) Please rebase and repost

Hi Ard,

The following commit on the tip tree removes the variables 'config_table' from the efi structure.

    9cd437ac0ef4 ("efi/x86: Make fw_vendor, config_table and runtime sysfs nodes x86 specific")

But the external driver "capsule-pstore.ko" needs to access 'config_table' and 'nr_tables' to go through
the configuration table to extract crash capsules.

Adding 'config_table' and 'nr_tables' back to the efi structure looks like not a good way. 
Do you have any  suggestion on how to export 'config_table' and 'nr_tables' variables for the external driver "capsule-pstore.ko"?

Thanks!
-Qiuxu




  parent reply	other threads:[~2020-03-16  5:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12  1:13 [PATCH v6 0/2] Add capsule-pstore backend support Qiuxu Zhuo
2020-03-15 13:56 ` Ard Biesheuvel
2020-03-15 14:45   ` Zhuo, Qiuxu
2020-03-16  5:32   ` Zhuo, Qiuxu [this message]
2020-03-18 20:19     ` Ard Biesheuvel
2020-03-19  8:53       ` Zhuo, Qiuxu
2020-03-20 19:25         ` Luck, Tony
2020-03-25 15:52           ` Ard Biesheuvel
2020-03-25 17:33             ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0a09900ca0341029980d351bbe2aecc@intel.com \
    --to=qiuxu.zhuo@intel.com \
    --cc=ardb@kernel.org \
    --cc=keescook@chromium.org \
    --cc=liming.gao@intel.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).