linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Increasing EFI_MMAP_NR_SLACK_SLOTS
@ 2021-09-02 22:26 Víctor Gonzalo
  2022-04-13 17:38 ` Ard Biesheuvel
  0 siblings, 1 reply; 2+ messages in thread
From: Víctor Gonzalo @ 2021-09-02 22:26 UTC (permalink / raw)
  To: linux-efi

Hello

I had an issue in a big server in which no linux distro I tried was
able to boot. It failed with the messages:

EFI stub: ERROR: exit_boot() failed!
EFI stub: ERROR: efi_main() failed!

Digging through the rabbit hole I reached the error in the call to
efi_bs_call(get_memory_map) inside efi_exit_boot_services() in
efi-stub-helper.c which returned EFI_BUFFER_TOO_SMALL, so everything
collapsed after that.

It looks like despite what the comment suggests, the headroom was not enough.
I fixed it by increasing the value of EFI_MMAP_NR_SLACK_SLOTS to 16.

Is this the right approach to fix the issue?
Would it be ok to change the value in the mainline?

Thanks
- Víctor

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Increasing EFI_MMAP_NR_SLACK_SLOTS
  2021-09-02 22:26 Increasing EFI_MMAP_NR_SLACK_SLOTS Víctor Gonzalo
@ 2022-04-13 17:38 ` Ard Biesheuvel
  0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2022-04-13 17:38 UTC (permalink / raw)
  To: Víctor Gonzalo; +Cc: linux-efi

On Fri, 3 Sept 2021 at 00:26, Víctor Gonzalo
<victor.gonzalo@anddroptable.net> wrote:
>
> Hello
>
> I had an issue in a big server in which no linux distro I tried was
> able to boot. It failed with the messages:
>
> EFI stub: ERROR: exit_boot() failed!
> EFI stub: ERROR: efi_main() failed!
>
> Digging through the rabbit hole I reached the error in the call to
> efi_bs_call(get_memory_map) inside efi_exit_boot_services() in
> efi-stub-helper.c which returned EFI_BUFFER_TOO_SMALL, so everything
> collapsed after that.
>
> It looks like despite what the comment suggests, the headroom was not enough.
> I fixed it by increasing the value of EFI_MMAP_NR_SLACK_SLOTS to 16.
>
> Is this the right approach to fix the issue?
> Would it be ok to change the value in the mainline?
>

I don't think changing that would be a problem. Patches welcome.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-13 17:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-02 22:26 Increasing EFI_MMAP_NR_SLACK_SLOTS Víctor Gonzalo
2022-04-13 17:38 ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).