From: Jonathon Fernyhough <jonathon@m2x.dev>
To: Ard Biesheuvel <ardb@kernel.org>,
Oleksandr Natalenko <oleksandr@natalenko.name>
Cc: linux-efi <linux-efi@vger.kernel.org>,
Jeremy Kerr <jk@ozlabs.org>, Matthew Garrett <mjg59@google.com>,
David Laight <David.Laight@aculab.com>,
Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com>
Subject: Re: [PATCH] efivarfs: revert "fix memory leak in efivarfs_create()"
Date: Fri, 27 Nov 2020 16:50:34 +0000 [thread overview]
Message-ID: <a07e1520-f08b-2456-a954-707e0c3bcb4a@m2x.dev> (raw)
In-Reply-To: <CAMj1kXHHW2MSUb1emSnDPqffBVFinAO2=w5Si3toEvqXZUBY2Q@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 861 bytes --]
On 25/11/2020 10:28, Ard Biesheuvel wrote:
> On Wed, 25 Nov 2020 at 11:27, Oleksandr Natalenko
> <oleksandr@natalenko.name> wrote:
>>
>> On 25.11.2020 08:53, Ard Biesheuvel wrote:
--snip--
>>
>> Do we need to do this as well:
>>
>> #include <linux/kmemleak.h>
>>
>> ?
>>
>> Because otherwise for 5.9 I get:
>>
>> [ 148s] fs/efivarfs/inode.c: In function 'efivarfs_create':
>> [ 148s] fs/efivarfs/inode.c:106:2: error: implicit declaration of
>> function 'kmemleak_ignore' [-Werror=implicit-function-declaration]
>> [ 148s] 106 | kmemleak_ignore(var);
>> [ 148s] | ^~~~~~~~~~~~~~~
>>
>
> Ah yes, thanks for the report. I will add the include to the patch.
>
>
Is this necessary if CONFIG_DEBUG_KMEMLEAK is not enabled in the kernel
config? e.g. should there be an #ifdef CONFIG_DEBUG_KMEMLEAK somewhere
in there?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2020-11-27 16:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 7:53 [PATCH] efivarfs: revert "fix memory leak in efivarfs_create()" Ard Biesheuvel
2020-11-25 8:05 ` Oleksandr Natalenko
2020-11-25 8:05 ` Ard Biesheuvel
2020-11-25 8:25 ` Greg Kroah-Hartman
2020-11-25 10:27 ` Oleksandr Natalenko
2020-11-25 10:28 ` Ard Biesheuvel
2020-11-27 16:50 ` Jonathon Fernyhough [this message]
2020-11-27 16:58 ` Ard Biesheuvel
2020-11-27 16:59 ` Oleksandr Natalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a07e1520-f08b-2456-a954-707e0c3bcb4a@m2x.dev \
--to=jonathon@m2x.dev \
--cc=David.Laight@aculab.com \
--cc=ardb@kernel.org \
--cc=jk@ozlabs.org \
--cc=linux-efi@vger.kernel.org \
--cc=mjg59@google.com \
--cc=oleksandr@natalenko.name \
--cc=vamshi.k.sthambamkadi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).