* [PATCH] erofs-utils: fix configure.ac
@ 2019-11-22 8:58 Haruue Icymoon
2019-11-22 9:35 ` Gao Xiang
0 siblings, 1 reply; 2+ messages in thread
From: Haruue Icymoon @ 2019-11-22 8:58 UTC (permalink / raw)
To: linux-erofs
./configure will fail when --with-lz4-libdir is not set, since
$with_lz4_libdir will be an empty string and generate an empty -L
into LDFLAGS. This patch fixes it.
Signed-off-by: Haruue Icymoon <i@haruue.moe>
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index f925358..870dfb9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -174,7 +174,7 @@ if test "x$enable_lz4" = "xyes"; then
if test "x${have_lz4h}" = "xyes" ; then
saved_LDFLAGS=${LDFLAGS}
- LDFLAGS="-L$with_lz4_libdir ${LDFLAGS}"
+ test -z "${with_lz4_libdir}" || LDFLAGS="-L$with_lz4_libdir ${LDFLAGS}"
AC_CHECK_LIB(lz4, LZ4_compress_destSize, [
have_lz4="yes"
have_lz4hc="yes"
--
2.24.0
--
Haruue Icymoon
GPG: E16D 3FA4 E636 A602 2684 0D38 A54A 7E9C 812E EB09
https://haruue.moe/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] erofs-utils: fix configure.ac
2019-11-22 8:58 [PATCH] erofs-utils: fix configure.ac Haruue Icymoon
@ 2019-11-22 9:35 ` Gao Xiang
0 siblings, 0 replies; 2+ messages in thread
From: Gao Xiang @ 2019-11-22 9:35 UTC (permalink / raw)
To: Haruue Icymoon; +Cc: linux-erofs
Hi Haruue,
On Fri, Nov 22, 2019 at 04:58:59PM +0800, Haruue Icymoon wrote:
> ./configure will fail when --with-lz4-libdir is not set, since
> $with_lz4_libdir will be an empty string and generate an empty -L
> into LDFLAGS. This patch fixes it.
>
> Signed-off-by: Haruue Icymoon <i@haruue.moe>
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index f925358..870dfb9 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -174,7 +174,7 @@ if test "x$enable_lz4" = "xyes"; then
>
> if test "x${have_lz4h}" = "xyes" ; then
> saved_LDFLAGS=${LDFLAGS}
> - LDFLAGS="-L$with_lz4_libdir ${LDFLAGS}"
> + test -z "${with_lz4_libdir}" || LDFLAGS="-L$with_lz4_libdir ${LDFLAGS}"
> AC_CHECK_LIB(lz4, LZ4_compress_destSize, [
> have_lz4="yes"
> have_lz4hc="yes"
> --
> 2.24.0
Thanks for your patch. *thumb*
Applied to experimental branch now, and I will move it to dev branch
tomorrow since it's a useful trivial build fix for some debian builds
as well [1].
[1] https://buildd.debian.org/status/package.php?p=erofs-utils
https://buildd.debian.org/status/fetch.php?pkg=erofs-utils&arch=hppa&ver=1.0-3&stamp=1573917897&raw=0
Thanks,
Gao Xiang
>
>
> --
> Haruue Icymoon
> GPG: E16D 3FA4 E636 A602 2684 0D38 A54A 7E9C 812E EB09
> https://haruue.moe/
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-22 9:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-22 8:58 [PATCH] erofs-utils: fix configure.ac Haruue Icymoon
2019-11-22 9:35 ` Gao Xiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).