* [PATCH] erofs: remove unnecessary output in erofs_show_options()
@ 2019-11-19 11:50 Chengguang Xu
2019-11-19 13:02 ` Gao Xiang
2019-11-21 1:13 ` Chao Yu
0 siblings, 2 replies; 3+ messages in thread
From: Chengguang Xu @ 2019-11-19 11:50 UTC (permalink / raw)
To: xiang, chao; +Cc: Chengguang Xu, linux-erofs
We have already handled cache_strategy option carefully,
so incorrect setting could not pass option parsing.
Meanwhile, print 'cache_strategy=(unknown)' can cause
failure on remount.
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
fs/erofs/super.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 06e721bd1c8c..65c7da996643 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -581,9 +581,6 @@ static int erofs_show_options(struct seq_file *seq, struct dentry *root)
seq_puts(seq, ",cache_strategy=readahead");
} else if (sbi->cache_strategy == EROFS_ZIP_CACHE_READAROUND) {
seq_puts(seq, ",cache_strategy=readaround");
- } else {
- seq_puts(seq, ",cache_strategy=(unknown)");
- DBG_BUGON(1);
}
#endif
return 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] erofs: remove unnecessary output in erofs_show_options()
2019-11-19 11:50 [PATCH] erofs: remove unnecessary output in erofs_show_options() Chengguang Xu
@ 2019-11-19 13:02 ` Gao Xiang
2019-11-21 1:13 ` Chao Yu
1 sibling, 0 replies; 3+ messages in thread
From: Gao Xiang @ 2019-11-19 13:02 UTC (permalink / raw)
To: Chengguang Xu; +Cc: miaoxie, xiang, linux-erofs
On Tue, Nov 19, 2019 at 07:50:49PM +0800, Chengguang Xu wrote:
> We have already handled cache_strategy option carefully,
> so incorrect setting could not pass option parsing.
> Meanwhile, print 'cache_strategy=(unknown)' can cause
> failure on remount.
>
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] erofs: remove unnecessary output in erofs_show_options()
2019-11-19 11:50 [PATCH] erofs: remove unnecessary output in erofs_show_options() Chengguang Xu
2019-11-19 13:02 ` Gao Xiang
@ 2019-11-21 1:13 ` Chao Yu
1 sibling, 0 replies; 3+ messages in thread
From: Chao Yu @ 2019-11-21 1:13 UTC (permalink / raw)
To: Chengguang Xu, xiang, chao; +Cc: linux-erofs
On 2019/11/19 19:50, Chengguang Xu wrote:
> We have already handled cache_strategy option carefully,
> so incorrect setting could not pass option parsing.
> Meanwhile, print 'cache_strategy=(unknown)' can cause
> failure on remount.
>
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-21 1:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19 11:50 [PATCH] erofs: remove unnecessary output in erofs_show_options() Chengguang Xu
2019-11-19 13:02 ` Gao Xiang
2019-11-21 1:13 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).