* [PATCH] ext4: add comment for ext4_dir_entry_2 file_type member
@ 2020-05-22 15:09 Jonny Grant
2020-05-23 5:12 ` Andreas Dilger
0 siblings, 1 reply; 3+ messages in thread
From: Jonny Grant @ 2020-05-22 15:09 UTC (permalink / raw)
To: Ext4 Developers List; +Cc: Andreas Dilger
From 4e9d768a0adb60698ba13e7b7522c15a4548332a Mon Sep 17 00:00:00 2001
From: Jonathan Grant <jg@jguk.org>
Date: Fri, 22 May 2020 16:07:58 +0100
Subject: [PATCH] add comment for ext4_dir_entry_2 file_type member
Signed-off-by: Jonathan Grant <jg@jguk.org>
---
fs/ext4/ext4.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index ad2dbf6e4924..7a042896bab7 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -2050,7 +2050,7 @@ struct ext4_dir_entry_2 {
__le32 inode; /* Inode number */
__le16 rec_len; /* Directory entry length */
__u8 name_len; /* Name length */
- __u8 file_type;
+ __u8 file_type; /* See file type macros EXT4_FT_* below */
char name[EXT4_NAME_LEN]; /* File name */
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: add comment for ext4_dir_entry_2 file_type member
2020-05-22 15:09 [PATCH] ext4: add comment for ext4_dir_entry_2 file_type member Jonny Grant
@ 2020-05-23 5:12 ` Andreas Dilger
2020-05-29 3:10 ` Theodore Y. Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Dilger @ 2020-05-23 5:12 UTC (permalink / raw)
To: Jonny Grant; +Cc: Ext4 Developers List
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
On May 22, 2020, at 9:09 AM, Jonny Grant <jg@jguk.org> wrote:
>
> From 4e9d768a0adb60698ba13e7b7522c15a4548332a Mon Sep 17 00:00:00 2001
> From: Jonathan Grant <jg@jguk.org>
> Date: Fri, 22 May 2020 16:07:58 +0100
> Subject: [PATCH] add comment for ext4_dir_entry_2 file_type member
>
> Signed-off-by: Jonathan Grant <jg@jguk.org>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> ---
> fs/ext4/ext4.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index ad2dbf6e4924..7a042896bab7 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -2050,7 +2050,7 @@ struct ext4_dir_entry_2 {
> __le32 inode; /* Inode number */
> __le16 rec_len; /* Directory entry length */
> __u8 name_len; /* Name length */
> - __u8 file_type;
> + __u8 file_type; /* See file type macros EXT4_FT_* below */
> char name[EXT4_NAME_LEN]; /* File name */
> };
>
> --
> 2.17.1
>
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: add comment for ext4_dir_entry_2 file_type member
2020-05-23 5:12 ` Andreas Dilger
@ 2020-05-29 3:10 ` Theodore Y. Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Y. Ts'o @ 2020-05-29 3:10 UTC (permalink / raw)
To: Andreas Dilger; +Cc: Jonny Grant, Ext4 Developers List
On Fri, May 22, 2020 at 11:12:41PM -0600, Andreas Dilger wrote:
> On May 22, 2020, at 9:09 AM, Jonny Grant <jg@jguk.org> wrote:
> >
> > From 4e9d768a0adb60698ba13e7b7522c15a4548332a Mon Sep 17 00:00:00 2001
> > From: Jonathan Grant <jg@jguk.org>
> > Date: Fri, 22 May 2020 16:07:58 +0100
> > Subject: [PATCH] add comment for ext4_dir_entry_2 file_type member
> >
> > Signed-off-by: Jonathan Grant <jg@jguk.org>
>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-29 3:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22 15:09 [PATCH] ext4: add comment for ext4_dir_entry_2 file_type member Jonny Grant
2020-05-23 5:12 ` Andreas Dilger
2020-05-29 3:10 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).