[Resend PATCH] ext2: set proper errno in error case of ext2_fill_super()

[Resend PATCH] ext2: set proper errno in error case of ext2_fill_super()

[Chengguang Xu]

Set proper errno in the case of failure of
initializing percpu variables.

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
Forgot to cc ext4 maillist, so resend it.

 fs/ext2/super.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 30c630d73f0f..74a9e3e71c13 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -1147,6 +1147,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
 				ext2_count_dirs(sb), GFP_KERNEL);
 	}
 	if (err) {
+		ret = err;
 		ext2_msg(sb, KERN_ERR, "error: insufficient memory");
 		goto failed_mount3;
 	}
-- 
2.20.1

Re: [Resend PATCH] ext2: set proper errno in error case of ext2_fill_super()

[Jan Kara]

On Fri 29-11-19 09:36:36, Chengguang Xu wrote:
> Set proper errno in the case of failure of
> initializing percpu variables.
> 
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>

Thanks. I've added the patch to my tree.

								Honza

> ---
> Forgot to cc ext4 maillist, so resend it.
> 
>  fs/ext2/super.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 30c630d73f0f..74a9e3e71c13 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -1147,6 +1147,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
>  				ext2_count_dirs(sb), GFP_KERNEL);
>  	}
>  	if (err) {
> +		ret = err;
>  		ext2_msg(sb, KERN_ERR, "error: insufficient memory");
>  		goto failed_mount3;
>  	}
> -- 
> 2.20.1
> 
> 
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR