* [PATCH] jbd2: fix kernel-doc notation warning
@ 2019-12-09 4:31 Randy Dunlap
2019-12-10 9:16 ` Jan Kara
2019-12-16 2:45 ` Theodore Y. Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2019-12-09 4:31 UTC (permalink / raw)
To: Linux FS Devel, linux-ext4, Theodore Ts'o; +Cc: Jan Kara
From: Randy Dunlap <rdunlap@infradead.org>
Fix kernel-doc warning by inserting a beginning '*' character
for the kernel-doc line.
../include/linux/jbd2.h:461: warning: bad line: journal. These are dirty buffers and revoke descriptor blocks.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Jan Kara <jack@suse.com>
Cc: linux-ext4@vger.kernel.org
---
include/linux/jbd2.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20191209.orig/include/linux/jbd2.h
+++ linux-next-20191209/include/linux/jbd2.h
@@ -457,7 +457,7 @@ struct jbd2_revoke_table_s;
* @h_journal: Which journal handle belongs to - used iff h_reserved set.
* @h_rsv_handle: Handle reserved for finishing the logical operation.
* @h_total_credits: Number of remaining buffers we are allowed to add to
- journal. These are dirty buffers and revoke descriptor blocks.
+ * journal. These are dirty buffers and revoke descriptor blocks.
* @h_revoke_credits: Number of remaining revoke records available for handle
* @h_ref: Reference count on this handle.
* @h_err: Field for caller's use to track errors through large fs operations.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] jbd2: fix kernel-doc notation warning
2019-12-09 4:31 [PATCH] jbd2: fix kernel-doc notation warning Randy Dunlap
@ 2019-12-10 9:16 ` Jan Kara
2019-12-16 2:45 ` Theodore Y. Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2019-12-10 9:16 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Linux FS Devel, linux-ext4, Theodore Ts'o, Jan Kara
On Sun 08-12-19 20:31:32, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kernel-doc warning by inserting a beginning '*' character
> for the kernel-doc line.
>
> ../include/linux/jbd2.h:461: warning: bad line: journal. These are dirty buffers and revoke descriptor blocks.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Jan Kara <jack@suse.com>
> Cc: linux-ext4@vger.kernel.org
Looks good to me. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> include/linux/jbd2.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20191209.orig/include/linux/jbd2.h
> +++ linux-next-20191209/include/linux/jbd2.h
> @@ -457,7 +457,7 @@ struct jbd2_revoke_table_s;
> * @h_journal: Which journal handle belongs to - used iff h_reserved set.
> * @h_rsv_handle: Handle reserved for finishing the logical operation.
> * @h_total_credits: Number of remaining buffers we are allowed to add to
> - journal. These are dirty buffers and revoke descriptor blocks.
> + * journal. These are dirty buffers and revoke descriptor blocks.
> * @h_revoke_credits: Number of remaining revoke records available for handle
> * @h_ref: Reference count on this handle.
> * @h_err: Field for caller's use to track errors through large fs operations.
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] jbd2: fix kernel-doc notation warning
2019-12-09 4:31 [PATCH] jbd2: fix kernel-doc notation warning Randy Dunlap
2019-12-10 9:16 ` Jan Kara
@ 2019-12-16 2:45 ` Theodore Y. Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Y. Ts'o @ 2019-12-16 2:45 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Linux FS Devel, linux-ext4, Jan Kara
On Sun, Dec 08, 2019 at 08:31:32PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kernel-doc warning by inserting a beginning '*' character
> for the kernel-doc line.
>
> ../include/linux/jbd2.h:461: warning: bad line: journal. These are dirty buffers and revoke descriptor blocks.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-16 2:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 4:31 [PATCH] jbd2: fix kernel-doc notation warning Randy Dunlap
2019-12-10 9:16 ` Jan Kara
2019-12-16 2:45 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).