[PATCH] /fs/ext4/ext4.h add a comment to ext4_dir_entry_2

[PATCH] /fs/ext4/ext4.h add a comment to ext4_dir_entry_2

[Jonny Grant]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

Please find attached patch for review.

2020-05-08  Jonny Grant  <jg@jguk.org>

	tests: comment ext4_dir_entry_2 file_type member

Cheers, Jonny

[-- Attachment #2: ext4_ext4_dir_entry_2.patch --]
[-- Type: text/x-patch, Size: 425 bytes --]

--- linux/fs/ext4/ext4.h	2020-05-08 21:29:06.854506000 +0100
+++ linux/fs/ext4/ext4.h.new	2020-05-08 21:32:46.651631273 +0100
@@ -2050,7 +2050,7 @@ struct ext4_dir_entry_2 {
 	__le32	inode;			/* Inode number */
 	__le16	rec_len;		/* Directory entry length */
 	__u8	name_len;		/* Name length */
-	__u8	file_type;
+	__u8	file_type;		/* See file type macros EXT4_FT_* below */
 	char	name[EXT4_NAME_LEN];	/* File name */
 };
 

Re: [PATCH] /fs/ext4/ext4.h add a comment to ext4_dir_entry_2

[Andreas Dilger]

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

On May 8, 2020, at 2:36 PM, Jonny Grant <jg@jguk.org> wrote:
> 
> Please find attached patch for review.
> 
> 2020-05-08  Jonny Grant  <jg@jguk.org>
> 
> 	tests: comment ext4_dir_entry_2 file_type member
> 
> Cheers, Jonny
> <ext4_ext4_dir_entry_2.patch>

Hi Jonny,
thanks for your patch.  The patch itself looks reasonable, but can
you please submit it as inline text next time.  To avoid issues with
whitespace formatting, you can use "git send-email" directly from
the command-line after making a commit with this change in it.

Also, the subject line of the patch should just have "ext4:" as the
subsystem, you don't need the whole pathname for the file, like:

    ext4: add comment for ext4_dir_entry_2 file_type member

Finally, you should add a line:

    Signed-off-by: Jonny Grant <jg@jguk.org>

to indicate that you wrote the patch and you are OK with others using it.

See Documentation/process/submitting-patches.rst for full details.

Cheers, Andreas






[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]

Re: [PATCH] /fs/ext4/ext4.h add a comment to ext4_dir_entry_2

[Jonny Grant]

On 11/05/2020 21:19, Andreas Dilger wrote:
> On May 8, 2020, at 2:36 PM, Jonny Grant <jg@jguk.org> wrote:
>>
>> Please find attached patch for review.
>>
>> 2020-05-08  Jonny Grant  <jg@jguk.org>
>>
>> 	tests: comment ext4_dir_entry_2 file_type member
>>
>> Cheers, Jonny
>> <ext4_ext4_dir_entry_2.patch>
> 
> Hi Jonny,
> thanks for your patch.  The patch itself looks reasonable, but can
> you please submit it as inline text next time.  To avoid issues with
> whitespace formatting, you can use "git send-email" directly from
> the command-line after making a commit with this change in it.
> 
> Also, the subject line of the patch should just have "ext4:" as the
> subsystem, you don't need the whole pathname for the file, like:
> 
>      ext4: add comment for ext4_dir_entry_2 file_type member
> 
> Finally, you should add a line:
> 
>      Signed-off-by: Jonny Grant <jg@jguk.org>
> 
> to indicate that you wrote the patch and you are OK with others using it.
> 
> See Documentation/process/submitting-patches.rst for full details.
> 
> Cheers, Andreas


Many thanks for your reply Andreas. I will follow your that patch guide, 
thank you for the link.

Could I check, did you submit, or shall I submit via git send-email ?


Many thanks
Jonny

Re: [PATCH] /fs/ext4/ext4.h add a comment to ext4_dir_entry_2

[Andreas Dilger]

[-- Attachment #1: Type: text/plain, Size: 1418 bytes --]

On May 17, 2020, at 4:39 PM, Jonny Grant <jg@jguk.org> wrote:
> 
> 
> 
> On 11/05/2020 21:19, Andreas Dilger wrote:
>> On May 8, 2020, at 2:36 PM, Jonny Grant <jg@jguk.org> wrote:
>>> 
>>> Please find attached patch for review.
>>> 
>>> 2020-05-08  Jonny Grant  <jg@jguk.org>
>>> 
>>> 	tests: comment ext4_dir_entry_2 file_type member
>>> 
>>> Cheers, Jonny
>>> 
>> Hi Jonny,
>> thanks for your patch.  The patch itself looks reasonable, but can
>> you please submit it as inline text next time.  To avoid issues with
>> whitespace formatting, you can use "git send-email" directly from
>> the command-line after making a commit with this change in it.
>> Also, the subject line of the patch should just have "ext4:" as the
>> subsystem, you don't need the whole pathname for the file, like:
>>     ext4: add comment for ext4_dir_entry_2 file_type member
>> Finally, you should add a line:
>>     Signed-off-by: Jonny Grant <jg@jguk.org>
>> to indicate that you wrote the patch and you are OK with others using it.
>> See Documentation/process/submitting-patches.rst for full details.
>> Cheers, Andreas
> 
> 
> Many thanks for your reply Andreas. I will follow your that patch guide, thank you for the link.
> 
> Could I check, did you submit, or shall I submit via git send-email ?

I didn't submit it.  Best if you do so with the appropriate changes.

Cheers, Andreas






[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]

Re: [PATCH] /fs/ext4/ext4.h add a comment to ext4_dir_entry_2

[Theodore Y. Ts'o]

On Fri, May 08, 2020 at 09:36:43PM +0100, Jonny Grant wrote:
> Please find attached patch for review.
> 
> 2020-05-08  Jonny Grant  <jg@jguk.org>
> 
> 	tests: comment ext4_dir_entry_2 file_type member
> 
> Cheers, Jonny

Hi Johnny, could you resubmit with the Signed-off-By: line?  That's
really important.  If you don't understand why, please read:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin       

Cheers,

						- Ted