Linux-ext4 Archive on lore.kernel.org
 help / color / Atom feed
From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: David Gow <davidgow@google.com>, Nico Pache <npache@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Brendan Higgins <brendanhiggins@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-ext4@vger.kernel.org, Networking <netdev@vger.kernel.org>,
	rafael@kernel.org, linux-m68k@lists.linux-m68k.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Theodore Ts'o <tytso@mit.edu>,
	mathew.j.martineau@linux.intel.com, davem@davemloft.net,
	Mark Brown <broonie@kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	mptcp@lists.linux.dev
Subject: Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard
Date: Thu, 15 Apr 2021 09:10:10 +0200
Message-ID: <b57a1cc8-4921-6ed5-adb8-0510d1918d28@tessares.net> (raw)
In-Reply-To: <CABVgOSm9Lfcu--iiFo=PNLCWCj4vkxqAqO0aZT9B2r3Kw5Fhaw@mail.gmail.com>

Hi David,

Thank you for your very clear reply!

On 15/04/2021 08:01, David Gow wrote:
> On Wed, Apr 14, 2021 at 5:25 PM Matthieu Baerts
> <matthieu.baerts@tessares.net> wrote:
>> Up to the KUnit maintainers to decide ;-)
> 
> To summarise my view: personally, I'd prefer things the way this patch
> works: have everything end in _KUNIT_TEST, even if that enables a
> couple of suites. The extra 'S' on the end isn't a huge problem if you
> have a good reason to particularly want to keep it, though: as long as
> you don't have something like _K_UNIT_VERIFICATION or something
> equally silly that'd break grepping for '_KUNIT_TEST', it's fine be
> me.

Indeed it makes sense: we don't need to split nor to have a meta-Kconfig 
entry. We can then remove the extra 'S' and update our tests suite:

Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>

I see that the whole series has been marked as "Not Applicable" on 
Netdev's patchwork:

https://patchwork.kernel.org/project/netdevbpf/patch/0fa191715b236766ad13c5f786d8daf92a9a0cf2.1618388989.git.npache@redhat.com/

Like patch 1/6, I can apply it in MPTCP tree and send it later to 
net-next with other patches.
Except if you guys prefer to apply it in KUnit tree and send it to 
linux-next?

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

  reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-14  8:58 [PATCH v2 0/6] kunit: Fix formatting of KUNIT tests to meet the standard Nico Pache
2021-04-14  8:58 ` [PATCH v2 1/6] kunit: ASoC: topology: adhear to KUNIT formatting standard Nico Pache
2021-04-14 14:20   ` Mark Brown
2021-04-14  8:58 ` [PATCH v2 2/6] kunit: software node: " Nico Pache
2021-04-14  8:58 ` [PATCH v2 3/6] kunit: ext4: " Nico Pache
2021-04-18 19:41   ` Theodore Ts'o
2021-04-14  8:58 ` [PATCH v2 4/6] kunit: lib: " Nico Pache
2021-04-14  8:58 ` [PATCH v2 5/6] kunit: mptcp: " Nico Pache
2021-04-14  9:25   ` Matthieu Baerts
2021-04-15  6:01     ` David Gow
2021-04-15  7:10       ` Matthieu Baerts [this message]
2021-04-17  4:24         ` David Gow
2021-04-17  8:02           ` Matthieu Baerts
2021-04-19  7:40           ` Geert Uytterhoeven
2021-04-14  8:58 ` [PATCH v2 6/6] m68k: update configs to match the proper KUNIT syntax Nico Pache
2021-04-14 16:06 ` (subset) [PATCH v2 0/6] kunit: Fix formatting of KUNIT tests to meet the standard Mark Brown
2021-04-18 19:39 ` Theodore Ts'o
2021-04-22 20:39   ` Nico Pache
2021-04-23  6:26     ` David Gow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b57a1cc8-4921-6ed5-adb8-0510d1918d28@tessares.net \
    --to=matthieu.baerts@tessares.net \
    --cc=brendanhiggins@google.com \
    --cc=broonie@kernel.org \
    --cc=davem@davemloft.net \
    --cc=davidgow@google.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=npache@redhat.com \
    --cc=rafael@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ext4 Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-ext4/0 linux-ext4/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-ext4 linux-ext4/ https://lore.kernel.org/linux-ext4 \
		linux-ext4@vger.kernel.org
	public-inbox-index linux-ext4

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ext4


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git