* [f2fs-dev] [PATCH] f2fs: remove duplicated code in sanity_check_area_boundary
@ 2020-09-18 0:31 Wang Xiaojun
2020-09-19 7:21 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Wang Xiaojun @ 2020-09-18 0:31 UTC (permalink / raw)
To: yuchao0, jaegeuk, linux-f2fs-devel
Use seg_end_blkaddr instead of "segment0_blkaddr + (segment_count <<
log_blocks_per_seg)".
Signed-off-by: Wang Xiaojun <wangxiaojun11@huawei.com>
---
fs/f2fs/super.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index dfa072fa8081..d9ec59d68f63 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2680,10 +2680,8 @@ static inline bool sanity_check_area_boundary(struct f2fs_sb_info *sbi,
}
if (main_end_blkaddr > seg_end_blkaddr) {
- f2fs_info(sbi, "Wrong MAIN_AREA boundary, start(%u) end(%u) block(%u)",
- main_blkaddr,
- segment0_blkaddr +
- (segment_count << log_blocks_per_seg),
+ f2fs_info(sbi, "Wrong MAIN_AREA boundary, start(%u) end(%llu) block(%u)",
+ main_blkaddr, seg_end_blkaddr,
segment_count_main << log_blocks_per_seg);
return true;
} else if (main_end_blkaddr < seg_end_blkaddr) {
@@ -2701,10 +2699,8 @@ static inline bool sanity_check_area_boundary(struct f2fs_sb_info *sbi,
err = __f2fs_commit_super(bh, NULL);
res = err ? "failed" : "done";
}
- f2fs_info(sbi, "Fix alignment : %s, start(%u) end(%u) block(%u)",
- res, main_blkaddr,
- segment0_blkaddr +
- (segment_count << log_blocks_per_seg),
+ f2fs_info(sbi, "Fix alignment : %s, start(%u) end(%llu) block(%u)",
+ res, main_blkaddr, seg_end_blkaddr,
segment_count_main << log_blocks_per_seg);
if (err)
return true;
--
2.25.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: remove duplicated code in sanity_check_area_boundary
2020-09-18 0:31 [f2fs-dev] [PATCH] f2fs: remove duplicated code in sanity_check_area_boundary Wang Xiaojun
@ 2020-09-19 7:21 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2020-09-19 7:21 UTC (permalink / raw)
To: Wang Xiaojun, jaegeuk, linux-f2fs-devel
On 2020/9/18 8:31, Wang Xiaojun wrote:
> Use seg_end_blkaddr instead of "segment0_blkaddr + (segment_count <<
> log_blocks_per_seg)".
>
> Signed-off-by: Wang Xiaojun <wangxiaojun11@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-19 7:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18 0:31 [f2fs-dev] [PATCH] f2fs: remove duplicated code in sanity_check_area_boundary Wang Xiaojun
2020-09-19 7:21 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).