[PATCH] fbdev/sh_mobile: Drop unused include

[PATCH] fbdev/sh_mobile: Drop unused include

[Linus Walleij]

The driver includes <linux/gpio.h> but doesn't use any symbols
from this file.

Cc: Magnus Damm <magnus.damm@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-renesas-soc@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/video/fbdev/sh_mobile_lcdcfb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c
index c1043420dbd3..027c74d7c010 100644
--- a/drivers/video/fbdev/sh_mobile_lcdcfb.c
+++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c
@@ -16,7 +16,6 @@
 #include <linux/dma-mapping.h>
 #include <linux/delay.h>
 #include <linux/fbcon.h>
-#include <linux/gpio.h>
 #include <linux/init.h>
 #include <linux/interrupt.h>
 #include <linux/ioctl.h>
-- 
2.26.2

Re: [PATCH] fbdev/sh_mobile: Drop unused include

[Geert Uytterhoeven]

On Fri, Oct 30, 2020 at 1:30 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> The driver includes <linux/gpio.h> but doesn't use any symbols
> from this file.
>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: linux-renesas-soc@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
on r8a77440/armadillo, where this is the last piece of non-DT support.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] fbdev/sh_mobile: Drop unused include

[Sam Ravnborg]

Hi Linus,

On Fri, Oct 30, 2020 at 01:28:50AM +0100, Linus Walleij wrote:
> The driver includes <linux/gpio.h> but doesn't use any symbols
> from this file.
> 
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: linux-renesas-soc@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Thanks, I went ahead and applied this to drm-misc-next.
And then I remembered you have commit right too :-(

	Sam

Re: [PATCH] fbdev/sh_mobile: Drop unused include

[Linus Walleij]

On Sun, Nov 1, 2020 at 10:36 AM Sam Ravnborg <sam@ravnborg.org> wrote:
> On Fri, Oct 30, 2020 at 01:28:50AM +0100, Linus Walleij wrote:
> > The driver includes <linux/gpio.h> but doesn't use any symbols
> > from this file.
> >
> > Cc: Magnus Damm <magnus.damm@gmail.com>
> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> > Cc: linux-renesas-soc@vger.kernel.org
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Thanks, I went ahead and applied this to drm-misc-next.
> And then I remembered you have commit right too :-(

Thanks! It is always better if someone else does it anyways!

Yours,
Linus Walleij