From: Russ Weight <russell.h.weight@intel.com>
To: mdf@kernel.org, linux-fpga@vger.kernel.org
Cc: trix@redhat.com, lgoncalv@redhat.com, yilun.xu@intel.com,
hao.wu@intel.com, matthew.gerlach@intel.com,
richard.gong@intel.com, Russ Weight <russell.h.weight@intel.com>
Subject: [PATCH v1 2/5] fpga: altera-pr-ip: Remove fpga_mgr_unregister() call
Date: Tue, 8 Jun 2021 17:49:22 -0700 [thread overview]
Message-ID: <20210609004925.238044-3-russell.h.weight@intel.com> (raw)
In-Reply-To: <20210609004925.238044-1-russell.h.weight@intel.com>
The altera-pr-ip driver uses the devm_fpga_mgr_register() call, so it is
unnecessary to call fpga_mgr_unregister(). Also, mgr is no longer stored
in the dev.driver_data, so remove the call to dev_get_drvdata().
alt_pr_unregister() is now an empty function, but is left intact because
it is an exported symbol.
Signed-off-by: Russ Weight <russell.h.weight@intel.com>
---
drivers/fpga/altera-pr-ip-core.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c
index 5b130c4d9882..c150a084e440 100644
--- a/drivers/fpga/altera-pr-ip-core.c
+++ b/drivers/fpga/altera-pr-ip-core.c
@@ -201,11 +201,7 @@ EXPORT_SYMBOL_GPL(alt_pr_register);
void alt_pr_unregister(struct device *dev)
{
- struct fpga_manager *mgr = dev_get_drvdata(dev);
-
dev_dbg(dev, "%s\n", __func__);
-
- fpga_mgr_unregister(mgr);
}
EXPORT_SYMBOL_GPL(alt_pr_unregister);
--
2.25.1
next prev parent reply other threads:[~2021-06-09 0:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 0:49 [PATCH v1 0/5] fpga: Populate dev_release functions Russ Weight
2021-06-09 0:49 ` [PATCH v1 1/5] fpga: mgr: Use standard dev_release for class driver Russ Weight
2021-06-09 15:28 ` Xu Yilun
2021-06-09 15:57 ` Russ Weight
2021-06-09 0:49 ` Russ Weight [this message]
2021-06-09 15:37 ` [PATCH v1 2/5] fpga: altera-pr-ip: Remove fpga_mgr_unregister() call Xu Yilun
2021-06-09 16:25 ` Russ Weight
2021-06-09 16:45 ` Moritz Fischer
2021-06-09 0:49 ` [PATCH v1 3/5] fpga: stratix10-soc: Add missing fpga_mgr_free() call Russ Weight
2021-06-09 15:50 ` Xu Yilun
2021-06-09 0:49 ` [PATCH v1 4/5] fpga: bridge: Use standard dev_release for class driver Russ Weight
2021-06-09 15:58 ` Xu Yilun
2021-06-09 0:49 ` [PATCH v1 5/5] fpga: region: " Russ Weight
2021-06-09 16:01 ` Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609004925.238044-3-russell.h.weight@intel.com \
--to=russell.h.weight@intel.com \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=matthew.gerlach@intel.com \
--cc=mdf@kernel.org \
--cc=richard.gong@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).