From: Tom Rix <trix@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Moritz Fischer <mdf@kernel.org>,
Matthew Gerlach <matthew.gerlach@linux.intel.com>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
Wu Hao <hao.wu@intel.com>, Xu Yilun <yilun.xu@intel.com>
Subject: Re: [PATCH v1 1/1] fpga: dfl: pci: Use pci_find_vsec_capability() when looking for DFL
Date: Wed, 10 Nov 2021 04:27:45 -0800 [thread overview]
Message-ID: <3106bd57-9144-6a4d-8ad9-3ebf804018ab@redhat.com> (raw)
In-Reply-To: <YYuBz0tdduAk1c/6@smile.fi.intel.com>
On 11/10/21 12:24 AM, Andy Shevchenko wrote:
> On Tue, Nov 09, 2021 at 10:27:58AM -0800, Tom Rix wrote:
>> On 11/9/21 10:05 AM, Andy Shevchenko wrote:
>>> On Tue, Nov 09, 2021 at 07:55:43AM -0800, Tom Rix wrote:
>>>> On 11/9/21 7:41 AM, Andy Shevchenko wrote:
> ...
>
>>>>> + voff = pci_find_vsec_capability(dev, PCI_VENDOR_ID_INTEL, PCI_VSEC_ID_INTEL_DFLS);
>>>> This may be a weakness in the origin code, but intel isn't the exclusive
>>>> user of DFL.
>>> This does not change the original code. If you think so, this can be extended
>>> later on.
>> I would rather see this fixed now or explained why this isn't a problem.
> This is out of scope of this change in a few ways:
> - we don't do 2+ things in one patch
> - the change doesn't change behaviour
> - the change is a simple cleanup
> - another vendor may well have quite different VSEC ID for DFL
>
> If you think that it should be needed, one can come up with it later on.
Fixing a problem is more useful than a cleanup. The fix should come first.
Tom
>
next prev parent reply other threads:[~2021-11-10 12:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 15:41 [PATCH v1 1/1] fpga: dfl: pci: Use pci_find_vsec_capability() when looking for DFL Andy Shevchenko
2021-11-09 15:55 ` Tom Rix
2021-11-09 18:05 ` Andy Shevchenko
2021-11-09 18:27 ` Tom Rix
2021-11-09 18:51 ` matthew.gerlach
2021-11-10 3:44 ` Xu Yilun
2021-11-10 3:51 ` Wu, Hao
2021-11-10 8:24 ` Andy Shevchenko
2021-11-10 12:27 ` Tom Rix [this message]
2021-11-10 16:59 ` Andy Shevchenko
2024-04-03 11:01 ` Andy Shevchenko
2024-04-03 15:10 ` Xu Yilun
2024-04-03 15:46 ` Andy Shevchenko
2021-11-12 4:25 ` kernel test robot
2021-11-13 6:47 ` kernel test robot
2021-11-15 6:39 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3106bd57-9144-6a4d-8ad9-3ebf804018ab@redhat.com \
--to=trix@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=mdf@kernel.org \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).