From: matthew.gerlach@linux.intel.com
To: Tom Rix <trix@redhat.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Moritz Fischer <mdf@kernel.org>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
Wu Hao <hao.wu@intel.com>, Xu Yilun <yilun.xu@intel.com>
Subject: Re: [PATCH v1 1/1] fpga: dfl: pci: Use pci_find_vsec_capability() when looking for DFL
Date: Tue, 9 Nov 2021 10:51:33 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2111091044060.1548144@rhweight-WRK1> (raw)
In-Reply-To: <39ac1f40-66ab-6c7e-0042-8fcdc062ed00@redhat.com>
On Tue, 9 Nov 2021, Tom Rix wrote:
>
> On 11/9/21 10:05 AM, Andy Shevchenko wrote:
>> On Tue, Nov 09, 2021 at 07:55:43AM -0800, Tom Rix wrote:
>>> On 11/9/21 7:41 AM, Andy Shevchenko wrote:
>>>> Currently the find_dfls_by_vsec() opens code pci_find_vsec_capability().
>>>> Refactor the former to use the latter. No functional change intended.
>> Thanks for review, my answers below.
>>
>> ...
>>
>>>> + u16 voff;
>>> The later use of voff in pci_read_config_dword is of type 'int', it may be
>>> better to keep voff as an int.
>> I don't think so. The rule of thumb that the types should match the value
>> they
>> got in the first place. In this case it's u16. Compiler will implicitly
>> cast it
>> to whatever is needed as long as the type is good for integer promotion.
>>
I think u16 is more precise than int, but I think it'll get promoted to an
int anywhen when used with calls to pci_read_config_dword(). Was this
change tested on real or emulated HW?
>> ...
>>
>>>> + voff = pci_find_vsec_capability(dev, PCI_VENDOR_ID_INTEL,
>>>> PCI_VSEC_ID_INTEL_DFLS);
>>> This may be a weakness in the origin code, but intel isn't the exclusive
>>> user of DFL.
>> This does not change the original code. If you think so, this can be
>> extended
>> later on.
>
> I would rather see this fixed now or explained why this isn't a problem.
I agree that a single Vendor/VSEC id being supported is a problem,
but I think fixing it should be a separate patch. Do we need to change
this a table lookup of Vendor/VSEC id's, or do we need to reserve a more
generic Vendor/VSEC pair?
>
> Tom
>
>>
>>>> if (!voff) {
>>>> dev_dbg(&pcidev->dev, "%s no DFL VSEC found\n", __func__);
>>>> return -ENODEV;
>
>
next prev parent reply other threads:[~2021-11-09 18:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 15:41 [PATCH v1 1/1] fpga: dfl: pci: Use pci_find_vsec_capability() when looking for DFL Andy Shevchenko
2021-11-09 15:55 ` Tom Rix
2021-11-09 18:05 ` Andy Shevchenko
2021-11-09 18:27 ` Tom Rix
2021-11-09 18:51 ` matthew.gerlach [this message]
2021-11-10 3:44 ` Xu Yilun
2021-11-10 3:51 ` Wu, Hao
2021-11-10 8:24 ` Andy Shevchenko
2021-11-10 12:27 ` Tom Rix
2021-11-10 16:59 ` Andy Shevchenko
2024-04-03 11:01 ` Andy Shevchenko
2024-04-03 15:10 ` Xu Yilun
2024-04-03 15:46 ` Andy Shevchenko
2021-11-12 4:25 ` kernel test robot
2021-11-13 6:47 ` kernel test robot
2021-11-15 6:39 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2111091044060.1548144@rhweight-WRK1 \
--to=matthew.gerlach@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).