From: Tom Rix <trix@redhat.com>
To: "Martin Hundebøll" <martin@geanix.com>,
"Wu Hao" <hao.wu@intel.com>, "Moritz Fischer" <mdf@kernel.org>,
"Xu Yilun" <yilun.xu@intel.com>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Mark Brown" <broonie@kernel.org>
Cc: "Martin Hundebøll" <mhu@silicom.dk>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH v5 2/3] spi: spi-altera-dfl: support n5010 feature revision
Date: Fri, 16 Jul 2021 13:44:45 -0700 [thread overview]
Message-ID: <be04e83e-bdf7-3a5c-ff34-a7cbf91f6ba2@redhat.com> (raw)
In-Reply-To: <20210716135441.3235863-3-martin@geanix.com>
On 7/16/21 6:54 AM, Martin Hundebøll wrote:
> From: Martin Hundebøll <mhu@silicom.dk>
>
> The Max10 BMC on the Silicom n5010 PAC is slightly different than the
> existing BMCs, so use a dedicated feature revision detect it.
>
> Signed-off-by: Martin Hundebøll <mhu@silicom.dk>
> Reviewed-by: Moritz Fischer <mdf@kernel.org>
> ---
>
> Changes since v4:
> * Moved spi board_info structure from global/static scope
> to function/stack scope
>
> Changes since v3:
> * Changed "BMC's" to "BMCs"
> * Added Moritz' Reviewed-by
>
> Changes since v2:
> * None
>
> Changes since v1:
> * use feature revision from struct dfl_device instead of reading it
> from io-mem
>
> drivers/spi/spi-altera-dfl.c | 21 ++++++++++++---------
> 1 file changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/spi/spi-altera-dfl.c b/drivers/spi/spi-altera-dfl.c
> index 39a3e1a032e0..44fc9ee13fc7 100644
> --- a/drivers/spi/spi-altera-dfl.c
> +++ b/drivers/spi/spi-altera-dfl.c
> @@ -104,13 +104,6 @@ static const struct regmap_config indirect_regbus_cfg = {
> .reg_read = indirect_bus_reg_read,
> };
>
> -static struct spi_board_info m10_bmc_info = {
> - .modalias = "m10-d5005",
> - .max_speed_hz = 12500000,
> - .bus_num = 0,
> - .chip_select = 0,
> -};
> -
> static void config_spi_master(void __iomem *base, struct spi_master *master)
> {
> u64 v;
> @@ -130,6 +123,7 @@ static void config_spi_master(void __iomem *base, struct spi_master *master)
>
> static int dfl_spi_altera_probe(struct dfl_device *dfl_dev)
> {
> + struct spi_board_info board_info = { 0 };
> struct device *dev = &dfl_dev->dev;
> struct spi_master *master;
> struct altera_spi *hw;
> @@ -170,9 +164,18 @@ static int dfl_spi_altera_probe(struct dfl_device *dfl_dev)
> goto exit;
> }
>
> - if (!spi_new_device(master, &m10_bmc_info)) {
> + if (dfl_dev->revision == FME_FEATURE_REV_MAX10_SPI_N5010)
> + strscpy(board_info.modalias, "m10-n5010", SPI_NAME_SIZE);
> + else
> + strscpy(board_info.modalias, "m10-d5005", SPI_NAME_SIZE);
> +
> + board_info.max_speed_hz = 12500000;
> + board_info.bus_num = 0;
> + board_info.chip_select = 0;
> +
> + if (!spi_new_device(master, &board_info)) {
> dev_err(dev, "%s failed to create SPI device: %s\n",
> - __func__, m10_bmc_info.modalias);
> + __func__, board_info.modalias);
> }
>
Looks good to me.
Reviewed-by: Tom Rix <trix@redhat.com>
> return 0;
next prev parent reply other threads:[~2021-07-16 20:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 13:54 [PATCH v5 0/3] fpga/spi/hwmon: Initial support for Silicom N5010 PAC Martin Hundebøll
2021-07-16 13:54 ` [PATCH v5 1/3] fpga: dfl: expose feature revision from struct dfl_device Martin Hundebøll
2021-07-16 20:46 ` Tom Rix
2021-07-29 20:04 ` Moritz Fischer
2021-07-16 13:54 ` [PATCH v5 2/3] spi: spi-altera-dfl: support n5010 feature revision Martin Hundebøll
2021-07-16 17:33 ` Mark Brown
2021-07-17 23:56 ` Moritz Fischer
2021-07-16 20:44 ` Tom Rix [this message]
2021-07-29 20:05 ` Moritz Fischer
2021-07-16 13:54 ` [PATCH v5 3/3] hwmon: intel-m10-bmc-hwmon: add n5010 sensors Martin Hundebøll
2021-07-17 14:02 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be04e83e-bdf7-3a5c-ff34-a7cbf91f6ba2@redhat.com \
--to=trix@redhat.com \
--cc=broonie@kernel.org \
--cc=hao.wu@intel.com \
--cc=jdelvare@suse.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=martin@geanix.com \
--cc=mdf@kernel.org \
--cc=mhu@silicom.dk \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).